Issue metadata
Sign in to add a comment
|
Regression: Tabstrip area is not seen on browser fullscreen after playing fullscreen video even when 'Always Show Toolbar in Full Screen' option is checked
Reported by
khushal....@etouch.net,
Aug 30
|
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3537.0 (Official Build) Revision 57f65e033d6d9160457a612f5033171bdfeaca42-refs/branch-heads/3537@{#1} (64-bit) OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14) Pre-condition: Enable the flag "Use Views browser windows instead of Cocoa." from chrome://flags/ Test URL: https://permission.site/ What steps will reproduce the problem? (1) Launch chrome, navigate to above test URL. (2) Press 'Fullscreen' button from the website and press 'Esc' to exit from fullscreen. (3) Now click Green Traffic Signal button from tabstrip and Observe. Actual Result: Tabstrip area is not seen on browser fullscreen even when 'Always Show Toolbar in Full Screen' option is checked. Expected Result: Tabstrip area should always be seen on browser fullscreen when 'Always Show Toolbar in Full Screen' option is checked. This is a Regression issue seen from 'M-69' and providing the bisect info below: Good Build: 69.0.3469.0 (Revision: 569383) Bad Build: 69.0.3472.0 (Revision: 569948) You are probably looking for a change made after 569835 (known good), but no later than 569836 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b7a810a2705cfb5af38d365c1f17eb4c0a580a3c..0eadb78c0a33c57f92d339be5139c0c0d7bc53ab Suspect: https://chromium.googlesource.com/chromium/src/+/0eadb78c0a33c57f92d339be5139c0c0d7bc53ab @weili: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1) Issue is also seen on M-69 Beta (build #69.0.3497.72) and M-70 Dev (build #70.0.3534.4). 2) Issue is not seen on Win (7, 8, 8.1, 10) and Linux (14.04 LTS) OS. Please refer the attached screen-cast. Thank You..!!
,
Sep 5
+ellyjones@, could this be M69 stable blocker as it was also highlighted in internal mail thread "Chrome M69 Day 1 - gUP User Feedback Launch Report"?
,
Sep 6
I am working on the fix
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f4ae42d444d85d4d61f6640a83008ad22cded3c commit 2f4ae42d444d85d4d61f6640a83008ad22cded3c Author: Wei Li <weili@chromium.org> Date: Thu Sep 06 23:16:33 2018 Reset toolbar style when exiting tab fullscreen mode On Mac, tab fullscreen mode doesn't show top UI while browser fullscreen mode may show top UI depending on user's preference. When Chrome exits from tab fullscreen, it needs to reset the top UI style to the one corresponding to browser fullscreen. In addition, if it exits from tab fullscreen to browser fullscreen, a re-layout may be triggered if top UI needs to be shown. This CL fixes the problem by calling UpdateUIForTabFullscreen() when Chrome exits tab fullscreen, no matter it is going back to browser fullscreen mode or normal state. So it can update the top UI status correctly. This CL also adds reading initial toolbar style value from user preference. BUG= 879158 Change-Id: I3f2742cad2107667c562701a981f3240f29538bf Reviewed-on: https://chromium-review.googlesource.com/1208721 Reviewed-by: Sidney San Martín <sdy@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#589359} [modify] https://crrev.com/2f4ae42d444d85d4d61f6640a83008ad22cded3c/chrome/browser/ui/exclusive_access/fullscreen_controller.cc [modify] https://crrev.com/2f4ae42d444d85d4d61f6640a83008ad22cded3c/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc [modify] https://crrev.com/2f4ae42d444d85d4d61f6640a83008ad22cded3c/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Sep 6
Sounds like we should try to merge to 69 and take this in the respin.
,
Sep 7
I will first wait for tomorrow's canary to confirm the fix.
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2be1d58768138a51a4ee011843ade9251f95ec00 commit 2be1d58768138a51a4ee011843ade9251f95ec00 Author: Wei Li <weili@chromium.org> Date: Mon Sep 10 07:45:03 2018 Handle exiting tab fullscreen by clicking traffic light button Usually, user exits tab fullscreen mode by clicking 'ESC' button as suggested by exit bubble on Mac. However, during tab fullscreen user can still click the green traffic light button from the slide-down system menu to exit fullscreen. In this case, the toolbar style has to be updated as well. This CL fixes this by calling UpdateFullscreenTopUI() from BrowserNonClientFrameViewMac::OnFullscreenStateChanged() where all the transitions from fullscreen to non-fullscreen mode would pass through. BUG= 879158 Change-Id: I089fa90a260d16681b84eada5759c4e7c60a4f6f Reviewed-on: https://chromium-review.googlesource.com/1213319 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#589848} [modify] https://crrev.com/2be1d58768138a51a4ee011843ade9251f95ec00/chrome/browser/ui/exclusive_access/fullscreen_controller.cc [modify] https://crrev.com/2be1d58768138a51a4ee011843ade9251f95ec00/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc [modify] https://crrev.com/2be1d58768138a51a4ee011843ade9251f95ec00/chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc [modify] https://crrev.com/2be1d58768138a51a4ee011843ade9251f95ec00/chrome/browser/ui/exclusive_access/fullscreen_controller_test.h [modify] https://crrev.com/2be1d58768138a51a4ee011843ade9251f95ec00/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Sep 10
Update: Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14) using latest canary version #71.0.3548.0 and the issue is found FIXED. Hence, adding respective labels. Please refer the attached screen-cast. Thank You..!!
,
Sep 10
,
Sep 10
,
Sep 11
The bug OP originally reported was fixed on 71.0.3545.0, and confirmed. #7 also fixed another case which exits the fullscreen by clicking the green traffic light in step (2). This fix is in today's Canary 71.0.3549.0. Mark the bug as fixed now.
,
Sep 11
I would like to merge both changes to M70, thanks
,
Sep 11
branch:3538
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1da8f12ba56b7dd90f059442d2c0f90e52900925 commit 1da8f12ba56b7dd90f059442d2c0f90e52900925 Author: Wei Li <weili@chromium.org> Date: Tue Sep 11 20:31:09 2018 Reset toolbar style when exiting tab fullscreen mode On Mac, tab fullscreen mode doesn't show top UI while browser fullscreen mode may show top UI depending on user's preference. When Chrome exits from tab fullscreen, it needs to reset the top UI style to the one corresponding to browser fullscreen. In addition, if it exits from tab fullscreen to browser fullscreen, a re-layout may be triggered if top UI needs to be shown. This CL fixes the problem by calling UpdateUIForTabFullscreen() when Chrome exits tab fullscreen, no matter it is going back to browser fullscreen mode or normal state. So it can update the top UI status correctly. This CL also adds reading initial toolbar style value from user preference. BUG= 879158 Change-Id: I3f2742cad2107667c562701a981f3240f29538bf Reviewed-on: https://chromium-review.googlesource.com/1208721 Reviewed-by: Sidney San Martín <sdy@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589359}(cherry picked from commit 2f4ae42d444d85d4d61f6640a83008ad22cded3c) Reviewed-on: https://chromium-review.googlesource.com/1220567 Reviewed-by: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#291} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/1da8f12ba56b7dd90f059442d2c0f90e52900925/chrome/browser/ui/exclusive_access/fullscreen_controller.cc [modify] https://crrev.com/1da8f12ba56b7dd90f059442d2c0f90e52900925/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc [modify] https://crrev.com/1da8f12ba56b7dd90f059442d2c0f90e52900925/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/029e92381b6c171c23a16d75f21fc9c1c022d1fd commit 029e92381b6c171c23a16d75f21fc9c1c022d1fd Author: Wei Li <weili@chromium.org> Date: Tue Sep 11 20:32:14 2018 Handle exiting tab fullscreen by clicking traffic light button Usually, user exits tab fullscreen mode by clicking 'ESC' button as suggested by exit bubble on Mac. However, during tab fullscreen user can still click the green traffic light button from the slide-down system menu to exit fullscreen. In this case, the toolbar style has to be updated as well. This CL fixes this by calling UpdateFullscreenTopUI() from BrowserNonClientFrameViewMac::OnFullscreenStateChanged() where all the transitions from fullscreen to non-fullscreen mode would pass through. BUG= 879158 Change-Id: I089fa90a260d16681b84eada5759c4e7c60a4f6f Reviewed-on: https://chromium-review.googlesource.com/1213319 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589848}(cherry picked from commit 2be1d58768138a51a4ee011843ade9251f95ec00) Reviewed-on: https://chromium-review.googlesource.com/1220037 Reviewed-by: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#293} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/029e92381b6c171c23a16d75f21fc9c1c022d1fd/chrome/browser/ui/exclusive_access/fullscreen_controller.cc [modify] https://crrev.com/029e92381b6c171c23a16d75f21fc9c1c022d1fd/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc [modify] https://crrev.com/029e92381b6c171c23a16d75f21fc9c1c022d1fd/chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc [modify] https://crrev.com/029e92381b6c171c23a16d75f21fc9c1c022d1fd/chrome/browser/ui/exclusive_access/fullscreen_controller_test.h [modify] https://crrev.com/029e92381b6c171c23a16d75f21fc9c1c022d1fd/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Sep 13
This fix caused another regression for me: Issue 884029 .
,
Sep 20
Issue 885275 has been merged into this issue.
,
Sep 20
This issue is NOT fixed on my Mac in Chromium build 71.0.3558.0 or Chrome Canary build 71.0.3557.0. The issue persists, exactly as already described here. I cannot access the tool bar in full screen mode without using the "Always Show Toolbar in Full Screen". I'm just a random end user in the workplace who suddenly discovered that Chrome is now broken in several key ways, including this one. And now I'm going to have to manually downgrade to an old version simply to do my work. Please do better QA before you unleash broken browser updates on millions of people all over the world? Chrome 69 never should have been released.
,
Sep 20
Re. #18, that's tracked as issue 868398.
,
Sep 23
Issue remains on Mac
,
Sep 23
Re #20, we fixed on 70.0.3538.17 and later. It is in Beta, will take a few weeks to reach stable.
,
Nov 9
This problem is STILL not fixed. Are users waiting on a new Google Chrome version update? I will try to manually downgrade to an older version of Google Chrome. Disappointed.
,
Nov 9
#23: What version do you still see this issue in? Is it older or newer than 70.0.3538.17?
,
Nov 9
#24: I just updated to Chrome Version 71.0.3578.44 (Official Build) beta (64-bit) on a MacBook Pro and the problem is still there.
,
Nov 9
#25: Thanks - reopening.
,
Nov 9
I changed the title to clarify that this bug is about showing tab strip in regular browser fullscreen after exiting fullscreen video playing. Please see the video OP posted. If you are expecting to see the tab strip from slide-down menu without always showing tab strip in fullscreen, that is tracked at issue 868398. Feel free to file a new bug if neither of these apply to your case. thanks.
,
Nov 9
#27: Sorry, I made a mistake about which issue is which. This issue is in fact fixed as I followed the steps to reproduce the issue as described at the top, so I can confirm that on Chrome 71.0.3578.44, this issue is fixed. I was talking about the tab strip not showing when Always Show Toolbar in Full Screen is not toggled and the mouse is moved to the top (which results in a grey tab with the traffic light buttons showing up, but not the expected tab strip) which is described in issue 868398.
,
Nov 9
Re: #28, no problem. Thanks for the confirmation. Let's close this bug then.
,
Nov 13
The Issue 868398 discussion board won't allow me to comment on it due to restricted access. If Issue 868398 is the problem I have described, how can I let it be known that Issue 868398 is not fixed yet?
,
Nov 13
#30: You can't - but as the bug is still marked Assigned (not Fixed) we are already aware that it is not fixed yet.
,
Dec 19
Issue still persists - I've been having it starting today with the latest update of chrome ..
,
Jan 2
#32: What version of Chrome are you still seeing this in?
,
Jan 19
(3 days ago)
Still broken in 72.0.3626.64...keep installing updates expecting some sort of movement but nothing for months. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by melodychu@chromium.org
, Sep 5