Bookmark bar button has wrong height if it's the first one added |
||||
Issue descriptionSee attached screenshot and video courtesy of krajshree@ in Issue 833973 . Seen on 70.0.3537.0/macOS but I suspect not Mac specific. To repro: 1. Open an incognito window (or a regular window with the apps button disabled) in a profile with no bookmarks. 2. Add a bookmark or bookmark folder to the bar Expected: Bookmark displays normally Actual: Button height is too small to display the icon correctly cyan@ I assume this is related to your recent changes, but IMO it's pretty low priority, so if you don't have time to address it, I can take care of it as part of my layout manager work.
,
Aug 30
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9 commit 2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9 Author: Charlene Yan <cyan@chromium.org> Date: Thu Aug 30 18:20:16 2018 Fixing the height of the bookmark bar and buttons on the bookmark bar. Bug: 876690 , 876682 , 879154 Change-Id: Ia72f26e9d7e0402868dd628fa2e10492b46a2cee Reviewed-on: https://chromium-review.googlesource.com/1194728 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587664} [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/layout_constants.h [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
,
Aug 31
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #70.0.3537.0. Verified the fix on Mac 10.13.3 using latest chrome version #70.0.3538.0 as per the comment #0. Attaching screen shot for reference. Observed that bookmark displayed properly without any issues. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Sep 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cyan@chromium.org
, Aug 30