Make camera HALv3 and vivid available on public (ie not googler-only) VM image |
||||
Issue descriptionSee crbug.com/852302 where we want to add tests for ChromeOS's video capturing features in waterfall and CQ. For VM testing, we will use vivid, which is enabled only on betty board.
,
Aug 30
IIUC, the only blocker for this is giving Chrome's CQ bots access to the betty VM image. For security reasons, we can't give our bots access to google-only/restricted resources. Everything they do has to be fully public. So what would it take to make the betty VM image publicly available like the amd64-generic one is? Adding both Build and CI bug components.
,
Aug 30
doing a public betty VM seems unlikely at this time. it has all the ARC++ enabled bits in it. you'll need to talk to the people in charge of approving those aspects first.
,
Aug 31
So, we should keep betty internal. Since we don't intend to test ARC++ features, we don't need to use betty. I think we have two options: (1) Enable camera HAL and vivid on amd64-generic (2) Create a new VM image (1) should be easier. Though I'm not sure how many boards will be affected by changing amd64-generic, I will try (1) as the first step. (maybe next week)
,
Aug 31
throw all the stuff you like into amd64-generic ... that's what it's there for. so enabling vivid all the time for it is OK.
,
Sep 4
I changed the summary of this issue because we don't need to make betty public. Instead, I created 3 CLs that make HALv3 and vivid available on amd64-generic: - crrev.com/c/1201651 (target-chromium-os) - crrev.com/i/671312 (internal) - crrev.com/c/1201425 (overlay-amd64-generic)
,
Sep 5
The 3CLs were merged and amd64-generic has HALv3 and vivid now. (though I wonder why bugdroid hasn't report them yet) So, I mark this issue as Fixed.
,
Sep 5
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/project-cheets-private/+/ab30ab327c81119ad05ffa1d654dcdcc4608b003 commit ab30ab327c81119ad05ffa1d654dcdcc4608b003 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Wed Sep 05 12:11:37 2018
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/2c3d0cdc508b8201ab6a84af1bc3406a34ae1f85 commit 2c3d0cdc508b8201ab6a84af1bc3406a34ae1f85 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Wed Sep 05 12:11:51 2018 amd64-generic: Enable arc-camera3 and vivid on amd64-generic To test camera HALv3 on Chromium CQ, we need to enable it on amd64-generic. In addition, we use vivid as an video input device there. Dependency check for USE flag arc-camera3 is added in target-chromium-os by CL:1201651. BUG= chromium:879140 TEST=autotest video_WebRtcCamera on amd64-generic VM with vivid (w/ CL:1201651, CL:*671312) Change-Id: I327340731cb92a90b37859440f20770d1fa848b4 Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1201425 Reviewed-by: Tomasz Figa <tfiga@chromium.org> [add] https://crrev.com/2c3d0cdc508b8201ab6a84af1bc3406a34ae1f85/overlay-amd64-generic/virtual/autotest-capability/autotest-capability-2.ebuild [modify] https://crrev.com/2c3d0cdc508b8201ab6a84af1bc3406a34ae1f85/overlay-amd64-generic/profiles/base/make.defaults [add] https://crrev.com/2c3d0cdc508b8201ab6a84af1bc3406a34ae1f85/overlay-amd64-generic/chromeos-base/autotest-capability-amd64-generic/autotest-capability-amd64-generic-1.0.0.ebuild [add] https://crrev.com/2c3d0cdc508b8201ab6a84af1bc3406a34ae1f85/overlay-amd64-generic/chromeos-base/autotest-capability-amd64-generic/files/20-amd64-generic-capabilities.yaml [add] https://crrev.com/2c3d0cdc508b8201ab6a84af1bc3406a34ae1f85/overlay-amd64-generic/chromeos-base/autotest-capability-amd64-generic/autotest-capability-amd64-generic-1.0.0-r1.ebuild
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0634be292cc36f201ed1d02cafb040140252b519 commit 0634be292cc36f201ed1d02cafb040140252b519 Author: Keiichi Watanabe <keiichiw@chromium.org> Date: Wed Sep 05 12:11:36 2018 target-chromium-os: Add dependency check for cros-camera Our new camera stack HALv3 (chromeos-base/cros-camera) should be installed on all devices, because it doesn't depend on ARC++. As the first step, this patch adds a dependency check for arc-camera3 USE flag, which is moved from an internal overlay (CL:*671312). BUG=b:80502887 BUG= chromium:879140 TEST=Use a USB camera on guado, where ARC++ and HAL v3 are disabled (w/ CL:*671312) TEST=autotest video_WebRtcCamera on amd64-generic VM with vivid, where HALv3 is used (w/ CL:*671312 and CL:1201425) CQ-DEPEND=CL:*671312 Change-Id: I3d779a0b38401aaa7082a8853cc4e652b8f335cb Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1201651 Reviewed-by: Ricky Liang <jcliang@chromium.org> Reviewed-by: Tomasz Figa <tfiga@chromium.org> [modify] https://crrev.com/0634be292cc36f201ed1d02cafb040140252b519/virtual/target-chromium-os/target-chromium-os-1.ebuild [rename] https://crrev.com/0634be292cc36f201ed1d02cafb040140252b519/virtual/target-chromium-os/target-chromium-os-1-r107.ebuild |
||||
►
Sign in to add a comment |
||||
Comment 1 by jclinton@chromium.org
, Aug 30