Issue metadata
Sign in to add a comment
|
Regression : 'Play / Pause' button in PiP window does not work as expected through "Space bar" key.
Reported by
avsha...@etouch.net,
Aug 30
|
||||||||||||||||||||||
Issue descriptionChrome Version : 70.0.3537.0 (Official Build) 57f65e033d6d9160457a612f5033171bdfeaca42-refs/branch-heads/3537@{#1} 32/64 bit OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS) Test URL : https://www.quirksmode.org/html5/tests/video.html What steps will reproduce the problem? 1. Launch chrome, navigate to above URL, click on three dot icon seen in the first video on the page and play that video in PiP mode. 2. Keep mouse over PiP window and press 'Tab' key to bring focus on 'Play' icon in PiP window and then hit 'Space bar' to 'Pause/Play' video. 3. Observe. Actual Result : 'Play / Pause' button in PiP window does not work as expected through "Space bar" key. (i.e can not Pause the currently playing video through 'Space bar') Expected Result : 'Play / Pause' button in PiP window should work as expected through "Space bar" key. This is a regression issue broken in ‘M-70’ and below is the 'Narrow bisect' information: Good Build : 70.0.3535.0 (Revision : 586475) Bad Build : 70.0.3536.0 (Revision : 587136) Narrow Bisect URL : https://chromium.googlesource.com/chromium/src/+log/e0da31580e51574bff71d9f28be7b548e36e7d5c..852186fb786eeef79fe3bde69ce424b228845695 Suspect : r586961 Jennifer@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Provided suspect through 'Narrow bisect' because unable to perform bisect using 'per-revision' script on Windows machines as it is giving trace back error. 2. Also tried to bisect on different machines but still got the same error. 3. Issue is not reproducible in Dev build #70.0.3534.4 4. This issue is not observed in Mac(10.12.6, 10.13.1, 10.14, 10.13.6) OS.
,
Aug 30
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14596236d5a9a8fc7c552ffedba78d78bcf4b67a commit 14596236d5a9a8fc7c552ffedba78d78bcf4b67a Author: Jennifer Apacible <apacible@chromium.org> Date: Thu Aug 30 21:43:40 2018 [Picture in Picture] Only handle space key on Mac. The buttons on other platforms handle the space key as well. This change only adds the handling to toggle play/pause to Mac. The close button is not handled since tabbing is not handled and there are no visual affordances for which button is focused on Mac. These exist on other platforms. Bug: 879139 Change-Id: I40135a7c70fd8d737a2b3b368bfad968d0eeb225 Reviewed-on: https://chromium-review.googlesource.com/1196931 Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#587788} [modify] https://crrev.com/14596236d5a9a8fc7c552ffedba78d78bcf4b67a/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Aug 31
Update : --------- Tested above issue in Canary build #70.0.3538.0 on Windows(7, 8, 8.1, 10) & Linux(14.04 LTS) OS and the issue is fixed. Now, user can Play/Pause PiP video through 'Space bar' key, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..!
,
Aug 31
,
Aug 31
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 7
This has landed in M70. Removing merge-tbd label |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Aug 30Labels: ReleaseBlock-Stable