New issue
Advanced search Search tips

Issue 879136 link

Starred by 1 user
Status: Started
Owner:
mrsuyi@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Refactor FindBarControllerIOS

Project Member Reported by mrsuyi@chromium.org, Aug 30 
Chrome Version: 70.0.3538

Currently FindBarControllerIOS is not using AutoLayout, so the find bar has to be dismissed and re-showed when the device rotates. Refactor it and use AutoLayout instead of AutoResizing.

More cleaning work will be done after UIRreshPhase1 is 100% enabled.

Comment 1 by thegreenfrog@chromium.org, Aug 30

Components: UI>Browser>FindInPage
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c458fbe58abe6fa867b63b0942f6d6767aebdf6

commit 8c458fbe58abe6fa867b63b0942f6d6767aebdf6
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Sep 20 07:54:58 2018

[iOS] Remove FindInPage legacy code

This CL removes the code used by FindInPage pre-UI Refresh.

Bug:  800266 , 879136
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1b3ee786c19cebd54dc641fb7a7d71f5d4b1b8b6
Reviewed-on: https://chromium-review.googlesource.com/1233836
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592716}
[modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/BUILD.gn
[modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/find_bar_touch_forwarding_view.h
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/find_bar_touch_forwarding_view.mm
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/find_bar_ui_element.h
[modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/find_bar_view.h
[modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/find_bar_view.mm
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/legacy_find_bar_view.h
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/legacy_find_bar_view.mm
[modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/resources/BUILD.gn
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/find_bg@2x~ipad.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/find_bg~ipad.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed@3x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/Contents.json
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito@2x.png
[delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito@3x.png
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36c6429ff54906601d1dec408667290f8aae35b7

commit 36c6429ff54906601d1dec408667290f8aae35b7
Author: Yi Su <mrsuyi@chromium.org>
Date: Tue Oct 02 13:16:29 2018

Remove useless parameters in FindBarControllerIOS.

Remove some redundant parameters of
FindBarControllerIOS::addFindBarViewToParentView:usingToolbarView:selectText:animated.

Bug: 879136
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I47dbefdfbadcd160f3466a39ea6b75d90c2e8c78
Reviewed-on: https://chromium-review.googlesource.com/1254722
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595812}
[modify] https://crrev.com/36c6429ff54906601d1dec408667290f8aae35b7/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/36c6429ff54906601d1dec408667290f8aae35b7/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.h
[modify] https://crrev.com/36c6429ff54906601d1dec408667290f8aae35b7/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
►

Sign in to add a comment