[NTP]Confirmation message with 'Restore default shortcuts' is seen even after default shortcuts are already restored
Reported by
vineetha...@etouch.net,
Aug 30
|
||||||
Issue descriptionChrome version : 70.0.3537.0 (Official Build) Revision 57f65e033d6d9160457a612f5033171bdfeaca42-refs/branch-heads/3537@{#1}(32/64-bit) OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags. Steps to reproduce: 1. Launch chrome and open NTP. 2. Click on 'Add Shortcut' icon and add a new shortcut to NTP. 3. Observe that a confirmation message of 'Shortcut added' along with 'Undo' and 'Restore default shortcuts' buttons is seen. 4. While the 'Shortcut added' message is still visible, click on Gear icon ,select 'Restore default shortcuts' option and observe. Actual Result :The confirmation message with 'Restore default shortcuts' is seen even after default shortcuts are already restored. Expected Result:The confirmation message with 'Restore default shortcuts' should not be seen once default shortcuts are restored. This is Non-Regression issue seen from ‘M-70’ as gear icon has been introduced under 'New Tab Page Custom Links' from build #70.0.3509.0
,
Aug 31
,
Sep 6
,
Oct 9
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e64cbafea0309f07827023166963caaadd57ffad commit e64cbafea0309f07827023166963caaadd57ffad Author: Kristi Park <kristipark@chromium.org> Date: Wed Oct 10 19:05:48 2018 [NTP] Hide custom link notification when restore default menu option is clicked Screencast: https://screencast.googleplex.com/cast/NDc0NjU0Njg1OTk5OTIzMnwwYmUwZGM4Ny1lMQ Bug: 879129 Change-Id: Ia9e4b0332c97738582ec0644ef7de1e770424e22 Reviewed-on: https://chromium-review.googlesource.com/c/1271996 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#598431} [modify] https://crrev.com/e64cbafea0309f07827023166963caaadd57ffad/chrome/browser/resources/local_ntp/custom_backgrounds.js [modify] https://crrev.com/e64cbafea0309f07827023166963caaadd57ffad/chrome/browser/resources/local_ntp/local_ntp.js
,
Oct 10
,
Oct 11
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.13.1 , 10.13.6, 10.14.1) and Linux(14.04 LTS)OS with Canary version #71.0.3577.0 and the issue is fixed. Kindly refer the attached screen cast. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yyushkina@chromium.org
, Aug 30