Implement kiosk launch error bubble |
||||||||||||||
Issue descriptionKiosk launch error bubble is not yet implemented on new login screen. It used to be triggered by the following code: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc?l=190&rcl=c2e430c4a5ef55038aac8df4f3e4537c55e65f0a See https://crbug.com/878537#c6
,
Aug 30
,
Sep 5
,
Sep 5
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda commit b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda Author: Quan Nguyen <qnnguyen@chromium.org> Date: Mon Sep 10 17:44:18 2018 cros: Display kiosk app launch errors as a toast in login screen This CL adds a button to the login-dev-overlay to pop up a fake kiosk error message. We also update the ToastManager to allow showing toasts on the Login screen (which also uses LockSystemModalContainer). This involves consolidating the toast requeueing logic into OnSessionStateChanged. Bug: 879117 Change-Id: I557f0444a2368d1bf460d5db0a41f893ce0e69ea Reviewed-on: https://chromium-review.googlesource.com/1211969 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589968} [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/ash/login/login_screen_controller.cc [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/ash/login/login_screen_controller.h [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/ash/public/interfaces/login_screen.mojom [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/ash/system/toast/toast_manager.cc [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/ash/system/toast/toast_manager.h [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/chrome/browser/chromeos/login/app_launch_controller.cc [modify] https://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda/chrome/browser/chromeos/login/ui/kiosk_app_menu_updater.cc
,
Sep 10
,
Sep 10
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 12
,
Sep 13
Approved for M70
,
Sep 13
,
Sep 17
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1c168d92ae43e83cd90aee1ada7f546084348b1 Commit: e1c168d92ae43e83cd90aee1ada7f546084348b1 Author: qnnguyen@chromium.org Commiter: qnnguyen@chromium.org Date: 2018-09-21 20:02:48 +0000 UTC cros: Display kiosk app launch errors as a toast in login screen This CL adds a button to the login-dev-overlay to pop up a fake kiosk error message. We also update the ToastManager to allow showing toasts on the Login screen (which also uses LockSystemModalContainer). This involves consolidating the toast requeueing logic into OnSessionStateChanged. TBR=qnnguyen@chromium.org (cherry picked from commit b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda) Bug: 879117 Change-Id: I557f0444a2368d1bf460d5db0a41f893ce0e69ea Reviewed-on: https://chromium-review.googlesource.com/1211969 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589968} Reviewed-on: https://chromium-review.googlesource.com/1238442 Reviewed-by: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#563} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1c168d92ae43e83cd90aee1ada7f546084348b1 commit e1c168d92ae43e83cd90aee1ada7f546084348b1 Author: Quan Nguyen <qnnguyen@chromium.org> Date: Fri Sep 21 20:02:48 2018 cros: Display kiosk app launch errors as a toast in login screen This CL adds a button to the login-dev-overlay to pop up a fake kiosk error message. We also update the ToastManager to allow showing toasts on the Login screen (which also uses LockSystemModalContainer). This involves consolidating the toast requeueing logic into OnSessionStateChanged. TBR=qnnguyen@chromium.org (cherry picked from commit b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda) Bug: 879117 Change-Id: I557f0444a2368d1bf460d5db0a41f893ce0e69ea Reviewed-on: https://chromium-review.googlesource.com/1211969 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589968} Reviewed-on: https://chromium-review.googlesource.com/1238442 Reviewed-by: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#563} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/ash/login/login_screen_controller.cc [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/ash/login/login_screen_controller.h [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/ash/public/interfaces/login_screen.mojom [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/ash/system/toast/toast_manager.cc [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/ash/system/toast/toast_manager.h [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/chrome/browser/chromeos/login/app_launch_controller.cc [modify] https://crrev.com/e1c168d92ae43e83cd90aee1ada7f546084348b1/chrome/browser/chromeos/login/ui/kiosk_app_menu_updater.cc
,
Sep 25
verified error message is shown to the user in login screen when cancelling auto launch of kiosk application
,
Nov 7
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by poromov@chromium.org
, Aug 30