[NTP]Unnecessary 'Done' button gets enabled on 'Add shortcut' overlay.
Reported by
rp...@etouch.net,
Aug 30
|
|||||||
Issue descriptionChrome Version: 70.0.3537.0 (Official Build)Revision 57f65e033d6d9160457a612f5033171bdfeaca42-refs/branch-heads/3537@{#1}(32/64-bit) OS: Windows(7,8,8.1,10) Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Custom Links" flags from chrome://flags. What steps will reproduce the problem? 1. Launch Chrome and navigate to NTP. 2. Click on 'Add shortcut' thumbnail to open overlay 3. Now right click on url text field and select 'Paste' option(No text is copied),observe Actual: Unnecessary 'Done' button gets enabled even when no text is entered in text field Expected: 'Done' button should not get enable when no text is entered in text field This is a non-regression issue, seen from M-70 series as 'Done' button appears disable by default on 'Add shortcut' thumbnail from build #70.0.3508.0 NOTE: 1. This issue is also reproducible on Dev #70.0.3534.4 2. Issue is not seen on Mac(10.12.6,10.13.1,10.13.6)& Linux (14.04 LTS)OS Kindly review the attached screen-cast for reference. Thank you.
,
Aug 31
Edge case so reducing priority and assigning to Weilun
,
Aug 31
Actually, this may make more sense for Kristi to take a look
,
Sep 6
,
Sep 10
The Done button is enabled whenever the URL text field is modified (regardless if the user deletes all entered in text later), so I don't think this is worth fixing.
,
Sep 10
Ack, pre-emptively marked as wontfix
,
Sep 11
What happens in this case if the user clicks Done?
,
Sep 11
The "Required field" message appears and prevents the form from submitting. In any case, it would be very rare for users to have an empty clipboard.
,
Sep 11
Cool. Won't fix is fine then. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by gangwu@chromium.org
, Aug 31