New issue
Advanced search Search tips

Issue 879106 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

User's profile picture disappears after signing into chrome.

Reported by pranjali...@etouch.net, Aug 30

Issue description

Chrome version : 70.0.3537.0 (Official Build) 57f65e033d6d9160457a612f5033171bdfeaca42-refs/branch-heads/3537@{#1}(32/64 bit)

OS:   Windows(7,8,8.1.10)  and Linux(14.04 LTS) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) 

What steps will reproduce the problem?
1.Launch chrome ,navigate to 'chrome://settings/manageProfile' and select avatar picture.
2. Now sign into chrome with valid credentials and observe avatar icon on omniobx.

Actual  : User's profile picture disappears after signing into chrome.
Expected:  One of user profile picture should be seen in avatar icon after signing into chrome.

This is Non-Regression issue seen from ‘M-67’  as New UI (Md-refresh for chrome)has been introduced from build 67.0.3381.0
 
Note:Issue is not seen on  Win(7,8,8.1,10)  and Linux(14.04 LTS) OS
 
Actual Result.mp4
765 KB View Download
Status: Unconfirmed (was: Untriaged)
Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!
I am currently seeing this on Chrome 69 for Mac OS; this is making it very difficult for me to tell the difference between my various profiles.
Owner: ew...@chromium.org
Status: Assigned (was: Untriaged)
IUUC, the selected avatar picture should be replaced by the profile picture (or monogram) of the signed in account. Assigning to Eli to double-check.
Cc: tangltom@chromium.org ew...@chromium.org
Owner: tangltom@chromium.org
That's correct, but it looks like that's not happening here for some reason; the "generic" default grey avatar is being shown instead of the users' GAIA photo.

Thomas - can you take a quick look?
Status: Started (was: Assigned)
Alright, suggestion: Currently the profile picture is not replaced with the account picture or monogram if you set a custom picture before. So I suggest to
- Implement that a signed in account automatically uses its account picture as the profile picture(which can be changed in Gmail for instance).
- The "Change name and picture" row in settings will be hidden when the user is signed in.

Plus I'll fix the issue with the profile icon when there is only one profile.

Any comments or doubts?
Oh I see, the user had set a custom avatar. Thomas - let's avoid making any changes that complex. I don't want to have to think through all the edge cases (user sets an avatar before signing in, then signs in, then signs back out, etc.)

For now, let's keep the behavior where we show a custom avatar if it's been selected by a signed-in user, but let's just fix the issue with the profile icon when there's only one profile.

Thanks!
Alright, fix is under review :)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa9f0d1fa549475a40f4fe88e50d35a1cc1d55f

commit dfa9f0d1fa549475a40f4fe88e50d35a1cc1d55f
Author: Thomas Tangl <tangltom@chromium.org>
Date: Tue Sep 11 15:09:43 2018

Always prefer custom profile icon instead of generic icon

In the AvatarToolbarButton, always use the explicitely-set
profile icon instead of the generic avatar icon.

Bug:  879106 
Change-Id: I6f9f9fd30710e724516d2a3567a94145ad00b34a
Reviewed-on: https://chromium-review.googlesource.com/1219490
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590308}
[modify] https://crrev.com/dfa9f0d1fa549475a40f4fe88e50d35a1cc1d55f/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc

Status: Fixed (was: Started)
Update:

Rechecked the above issue using latest canary build #71.0.355.0 on Windows(7,8,8.1.10)  and Linux(14.04 LTS) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and issue is still reproducible.

Please refer attached screencast.

Thank You..
Canary Behaviour.mp4
914 KB View Download
pranjali.mahabdi@: When you sign into Chrome, a previous set profile icon gets synced to your Chrome.

Apparently you set a profile icon in the past.
Did you try to go to chrome://settings, then "Chrome name and picture" and select your preferred icon and repeat your testing steps? The issue should be resolved.
Let me know if that works.
Labels: TE-Verified-M71 TE-Verified-71.0.3550.0
With respect to comment 12,

Rechecked the above issue by following steps as mentioned in comment#12 and issue is not reproducible.

Thank You.

Canary Behaviour.mp4
712 KB View Download
Awesome, thanks!
Fixed for me as well. Thanks!
Labels: Merge-Request-70
Glad to hear that :)
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 13

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 14

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b773558fc169566dee41ed1729be69cf1abc8742

commit b773558fc169566dee41ed1729be69cf1abc8742
Author: Thomas Tangl <tangltom@chromium.org>
Date: Fri Sep 14 15:29:47 2018

Always prefer custom profile icon instead of generic icon

In the AvatarToolbarButton, always use the explicitely-set
profile icon instead of the generic avatar icon.

Bug:  879106 
Change-Id: I6f9f9fd30710e724516d2a3567a94145ad00b34a
Reviewed-on: https://chromium-review.googlesource.com/1219490
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590308}(cherry picked from commit dfa9f0d1fa549475a40f4fe88e50d35a1cc1d55f)
Reviewed-on: https://chromium-review.googlesource.com/1225765
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#403}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b773558fc169566dee41ed1729be69cf1abc8742/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc

Labels: TE-Verified-M70 TE-Verified-70.0.3538.22
Update:

Rechecked the above issue using on Beta #70.0.3538.22 on Windows(7,8,8.1.10) ,Linux(14.04 LTS) and Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and issue is fixed.User profile picture is visible after signing into chrome

Please refer attached screencast.

Thank You..
Canary Behaviour.mp4
763 KB View Download

Sign in to add a comment