New issue
Advanced search Search tips

Issue 879090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[servod] dut-power should output how much time has passed

Project Member Reported by coconutruben@chromium.org, Aug 30

Issue description

dut-power can be a very handy cmdline tool, especially as it allows to use Cltr-C to stop a power reading dynamically.
This bug is to track the effort to give more informative output such as printing every 10s that 10s have passed or total time that has passed
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/536576aaaf2831c00af21b029b34700d0e95f12c

commit 536576aaaf2831c00af21b029b34700d0e95f12c
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Sun Sep 09 17:33:48 2018

servod, dut-power: Progress Tracker

This change introduces a visual feedback for dut-power by printing a .
into stdout every 1s to show progress, and aid users with their anxious
fingers if they want to press Ctrl-C and cut the process short.

BUG= chromium:879090 
TEST=Manual testing, 1s rate seems very reasonable

Change-Id: I158aca2e44362e9f5e367427500154a9d6f8ba6c
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1198805
Reviewed-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/536576aaaf2831c00af21b029b34700d0e95f12c/servo/dut_power.py

Status: Fixed (was: Assigned)
This now works :)

Sign in to add a comment