New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 879074 link

Starred by 1 user
Status: Fixed
Owner:
█ jamwalla@chromium.org
Last visit > 30 days ago
Closed: Aug 31
Cc:
dmazz...@chromium.org
sky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"BrowserViewTest.GetAccessibleTabModalDialogTitle" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 30 
"BrowserViewTest.GetAccessibleTabModalDialogTitle" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBCcm93c2VyVmlld1Rlc3QuR2V0QWNjZXNzaWJsZVRhYk1vZGFsRGlhbG9nVGl0bGUM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by yutak@chromium.org, Aug 30

Cc: dmazz...@chromium.org sky@chromium.org
Owner: jamwalla@chromium.org
Status: Assigned (was: Untriaged)
This CL could be relevant:

commit a6f6697e14bc8f86746d7dbdbddd52ee743dc838
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Thu Aug 30 01:27:38 2018

Tab modal dialog title should be accessible window title

Tab modal dialogs (ui::MODAL_TYPE_CHILD) should report their title
to AT (insert+T on JAWS and NVDA) when active. To accomplish this,
BrowserView::GetAccessibleWindowTitle should report the title of
the dialog when one is active.

Bug:  775680 
Test: browser_tests.exe --gtest_filter=BrowserViewTest.GetAccessibleTabModalDialogTitle
Change-Id: Ie693e1627c87e4d97eede64381d80dab31635642
Reviewed-on: https://chromium-review.googlesource.com/1184039
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587371}
[modify] https://crrev.com/a6f6697e14bc8f86746d7dbdbddd52ee743dc838/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/a6f6697e14bc8f86746d7dbdbddd52ee743dc838/chrome/browser/ui/views/frame/browser_view_browsertest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993

commit 7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Thu Aug 30 23:39:40 2018

Reland "Tab modal dialog title should be accessible window title"

This is a reland of a6f6697e14bc8f86746d7dbdbddd52ee743dc838

The test, GetAccessibleTabModalDialogTitle, failed on OSX because
tab-modal dialogs are treated as native windows in Voiceover.
This fix is unnecessary on OSX so the test is now disabled there.

Original change's description:
> Tab modal dialog title should be accessible window title
>
> Tab modal dialogs (ui::MODAL_TYPE_CHILD) should report their title
> to AT (insert+T on JAWS and NVDA) when active. To accomplish this,
> BrowserView::GetAccessibleWindowTitle should report the title of
> the dialog when one is active.
>
> Bug:  775680 
> Test: browser_tests.exe --gtest_filter=BrowserViewTest.GetAccessibleTabModalDialogTitle
> Change-Id: Ie693e1627c87e4d97eede64381d80dab31635642
> Reviewed-on: https://chromium-review.googlesource.com/1184039
> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587371}

Bug:  775680 ,  879074 ,  879253 
Change-Id: I4351a6487a4cb582383fe18b97e825a986464f59
Reviewed-on: https://chromium-review.googlesource.com/1197333
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587845}
[modify] https://crrev.com/7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/7fca17c1c1eb2cfa1a8a9003fe6cd2545fa34993/chrome/browser/ui/views/frame/browser_view_browsertest.cc

Comment 3 by jamwalla@chromium.org, Aug 31

Status: Fixed (was: Assigned)
see also  issue 879253
►

Sign in to add a comment