The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/fd868f2e0bec56b657c73ac8053514e24e09a9c0

commit fd868f2e0bec56b657c73ac8053514e24e09a9c0
Author: Darren Shen <shend@chromium.org>
Date: Mon Sep 10 05:09:10 2018

Add new virtualkeyboard.Omnibox test.

Add a new test which checks that the virtual keyboard appears when
the user clicks on the omnibox.

BUG=chromium:879073

TEST=tested with eve device. Confirmed test fails if we don't enable the
     virtual keyboard.

Change-Id: Ib20acad3015b824025843067f866f4bbdf13db23
Reviewed-on: https://chromium-review.googlesource.com/1201743
Commit-Ready: Darren Shen <shend@chromium.org>
Tested-by: Darren Shen <shend@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/fd868f2e0bec56b657c73ac8053514e24e09a9c0/src/chromiumos/tast/local/bundles/cros/ui/vkb/vkb.go
[modify] https://crrev.com/fd868f2e0bec56b657c73ac8053514e24e09a9c0/src/chromiumos/tast/local/chrome/extensions.go
[add] https://crrev.com/fd868f2e0bec56b657c73ac8053514e24e09a9c0/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_omnibox.go
[modify] https://crrev.com/fd868f2e0bec56b657c73ac8053514e24e09a9c0/src/chromiumos/tast/local/chrome/chrome.go

Tests that we want to add in the future:
- Typing a message into a web input by clicking keys
- Typing with physical keyboard

Because End to End tests are expensive, we'll rely on other types of tests for coverage. These tests are more like sanity checks to confirm that we didn't do something catastrophically bad.

 Issue 783578  has been merged into this issue.

Maybe also add a test about candidates / next word suggestions (to see that the decoder is hooked up correctly).

And also checking that the VK loads in login / guest mode.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/44f376e51e5df8f8a73e6251987888d875abdca5

commit 44f376e51e5df8f8a73e6251987888d875abdca5
Author: Darren Shen <shend@chromium.org>
Date: Tue Sep 25 00:49:39 2018

Enable tast.ui.VirtualKeyboardOmnibox.

Make failures block the CQ. Test looks stable enough.

BUG=chromium:879073
TEST=Linux

Change-Id: I5ca3e21771c5ce3afb5e00d0afe3f16a9cef6760
Reviewed-on: https://chromium-review.googlesource.com/1235366
Commit-Ready: Darren Shen <shend@chromium.org>
Tested-by: Darren Shen <shend@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/44f376e51e5df8f8a73e6251987888d875abdca5/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_omnibox.go

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/a29c0349c07a9e3e0ad51e7813a62aa5fc068f80

commit a29c0349c07a9e3e0ad51e7813a62aa5fc068f80
Author: Dan Erat <derat@chromium.org>
Date: Tue Sep 25 04:08:31 2018

Revert "Enable tast.ui.VirtualKeyboardOmnibox."

This reverts commit 44f376e51e5df8f8a73e6251987888d875abdca5.

Reason for revert: failed in login_VMSanity on elm-paladin:
 https://crbug.com/888884 

Original change's description:
> Enable tast.ui.VirtualKeyboardOmnibox.
> 
> Make failures block the CQ. Test looks stable enough.
> 
> BUG=chromium:879073
> TEST=Linux
> 
> Change-Id: I5ca3e21771c5ce3afb5e00d0afe3f16a9cef6760
> Reviewed-on: https://chromium-review.googlesource.com/1235366
> Commit-Ready: Darren Shen <shend@chromium.org>
> Tested-by: Darren Shen <shend@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>

BUG=chromium:879073, chromium:888884 

Change-Id: I4f99b774881864abca267ede26d2e95311588897
Reviewed-on: https://chromium-review.googlesource.com/1242703
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/a29c0349c07a9e3e0ad51e7813a62aa5fc068f80/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_omnibox.go

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/aac74084bc9729bd338dc6121dc499dfb1d833bd

commit aac74084bc9729bd338dc6121dc499dfb1d833bd
Author: Darren Shen <shend@chromium.org>
Date: Wed Sep 26 17:32:50 2018

Add new ui.VirtualkeyboardTyping test.

Add a new test which checks that tapping keys on the virtual
keyboard sends those keys to a text field on a web page.

BUG=chromium:879073

TEST=tested with eve device.

Change-Id: I21ef9232dc81f0953913acc3bd352868e4411c19
Reviewed-on: https://chromium-review.googlesource.com/1237993
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Darren Shen <shend@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/aac74084bc9729bd338dc6121dc499dfb1d833bd/src/chromiumos/tast/local/bundles/cros/ui/vkb/vkb.go
[modify] https://crrev.com/aac74084bc9729bd338dc6121dc499dfb1d833bd/src/chromiumos/tast/local/chrome/extensions.go
[modify] https://crrev.com/aac74084bc9729bd338dc6121dc499dfb1d833bd/src/chromiumos/tast/local/chrome/chrome.go
[add] https://crrev.com/aac74084bc9729bd338dc6121dc499dfb1d833bd/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_typing.go

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/d3e93dbe7d307dedb16f34f93d928621d21a400b

commit d3e93dbe7d307dedb16f34f93d928621d21a400b
Author: Darren Shen <shend@chromium.org>
Date: Tue Oct 02 16:17:27 2018

Make virtual keyboard tast tests less flaky.

Recently we tried to remove the "informational" attribute from
ui.VirtualKeyboardOmnibox, but it caused some flaky failures.
The source of the flakiness might be from our use of the automation
API: the 'loadComplete' event only fires once, but we listen for
it multiple times, so the other times may not fire.

To fix this, we just repeatedly poll whenever we are waiting for
an element to appear, using |setTimeout|.

We also considered a more "proper" solution of listening only
re-querying on changes to the tree, but A) this requires adding
a JavaScript helper function and B) there could be a lot of tree
changes which means the test could run quite slowly.

BUG= chromium:888884 ,chromium:879073
TEST=tested on eve

Change-Id: I0df98ad7ebd9d31d0089392e256951c77bc6cf39
Reviewed-on: https://chromium-review.googlesource.com/1249403
Commit-Ready: Darren Shen <shend@chromium.org>
Tested-by: Darren Shen <shend@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/d3e93dbe7d307dedb16f34f93d928621d21a400b/src/chromiumos/tast/local/bundles/cros/ui/vkb/vkb.go
[modify] https://crrev.com/d3e93dbe7d307dedb16f34f93d928621d21a400b/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_omnibox.go
[modify] https://crrev.com/d3e93dbe7d307dedb16f34f93d928621d21a400b/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_typing.go

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/f7436063241f35b262770996ef0fe7b9bcdbcdc6

commit f7436063241f35b262770996ef0fe7b9bcdbcdc6
Author: Darren Shen <shend@chromium.org>
Date: Thu Oct 11 04:33:38 2018

Reland "Enable tast.ui.VirtualKeyboardOmnibox."

This is a reland of 44f376e51e5df8f8a73e6251987888d875abdca5

Original change's description:
> Enable tast.ui.VirtualKeyboardOmnibox.
>
> Make failures block the CQ. Test looks stable enough.
>
> BUG=chromium:879073
> TEST=Linux
>
> Change-Id: I5ca3e21771c5ce3afb5e00d0afe3f16a9cef6760
> Reviewed-on: https://chromium-review.googlesource.com/1235366
> Commit-Ready: Darren Shen <shend@chromium.org>
> Tested-by: Darren Shen <shend@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>

Bug: chromium:879073
Change-Id: Id67966081dfdcf5ced4ae295379a6b0b8ea8c579
Reviewed-on: https://chromium-review.googlesource.com/1263216
Commit-Ready: Darren Shen <shend@chromium.org>
Tested-by: Darren Shen <shend@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/f7436063241f35b262770996ef0fe7b9bcdbcdc6/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_omnibox.go

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/4a6efefc91dc7ded04766b9ccfebc3dd2ae02790

commit 4a6efefc91dc7ded04766b9ccfebc3dd2ae02790
Author: Dan Erat <derat@chromium.org>
Date: Thu Oct 11 19:45:29 2018

Revert "Reland "Enable tast.ui.VirtualKeyboardOmnibox.""

This reverts commit f7436063241f35b262770996ef0fe7b9bcdbcdc6.

Reason for revert: Still flaky, per https://crbug.com/893957.

Original change's description:
> Reland "Enable tast.ui.VirtualKeyboardOmnibox."
> 
> This is a reland of 44f376e51e5df8f8a73e6251987888d875abdca5
> 
> Original change's description:
> > Enable tast.ui.VirtualKeyboardOmnibox.
> >
> > Make failures block the CQ. Test looks stable enough.
> >
> > BUG=chromium:879073
> > TEST=Linux
> >
> > Change-Id: I5ca3e21771c5ce3afb5e00d0afe3f16a9cef6760
> > Reviewed-on: https://chromium-review.googlesource.com/1235366
> > Commit-Ready: Darren Shen <shend@chromium.org>
> > Tested-by: Darren Shen <shend@chromium.org>
> > Reviewed-by: Dan Erat <derat@chromium.org>
> 
> Bug: chromium:879073
> Change-Id: Id67966081dfdcf5ced4ae295379a6b0b8ea8c579
> Reviewed-on: https://chromium-review.googlesource.com/1263216
> Commit-Ready: Darren Shen <shend@chromium.org>
> Tested-by: Darren Shen <shend@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>

Bug: chromium:879073,chromium:893957
Change-Id: I285b5433c633e60679a26ce23a6ef8e0d45e71bb
Reviewed-on: https://chromium-review.googlesource.com/c/1277966
Reviewed-by: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/4a6efefc91dc7ded04766b9ccfebc3dd2ae02790/src/chromiumos/tast/local/bundles/cros/ui/virtual_keyboard_omnibox.go