New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 879072 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Sep 5
Cc:
yamaguchi@chromium.org
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Unified System Tray - Notification's actions row corners are not rounded

Project Member Reported by tetsui@chromium.org, Aug 30 
See the screenshot. The row of "COPY TO CLIPBOARD" does not have rounded corners.
Screenshot 2018-08-30 at 4.39.45 PM.png
46.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8521f642a480c1997f0cd05b52b3dcd46772460d

commit 8521f642a480c1997f0cd05b52b3dcd46772460d
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Aug 31 08:44:30 2018

Round notification's action buttons row.

This CL implements UpdateCornersRadius in NotificationViewMD to round
corners of the action buttons row.

It also moves UpdateCornerRadius call done in MessageView by checking
NewStyleNotifications flag check to subclasses (NotificationViewMD and
ArcNotificationView).

TEST=manual
BUG= 879072 

Change-Id: I43932927263ff7cc87d173c27a728d3cc0bc9888
Reviewed-on: https://chromium-review.googlesource.com/1195247
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587971}
[modify] https://crrev.com/8521f642a480c1997f0cd05b52b3dcd46772460d/ash/system/message_center/arc/arc_notification_view.cc
[modify] https://crrev.com/8521f642a480c1997f0cd05b52b3dcd46772460d/ui/message_center/views/message_view.cc
[modify] https://crrev.com/8521f642a480c1997f0cd05b52b3dcd46772460d/ui/message_center/views/notification_background_painter.cc
[modify] https://crrev.com/8521f642a480c1997f0cd05b52b3dcd46772460d/ui/message_center/views/notification_background_painter.h
[modify] https://crrev.com/8521f642a480c1997f0cd05b52b3dcd46772460d/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/8521f642a480c1997f0cd05b52b3dcd46772460d/ui/message_center/views/notification_view_md.h

Comment 2 by tetsui@chromium.org, Sep 5

Status: Fixed (was: Started)
►

Sign in to add a comment