New issue
Advanced search Search tips

Issue 879065 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature

Blocked on: View detail
issue 905953
issue 905954
issue 905952

Blocking:
issue 916424



Sign in to add a comment

Create a test video player

Project Member Reported by dstaessens@chromium.org, Aug 30

Issue description

Create a modular test video player on which video decode accelerator integration tests can be build.

See: go/testvideoplayer


 
Cc: hiroh@chromium.org posciak@chromium.org
As noted on the CL, we already have an media/test/pipeline_integration_test* which can be used for automated testing.

Currently it lacks the ability to create hardware decoders, but that shouldn't be too hard to add from media/gpu. You'd just want to override PipelineIntegrationTestBase::CreateRenderer().
As discussed in the CL: The test video player described here is created to directly test the HW video decoders in media/gpu. As such it is implemented as a client to the VideoDecodeAccelerator interface (and VideoDecoder in the future).
Testing other such clients like the MojoVDService, GpuArcVDA,... is out of scope here. Sound is also out of scope.

The 'video player' name might be a bit confusing as it might implicate higher level functionality. If there is a strong preference I'm open to different names. It's definitely a good idea to look into the media pipeline in the future for higher-level testing.
Blockedon: 905952 905953 905954
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/493db4b2007b14b5283855d8607673b967f85354

commit 493db4b2007b14b5283855d8607673b967f85354
Author: David Staessens <dstaessens@chromium.org>
Date: Tue Nov 20 08:00:06 2018

media/gpu/test: Initial version of the Test Video player.

The test video player is created to improve the way VDA (video decode
accelerator) tests are created, and to allow more control of the test flow.

This is an early prototype, that only supports playing a video from start to
finish. More complex tests and their required functionality will be added soon.

TEST=ran new VDA tests on eve and kevin

BUG=879065

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ida7396e7294c0e367417c352284e4a601daa0cba
Reviewed-on: https://chromium-review.googlesource.com/c/1179484
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609622}
[modify] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/BUILD.gn
[modify] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/BUILD.gn
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/BUILD.gn
[modify] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_decode_accelerator_unittest_helpers.h
[modify] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_frame_validator.cc
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/frame_renderer.h
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/frame_renderer_dummy.cc
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/frame_renderer_dummy.h
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video.cc
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video.h
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video_collection.cc
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video_collection.h
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video_decoder_client.cc
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video_decoder_client.h
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video_player.cc
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/test/video_player/video_player.h
[add] https://crrev.com/493db4b2007b14b5283855d8607673b967f85354/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b898be5f295812d16acf9d0f83baa098fced3d

commit 43b898be5f295812d16acf9d0f83baa098fced3d
Author: Yuta Kitamura <yutak@chromium.org>
Date: Tue Nov 20 08:23:22 2018

Revert "media/gpu/test: Initial version of the Test Video player."

This reverts commit 493db4b2007b14b5283855d8607673b967f85354.

Reason for revert: Compile error on win-rel builder.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/6451

Original change's description:
> media/gpu/test: Initial version of the Test Video player.
> 
> The test video player is created to improve the way VDA (video decode
> accelerator) tests are created, and to allow more control of the test flow.
> 
> This is an early prototype, that only supports playing a video from start to
> finish. More complex tests and their required functionality will be added soon.
> 
> TEST=ran new VDA tests on eve and kevin
> 
> BUG=879065
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Ida7396e7294c0e367417c352284e4a601daa0cba
> Reviewed-on: https://chromium-review.googlesource.com/c/1179484
> Commit-Queue: David Staessens <dstaessens@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609622}

TBR=posciak@chromium.org,sandersd@chromium.org,tikuta@chromium.org,hiroh@chromium.org,acourbot@chromium.org,keiichiw@chromium.org,dstaessens@chromium.org

Change-Id: Ic6ba5ba69c6ebae256d0e39d1b3af739e47b75da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879065
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1343870
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609626}
[modify] https://crrev.com/43b898be5f295812d16acf9d0f83baa098fced3d/BUILD.gn
[modify] https://crrev.com/43b898be5f295812d16acf9d0f83baa098fced3d/media/gpu/BUILD.gn
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/BUILD.gn
[modify] https://crrev.com/43b898be5f295812d16acf9d0f83baa098fced3d/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/43b898be5f295812d16acf9d0f83baa098fced3d/media/gpu/test/video_decode_accelerator_unittest_helpers.h
[modify] https://crrev.com/43b898be5f295812d16acf9d0f83baa098fced3d/media/gpu/test/video_frame_validator.cc
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/frame_renderer.h
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/frame_renderer_dummy.cc
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/frame_renderer_dummy.h
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video.cc
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video.h
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video_collection.cc
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video_collection.h
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video_decoder_client.cc
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video_decoder_client.h
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video_player.cc
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/test/video_player/video_player.h
[delete] https://crrev.com/8979a892a53c9dfe50429e34ad4973287c270bc0/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82b5b7d77baeee0ff8fa53e73058f96bbcde9075

commit 82b5b7d77baeee0ff8fa53e73058f96bbcde9075
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Nov 21 10:40:26 2018

Re-land "media/gpu/test: Initial version of the Test Video player."

- Fixed build failure of win_rel target.
- Made tests chromeos-only for now.

> This reverts commit 493db4b2007b14b5283855d8607673b967f85354.

> Reason for revert: Compile error on win-rel builder.
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/6451

> Original change's description:
> > media/gpu/test: Initial version of the Test Video player.
> >
> > The test video player is created to improve the way VDA (video decode
> > accelerator) tests are created, and to allow more control of the test flow.
> >
> > This is an early prototype, that only supports playing a video from start to
> > finish. More complex tests and their required functionality will be added soon.
> >
> > TEST=ran new VDA tests on eve and kevin
> >
> > BUG=879065
> >
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> > Change-Id: Ida7396e7294c0e367417c352284e4a601daa0cba
> > Reviewed-on: https://chromium-review.googlesource.com/c/1179484
> > Commit-Queue: David Staessens <dstaessens@chromium.org>

BUG=879065

Change-Id: Ibc17303776b2378470b50da88948bc6907732411
Reviewed-on: https://chromium-review.googlesource.com/c/1345670
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609988}
[modify] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/BUILD.gn
[modify] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/BUILD.gn
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/BUILD.gn
[modify] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_decode_accelerator_unittest_helpers.h
[modify] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_frame_validator.cc
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/frame_renderer.h
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/frame_renderer_dummy.cc
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/frame_renderer_dummy.h
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video.cc
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video.h
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video_collection.cc
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video_collection.h
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video_decoder_client.cc
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video_decoder_client.h
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video_player.cc
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/test/video_player/video_player.h
[add] https://crrev.com/82b5b7d77baeee0ff8fa53e73058f96bbcde9075/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7883e6b920a48029194e382dfb6ed5f7f5b4390c

commit 7883e6b920a48029194e382dfb6ed5f7f5b4390c
Author: David Staessens <dstaessens@chromium.org>
Date: Mon Nov 26 03:28:40 2018

media/gpu/test: Cleanup and split test helpers build target.

This change splits up the test helpers target in separate encode, decode and
other helpers. Tests now only depend on what they actually need. This change
doesn't introduce any new code, but some things are moved to avoid weird
dependancies (such as encode helpers depending on frame mapper which depends on
decode helpers).

This change also moves code in the video_accelerator_unittest_helpers.h file
from the media to the media/test namespace.

TEST=ran video/jpeg encode/decode tests on nocturne

CQ-DEPEND=CL:1345670

BUG=879065

Change-Id: I17704399c5724cbacc5611578e0dec22191e7a50
Reviewed-on: https://chromium-review.googlesource.com/c/1345701
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610757}
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/BUILD.gn
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/jpeg_encode_accelerator_unittest.cc
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/test/BUILD.gn
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/test/rendering_helper.cc
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/test/video_accelerator_unittest_helpers.h
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/test/video_frame_validator.cc
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/test/video_frame_validator.h
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/7883e6b920a48029194e382dfb6ed5f7f5b4390c/media/gpu/video_encode_accelerator_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ceea004146d58340264b0cef7e1976e94208e6f

commit 8ceea004146d58340264b0cef7e1976e94208e6f
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Nov 26 11:32:34 2018

Revert "media/gpu/test: Cleanup and split test helpers build target."

This reverts commit 7883e6b920a48029194e382dfb6ed5f7f5b4390c.

Reason for revert:
video_decode_accelerator_unittest fails to link in Windows component builds

Original change's description:
> media/gpu/test: Cleanup and split test helpers build target.
> 
> This change splits up the test helpers target in separate encode, decode and
> other helpers. Tests now only depend on what they actually need. This change
> doesn't introduce any new code, but some things are moved to avoid weird
> dependancies (such as encode helpers depending on frame mapper which depends on
> decode helpers).
> 
> This change also moves code in the video_accelerator_unittest_helpers.h file
> from the media to the media/test namespace.
> 
> TEST=ran video/jpeg encode/decode tests on nocturne
> 
> CQ-DEPEND=CL:1345670
> 
> BUG=879065
> 
> Change-Id: I17704399c5724cbacc5611578e0dec22191e7a50
> Reviewed-on: https://chromium-review.googlesource.com/c/1345701
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Commit-Queue: David Staessens <dstaessens@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610757}

TBR=hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org

Change-Id: If341a83edf8b0ad74180895860f9ebfbb396e5f6
No-Presubmit: true
No-Tree-Checks: true
Bug: 879065,  908360 
Reviewed-on: https://chromium-review.googlesource.com/c/1349981
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610815}
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/BUILD.gn
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/jpeg_encode_accelerator_unittest.cc
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/test/BUILD.gn
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/test/rendering_helper.cc
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/test/video_accelerator_unittest_helpers.h
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/test/video_frame_validator.cc
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/test/video_frame_validator.h
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/8ceea004146d58340264b0cef7e1976e94208e6f/media/gpu/video_encode_accelerator_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea1d565dccc9819b9ab30e7d7e7ddd725fff45b

commit 4ea1d565dccc9819b9ab30e7d7e7ddd725fff45b
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Nov 29 07:17:51 2018

media/gpu/test: Created test environment for video decode related test setup.

This change moves all test-related setup and teardown to a separate test
environment. It also fixes a small bug that causes a crash when destroying the
video player without playing a video.

TEST=ran new VD tests on nocturne

BUG=879065

Change-Id: I0f746ff3aff1598130d563aa8241e87f3d739c8a
Reviewed-on: https://chromium-review.googlesource.com/c/1350413
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612083}
[modify] https://crrev.com/4ea1d565dccc9819b9ab30e7d7e7ddd725fff45b/media/gpu/BUILD.gn
[modify] https://crrev.com/4ea1d565dccc9819b9ab30e7d7e7ddd725fff45b/media/gpu/test/video_player/video_decoder_client.cc
[modify] https://crrev.com/4ea1d565dccc9819b9ab30e7d7e7ddd725fff45b/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c5fa74f45fcc511536eb347d86bcaa39fc679cb

commit 1c5fa74f45fcc511536eb347d86bcaa39fc679cb
Author: David Staessens <dstaessens@chromium.org>
Date: Fri Nov 30 02:11:19 2018

re-land "media/gpu/test: Cleanup and split test helpers build target."

> This change splits up the test helpers target in separate encode, decode and
> other helpers. Tests now only depend on what they actually need. This change
> doesn't introduce any new code, but some things are moved to avoid weird
> dependancies (such as encode helpers depending on frame mapper which depends on
> decode helpers).

> This change also moves code in the video_accelerator_unittest_helpers.h file
> from the media to the media/test namespace.
>
> TEST=ran video/jpeg encode/decode tests on nocturne
>
> CQ-DEPEND=CL:1345670
>
> BUG=879065, 904337 
>
> Change-Id: I17704399c5724cbacc5611578e0dec22191e7a50
> Reviewed-on: https://chromium-review.googlesource.com/c/1345701
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Commit-Queue: David Staessens <dstaessens@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610757}

BUG=879065

Change-Id: I3c478745acdecc7bcbea089a079603c0c2472cdd
Reviewed-on: https://chromium-review.googlesource.com/c/1351193
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612518}
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/BUILD.gn
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/jpeg_encode_accelerator_unittest.cc
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/test/BUILD.gn
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/test/rendering_helper.cc
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/test/video_accelerator_unittest_helpers.h
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/test/video_frame_validator.cc
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/test/video_frame_validator.h
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/1c5fa74f45fcc511536eb347d86bcaa39fc679cb/media/gpu/video_encode_accelerator_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 18

Blocking: 916424
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8

commit 86549ccf9c22f9d538d4a111c7fbd6105f99ffe8
Author: David Staessens <dstaessens@chromium.org>
Date: Fri Jan 11 04:27:01 2019

media/gpu/test: Adapt new video decode accelerator tests to use import mode.

The media::VideoDecoder interface doesn't have an allocate mode, video frames
are allocated inside a buffer allocator. To prepare for the migration of the
video decoders to the media::VideoDecoder interface, the video player has been
adapted to use import mode.

This CL also improves the way video frames are consumed. Rather than providing
a callback, the video frame is wrapped in another video frame that will release
the associated picture buffer upon destruction. This is done to prepare for the
integration of the frame validator, so multiple entities will be able to consume
video frames.

TEST=ran new VDA tests on nocturne

BUG=879065

Change-Id: I88d1f2c44489ed1692246372e6bd872efae5205b
Reviewed-on: https://chromium-review.googlesource.com/c/1399761
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621905}
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/BUILD.gn
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/texture_ref.cc
[add] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_frame_helpers.cc
[add] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_frame_helpers.h
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_player/frame_renderer.h
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_player/frame_renderer_dummy.cc
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_player/frame_renderer_dummy.h
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_player/video_decoder_client.cc
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_player/video_decoder_client.h
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/test/video_player/video_player.cc
[modify] https://crrev.com/86549ccf9c22f9d538d4a111c7fbd6105f99ffe8/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af80085e5dbca972b291d8e4435248e1a9ddb167

commit af80085e5dbca972b291d8e4435248e1a9ddb167
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Jan 16 02:15:01 2019

media/gpu/test: Integrate frame validator in new video decode accelerator tests.

This CL integrates the frame validator into the test video player. Golden md5
checksums are loaded from disk, and used to validate each decoded video frame.

This CL also performs some minor cleanup.

TEST=ran new VDA tests on nocturne

BUG=879065

Change-Id: I53daaab033753e8ca83c9589d31d7940641ed154
Reviewed-on: https://chromium-review.googlesource.com/c/1401930
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623041}
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/BUILD.gn
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/BUILD.gn
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_frame_mapper_factory.cc
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_frame_mapper_factory.h
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_frame_validator.cc
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_frame_validator.h
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_player/frame_renderer_dummy.cc
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_player/video.cc
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_player/video.h
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_player/video_decoder_client.cc
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_player/video_decoder_client.h
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_player/video_player.cc
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/test/video_player/video_player.h
[modify] https://crrev.com/af80085e5dbca972b291d8e4435248e1a9ddb167/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cec8d9d75829be135c32b5e5a0c5e82eeb26cce

commit 5cec8d9d75829be135c32b5e5a0c5e82eeb26cce
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Jan 16 03:16:33 2019

media/gpu/test: Add helper functions to improve video decode test readability.

This CL adds a few helper functions such as 'WaitForFlushDone', so we can
shorten statements such as 'WaitForEvent(VideoPlayerEvent::kFlushDone)'. This
improves test readability and brevity.

TEST=ran new VDA tests on nocturne

BUG=879065

Change-Id: If58258100a697f5bae43f36f5e9a76b35a970669
Reviewed-on: https://chromium-review.googlesource.com/c/1358107
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623080}
[modify] https://crrev.com/5cec8d9d75829be135c32b5e5a0c5e82eeb26cce/media/gpu/test/video_player/video_player.cc
[modify] https://crrev.com/5cec8d9d75829be135c32b5e5a0c5e82eeb26cce/media/gpu/test/video_player/video_player.h
[modify] https://crrev.com/5cec8d9d75829be135c32b5e5a0c5e82eeb26cce/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbf9aac90ae1f8d6250ac5e753b733e60816e780

commit fbf9aac90ae1f8d6250ac5e753b733e60816e780
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Jan 17 01:48:15 2019

media/gpu/test: Add per-test setup and teardown to the video decoder tests.

This CL adds per-test setup and teardown to the video decoder tests. This allows
us to remove some setters and move arguments to the constructors of the video
player and video frame validator.

TEST=ran new VDA tests on nocturne

BUG=879065

Change-Id: If6e070fcd684d8fffe0bf9c7a553191a247165f3
Reviewed-on: https://chromium-review.googlesource.com/c/1412095
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623504}
[modify] https://crrev.com/fbf9aac90ae1f8d6250ac5e753b733e60816e780/media/gpu/test/video_frame_validator.cc
[modify] https://crrev.com/fbf9aac90ae1f8d6250ac5e753b733e60816e780/media/gpu/test/video_frame_validator.h
[modify] https://crrev.com/fbf9aac90ae1f8d6250ac5e753b733e60816e780/media/gpu/test/video_player/video_decoder_client.cc
[modify] https://crrev.com/fbf9aac90ae1f8d6250ac5e753b733e60816e780/media/gpu/test/video_player/video_decoder_client.h
[modify] https://crrev.com/fbf9aac90ae1f8d6250ac5e753b733e60816e780/media/gpu/test/video_player/video_player.cc
[modify] https://crrev.com/fbf9aac90ae1f8d6250ac5e753b733e60816e780/media/gpu/test/video_player/video_player.h
[modify] https://crrev.com/fbf9aac90ae1f8d6250ac5e753b733e60816e780/media/gpu/video_decode_accelerator_tests.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/848f6501951dbfb0d643f0a8476722f981ae9ce0

commit 848f6501951dbfb0d643f0a8476722f981ae9ce0
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Jan 17 03:58:15 2019

media/gpu/test: Add generic VideoFrameProcessor interface for testing.

To increase flexibility and to avoid code duplication, this CL adds a generic
VideoFrameProcessor interface. This interface will be used to write re-usable
test helpers that write video frames to files, calculate video frame checksums,
validate video frames,...

Currently the VideoFrameValidator is the only one using this interface but more
processors will be added soon. The video player API is slighty adapted to allow
multiple VideoFrameProcessors to be plugged in.

This CL also contains some minor cleanup.

TEST=ran new VDA tests on nocturne

BUG=879065

Change-Id: I376e0d5aefdfb5af966d1bde7facc5c9f7062340
Reviewed-on: https://chromium-review.googlesource.com/c/1404763
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623566}
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/BUILD.gn
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_frame_helpers.h
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_frame_mapper_factory.h
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_frame_validator.cc
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_frame_validator.h
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_player/video_decoder_client.cc
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_player/video_decoder_client.h
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_player/video_player.cc
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/test/video_player/video_player.h
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/video_decode_accelerator_tests.cc
[modify] https://crrev.com/848f6501951dbfb0d643f0a8476722f981ae9ce0/media/gpu/video_decode_accelerator_unittest.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Yesterday (30 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f806f16bc931b1a7553291ffaa96b8b54ba4309

commit 4f806f16bc931b1a7553291ffaa96b8b54ba4309
Author: David Staessens <dstaessens@chromium.org>
Date: Tue Jan 22 03:34:55 2019

media/gpu/test: Add DCHECK's to ensure video decoder tests operate correctly.

TEST=ran new VDA tests on nocturne

BUG=879065

Change-Id: I13f66117ceee1fa75f0e41b98fd95097e28d50b2
Reviewed-on: https://chromium-review.googlesource.com/c/1425844
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624720}
[modify] https://crrev.com/4f806f16bc931b1a7553291ffaa96b8b54ba4309/media/gpu/test/video_player/video_decoder_client.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Yesterday (29 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70f0033815acc1a4388acc79308f0d41c88dd017

commit 70f0033815acc1a4388acc79308f0d41c88dd017
Author: David Staessens <dstaessens@chromium.org>
Date: Tue Jan 22 04:15:45 2019

media/gpu/test: Add new VDA test for multiple queued buffer decode requests.

This CL adds a test that requests multiple bitstream buffer decodes, without
waiting for the result of the previous decode operation.

TEST=ran new VDA tests on nocturne

BUG=879065

Change-Id: I72352206ae56e9a3e4f62f87271c978bbad7bfee
Reviewed-on: https://chromium-review.googlesource.com/c/1419560
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624723}
[modify] https://crrev.com/70f0033815acc1a4388acc79308f0d41c88dd017/media/gpu/test/video_player/video_decoder_client.cc
[modify] https://crrev.com/70f0033815acc1a4388acc79308f0d41c88dd017/media/gpu/test/video_player/video_decoder_client.h
[modify] https://crrev.com/70f0033815acc1a4388acc79308f0d41c88dd017/media/gpu/test/video_player/video_player.cc
[modify] https://crrev.com/70f0033815acc1a4388acc79308f0d41c88dd017/media/gpu/test/video_player/video_player.h
[modify] https://crrev.com/70f0033815acc1a4388acc79308f0d41c88dd017/media/gpu/video_decode_accelerator_tests.cc

Sign in to add a comment