Regression : Page becomes unresponsive after entering long text in 'Add shortcut' overlay on NTP.
Reported by
rp...@etouch.net,
Aug 30
|
||||||||||
Issue descriptionVersion: 70.0.3537.0 (Official Build)Revision 57f65e033d6d9160457a612f5033171bdfeaca42-refs/branch-heads/3537@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6) Pre condition : Enable Google local NTP and New Tab Page Custom Links from chrome://flags. What steps will reproduce the problem? 1. Launch chrome, open NTP and click on 'Add shortcut' thumbnail 2. Now in 'Add shortcut' overlay under Url text field type any long text and try to click on done button or on NTP page,observe Actual: Page becomes unresponsive after entering long text in Url text field of 'Add shortcut' overlay Expected: Page should not become unresponsive after entering long text in Url text field of 'Add shortcut' overlay This is a Regression issue seen from 'M-70' and providing the bisect info below: Good Build: 70.0.3532.0 (Revision: 585633) Bad Build: 70.0.3533.0 (Revision: 586155) You are probably looking for a change made after 586023 (known good), but no later than 586029 (first known bad). Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/d24b31e29bf10c1490a19429dd5e1dea4cbf5d74..9c6ba22ab239412805bb386f09779c76d918bba3?pretty=fuller&n=50 Suspecting: 90512ec79cc3358a8072bdad4718c54ea0961638 from Narrow Bisect @kristipark: Could you please help to reassign if your change is not the cause for this change. Note: 1.Issue is also seen on Dev build #70.0.3534.4 2.Unable to provide bisect using per-revision script as (a)[Errno 2] No such file or directory error message is thrown on Mac os and (b)Unable to find local data files error is thrown on Windows,Linux OS, hence providing narrow bisect
,
Aug 31
Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Sep 4
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/577427e5227fca46ec3d39f1116f3bca7b467fdb commit 577427e5227fca46ec3d39f1116f3bca7b467fdb Author: kristipark <kristipark@chromium.org> Date: Thu Sep 06 00:06:54 2018 [NTP] Add max 150 character limit to custom link titles Bug: 879064 Change-Id: If965059e7e279c772b9f808cf65a3119e60e1fa1 Reviewed-on: https://chromium-review.googlesource.com/1205097 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589068} [modify] https://crrev.com/577427e5227fca46ec3d39f1116f3bca7b467fdb/chrome/browser/resources/local_ntp/most_visited_single.js [modify] https://crrev.com/577427e5227fca46ec3d39f1116f3bca7b467fdb/chrome/renderer/searchbox/searchbox_extension.cc
,
Sep 6
,
Sep 6
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 6
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6) with latest Canary Chrome version : 71.0.3544.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast for reference. Thank you..!!
,
Sep 6
Fix has been verified, requesting merge to M70.
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9da11e48149292637363ec2a165dd5eb25db8205 commit 9da11e48149292637363ec2a165dd5eb25db8205 Author: kristipark <kristipark@chromium.org> Date: Mon Sep 10 17:43:23 2018 [Merge M70] [NTP] Add max 150 character limit to custom link titles Bug: 879064 Change-Id: If965059e7e279c772b9f808cf65a3119e60e1fa1 Reviewed-on: https://chromium-review.googlesource.com/1205097 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589068}(cherry picked from commit 577427e5227fca46ec3d39f1116f3bca7b467fdb) Reviewed-on: https://chromium-review.googlesource.com/1216850 Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#225} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/9da11e48149292637363ec2a165dd5eb25db8205/chrome/browser/resources/local_ntp/most_visited_single.js [modify] https://crrev.com/9da11e48149292637363ec2a165dd5eb25db8205/chrome/renderer/searchbox/searchbox_extension.cc
,
Sep 12
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6) using latest Dev build : 70.0.3538.16 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast for reference. Thank you..!! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by kristip...@chromium.org
, Aug 31