Regression:Browser gets crashed on closing incognito window after performing audit in incognito window.
Reported by
shruti.j...@etouch.net,
Aug 30
|
|||||
Issue descriptionChrome Version:70.0.3536.0 (Official Build) Revision 2494dce8176ec31c55bd19cda2a009da525d2cbc-refs/branch-heads/3536@{#1}(64-bit) OS:Mac (10.12.6, 10.13.1, 10.13.5). Test URL:https:gmail.com Steps to reproduce: 1.Launch chrome and open incognito window from wrench menu. 2.Perform audit on above given URl. 3.Close incoginto and observe. Actual Result: Browser gets crashed on closing incognito window after performing audit in incognito window. Expected Result: Browser should not get crashed on closing incognito window after performing audit in incognito window. CRASH ID:Uploaded Crash Report ID d33d9ff73327eb61 (Local Crash ID: 26fab16f-93c4-4cd6-8cc4-b80c9de1fc5b) This is a regression issue broken in “M-70” and will soon update the other info. Kindly refer the attached screen-cast from drive link. https://drive.google.com/open?id=1PO2SBeAwmL7xdLXdodWaqjZIytseWSlB
,
Aug 30
Stack trace for the provided crash id: -------------------------------------- Thread 0 (id: 0x292f) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x0000002a ] MAGIC SIGNATURE THREAD Stack Quality84%Show frame trust levels 0x0000000105a22f42 (Google Chrome Framework -__functional_base:55 ) base::SupportsUserData::GetUserData(void const*) const 0x000000010421fb4c (Google Chrome Framework -browser_context.cc:134 ) content::(anonymous namespace)::GetStoragePartitionFromConfig(content::BrowserContext*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, bool) 0x000000010421fcf8 (Google Chrome Framework -browser_context.cc:320 ) <name omitted> 0x0000000107d054b1 (Google Chrome Framework -tcp_device_provider.cc:167 ) TCPDeviceProvider::InitializeHostResolverOnUI(mojo::InterfaceRequest<network::mojom::HostResolver>) 0x0000000107d05ac8 (Google Chrome Framework -bind_internal.h:516 ) base::internal::Invoker<base::internal::BindState<void (TCPDeviceProvider::*)(mojo::InterfaceRequest<network::mojom::HostResolver>), scoped_refptr<TCPDeviceProvider>, mojo::InterfaceRequest<network::mojom::HostResolver> >, void ()>::RunOnce(base::internal::BindStateBase*) 0x00000001059ca201 (Google Chrome Framework -callback.h:99 ) base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) 0x00000001059e817d (Google Chrome Framework -message_loop.cc:434 ) base::MessageLoop::RunTask(base::PendingTask*) 0x00000001059e84e2 (Google Chrome Framework -message_loop.cc:445 ) base::MessageLoop::DoWork() 0x00000001059eaa49 (Google Chrome Framework -message_pump_mac.mm:455 ) base::MessagePumpCFRunLoopBase::RunWork() 0x00000001059dc659 (Google Chrome Framework + 0x02425659 ) base::mac::CallWithEHFrame(void () block_pointer) 0x00000001059ea36e (Google Chrome Framework -message_pump_mac.mm:431 ) base::MessagePumpCFRunLoopBase::RunWorkSource(void*) 0x00007fff2d6a7a10 (CoreFoundation + 0x000a3a10 ) __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 0x00007fff2d76142b (CoreFoundation + 0x0015d42b ) __CFRunLoopDoSource0 0x00007fff2d68a46f (CoreFoundation + 0x0008646f ) __CFRunLoopDoSources0 0x00007fff2d6898ec (CoreFoundation + 0x000858ec ) __CFRunLoopRun 0x00007fff2d689152 (CoreFoundation + 0x00085152 ) CFRunLoopRunSpecific 0x00007fff2c973d95 (HIToolbox + 0x0002fd95 ) RunCurrentEventLoopInMode 0x00007fff2c973b05 (HIToolbox + 0x0002fb05 ) ReceiveNextEventCommon 0x00007fff2c973883 (HIToolbox + 0x0002f883 ) _BlockUntilNextEventMatchingListInModeWithFilter 0x00007fff2ac24a72 (AppKit + 0x00041a72 ) _DPSNextEvent 0x00007fff2b3bae33 (AppKit + 0x007d7e33 ) -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 0x00000001055dd16f (Google Chrome Framework -chrome_browser_application_mac.mm:242 ) __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke 0x00000001059dc659 (Google Chrome Framework + 0x02425659 ) base::mac::CallWithEHFrame(void () block_pointer) 0x00000001055dd0a3 (Google Chrome Framework -chrome_browser_application_mac.mm:241 ) -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 0x00007fff2ac19884 (AppKit + 0x00036884 ) -[NSApplication run] 0x00000001059eb30b (Google Chrome Framework -message_pump_mac.mm:808 ) base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) 0x00000001059e9e8d (Google Chrome Framework -message_pump_mac.mm:184 ) base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) 0x0000000105a0cc24 (Google Chrome Framework -run_loop.cc:102 ) <name omitted> 0x00000001055e3f0c (Google Chrome Framework -chrome_browser_main.cc:2069 ) ChromeBrowserMainParts::MainMessageLoopRun(int*) 0x00000001042259e3 (Google Chrome Framework -browser_main_loop.cc:1024 ) content::BrowserMainLoop::RunMainMessageLoopParts() 0x0000000104228131 (Google Chrome Framework -browser_main_runner_impl.cc:161 ) content::BrowserMainRunnerImpl::Run() 0x000000010422243a (Google Chrome Framework -browser_main.cc:47 ) content::BrowserMain(content::MainFunctionParams const&) 0x000000010559afd1 (Google Chrome Framework -content_main_runner_impl.cc:538 ) content::ContentMainRunnerImpl::Run(bool) 0x000000010725ca8c (Google Chrome Framework -main.cc:472 ) service_manager::Main(service_manager::MainParams const&) 0x000000010559a253 (Google Chrome Framework -content_main.cc:19 ) content::ContentMain(content::ContentMainParams const&) 0x00000001035ba7f2 (Google Chrome Framework -chrome_main.cc:101 ) ChromeMain 0x000000010358ddd0 (Google Chrome -chrome_exe_main_mac.cc:101 ) main 0x00007fff554cc014 (libdyld.dylib + 0x00001014 ) start 0x00007fff554cc014 (libdyld.dylib + 0x00001014 ) start Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Aug 30
I can repro this crash locally on trunk at 95cc1cb6. The actual crash that I see is that sequence_checker_ in SupportsUserData for the BrowserContext is deallocated when we try to use it from TCPDeviceProvider::InitializeHostResolverOnUI.
,
Aug 30
Regressed recently in M70 and is the #1 crash in mac canary- 70.0.3537.0. 70.0.3537.0 46.58% 34 70.0.3536.0 50.68% 37 Link to the builds ================== https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3A%60anonymous+namespace%5C%27%3A%3AGetStoragePartitionFromConfig%27+AND+product_name%3D%27Chrome_Mac%27#-samplereports,-productname:1000,-magicsignature:50,-magicsignature2:50,-stablesignature:50,-magicsignaturesorted:50 Can we get this reverted ASAP, we are branching today.
,
Aug 30
Revert is in progress at crrev.com/c/1197109, just waiting for the Win7 bot.
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d241becc763d91ffb9bd542ec35234401a05c10 commit 7d241becc763d91ffb9bd542ec35234401a05c10 Author: Clark DuVall <cduvall@chromium.org> Date: Thu Aug 30 19:17:48 2018 Revert "Convert tcp_device_provider.cc to mojo host resolver" This reverts commit ac880b3ad00b2f206ff8a9fddaff004763370b03. Reason for revert: Causing crash after audit in incognito window: http://crbug.com/879060 Original change's description: > Convert tcp_device_provider.cc to mojo host resolver > > Bug: 874653 > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd > Reviewed-on: https://chromium-review.googlesource.com/1185626 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586738} TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874653 , 879060 Change-Id: I72e7268a8b208a2f91e53f84601d5e89a3c66a41 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1197109 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#587693} [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/chrome_devtools_session.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/cast_device_provider.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/cast_device_provider.h [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/cast_device_provider_unittest.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/port_forwarding_browsertest.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/tcp_device_provider.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/device/tcp_device_provider.h [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/protocol/target_handler.cc [modify] https://crrev.com/7d241becc763d91ffb9bd542ec35234401a05c10/chrome/browser/devtools/protocol/target_handler.h
,
Aug 30
,
Aug 30
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 7
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shruti.j...@etouch.net
, Aug 30Owner: cduvall@chromium.org
Status: Assigned (was: Unconfirmed)
1.7 MB
1.7 MB View Download