Issue metadata
Sign in to add a comment
|
1%-10% regression in v8.browsing_mobile at 585433:585458 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 30
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11d7402e640000
,
Aug 30
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11d7402e640000 [Android][Performance] Prevent accessory from over-openening keyboard by fhorschig@chromium.org https://chromium.googlesource.com/chromium/src/+/760cc2256b4d27f9a01c6102a3392f7840df7a4f 1.573e+07 → 1.706e+07 (+1.326e+06) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Aug 30
,
Sep 10
I cannot see an easy fix for this issue. This change is definitely needed: - it prevents that other performance tests fail (youtube pinch) - it ensures UI correctness in that it prevents the keyboard from popping up without good reason Actually, it seems quite weird that a single condition seems to be responsible for this regression - the check for |accessory.isShown| is the only added call here. This is a read-only access to an attribute. The condition body is still exactly the same method. ulan@, am I missing something?
,
Sep 10
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 30