New issue
Advanced search Search tips

Issue 879051 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Check failed: path.size() >= 2u (1 vs. 2)Use SetKey() for a path of length 1.

Project Member Reported by slangley@chromium.org, Aug 30

Issue description

Due to: https://chromium-review.googlesource.com/c/chromium/src/+/1184801

Repro: Enter chrome://drive-internals with DCHECKs on.

[60269:60269:0830/160206.607713:FATAL:values.cc(372)] Check failed: path.size() >= 2u (1 vs. 2)Use SetKey() for a path of length 1.
#0 0x7f592212032c base::debug::StackTrace::StackTrace()
#1 0x7f5922053f2b logging::LogMessage::~LogMessage()
#2 0x7f5922114c23 base::Value::SetPath()
#3 0x564d31c56137 chromeos::(anonymous namespace)::AppendKeyValue()
#4 0x564d31c539d8 chromeos::(anonymous namespace)::DriveInternalsWebUIHandler::OnPageLoaded()
#5 0x564d2fdcc7bf _ZN4base8internal7InvokerINS0_9BindStateIMN11google_apis13RequestSenderEFvPNS3_29AuthenticatedRequestInterfaceEEJNS_7WeakPtrIS4_EEEEEFvS6_EE3RunEPNS0_13BindStateBaseES6_
#6 0x7f591f6401d8 content::WebUIImpl::ProcessWebUIMessage()
#7 0x7f591f63f2d2 _ZN3IPC8MessageTI27FrameHostMsg_WebUISend_MetaNSt3__15tupleIJNS2_12basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEN4base9ListValueEEEEvE8DispatchIN7content9WebUIImplESG_NSF_15RenderFrameHostEMSG_FvPSH_RKS9_RKSB_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#8 0x7f591f63f20c content::WebUIImpl::OnMessageReceived()
#9 0x7f591f5f9304 content::WebContentsImpl::OnMessageReceived()
#10 0x7f591f29b694 content::RenderFrameHostImpl::OnMessageReceived()
#11 0x7f591f4a9f1b content::RenderProcessHostImpl::OnMessageReceived()
#12 0x7f592074c7d1 IPC::ChannelProxy::Context::OnDispatchMessage()
#13 0x7f592074f0bb _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE
#14 0x7f5922036ef5 base::debug::TaskAnnotator::RunTask()
#15 0x7f5922061ffe base::MessageLoop::RunTask()
#16 0x7f5922062423 base::MessageLoop::DoWork()
#17 0x7f5922140c09 base::MessagePumpLibevent::Run()
#18 0x7f5922061b94 base::MessageLoop::Run()
#19 0x7f5922094b49 base::RunLoop::Run()
#20 0x564d309483ed ChromeBrowserMainParts::MainMessageLoopRun()
#21 0x7f591f0fc397 content::BrowserMainLoop::RunMainMessageLoopParts()
#22 0x7f591f0ff096 content::BrowserMainRunnerImpl::Run()
#23 0x7f591f0f8539 content::BrowserMain()
#24 0x7f591fb7f43f content::ContentMainRunnerImpl::Run()
#25 0x7f59223dcf85 service_manager::Main()
#26 0x7f591fb7d8d4 content::ContentMain()
#27 0x564d2fd3fe93 ChromeMain
#28 0x7f59133d32b1 __libc_start_main
#29 0x564d2fd3fd0a _start

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c69a18d9bd3ba49ba14a8b28559f0a3c66408a5

commit 9c69a18d9bd3ba49ba14a8b28559f0a3c66408a5
Author: Sergei Datsenko <dats@chromium.org>
Date: Fri Aug 31 05:28:26 2018

Use SetKey instead of SetPath to make DCHECK happy

BUG= chromium:879051 

Change-Id: I3e9000b6bdf7e48683010ba5e039bd6b79219910
Reviewed-on: https://chromium-review.googlesource.com/1196285
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587949}
[modify] https://crrev.com/9c69a18d9bd3ba49ba14a8b28559f0a3c66408a5/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

Status: Fixed (was: Assigned)

Sign in to add a comment