Issue metadata
Sign in to add a comment
|
Enable ChromeVox LogPage filter to change from URL |
||||||||||||||||||||||||
Issue descriptionChromeVox LogPage type filter should be changed from URL. When log types are added more, it would be easier to see log if filters can be copy and paste by URL.
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e8dc0e5f7fbd16ed18ae659ba8c137bbd3823fb commit 0e8dc0e5f7fbd16ed18ae659ba8c137bbd3823fb Author: Eriko Kurimoto <elkurin@google.com> Date: Mon Sep 10 06:12:30 2018 Use URL parameters for storing filter types" Each types of log (speech, event ...) can be filtered from URL params. To enable users to change URL easily, LogPage is now on tab, not panel. Bug: 879042 Test: None Change-Id: I64b80f828707f60df23afab6f57c68135199c57c Reviewed-on: https://chromium-review.googlesource.com/1195407 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589831} [modify] https://crrev.com/0e8dc0e5f7fbd16ed18ae659ba8c137bbd3823fb/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js [modify] https://crrev.com/0e8dc0e5f7fbd16ed18ae659ba8c137bbd3823fb/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js
,
Sep 10
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/946da64c6b326adcfc12fbdb9c357db491d1e452 commit 946da64c6b326adcfc12fbdb9c357db491d1e452 Author: Eriko Kurimoto <elkurin@google.com> Date: Wed Sep 26 02:58:03 2018 Fix the bug on ChromVox Log Page fails to filter logs. LogStore.LogType is deprecated after this CL (dump ax tree). https://chromium-review.googlesource.com/c/chromium/src/+/1187853 Merge error occured in using URL parameters CL below. https://chromium-review.googlesource.com/c/chromium/src/+/1195407 Bug: 879042 Test: None Change-Id: I277466efeb4b45311206e9301e3b0016af18dbf7 Reviewed-on: https://chromium-review.googlesource.com/1242764 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#594200} [modify] https://crrev.com/946da64c6b326adcfc12fbdb9c357db491d1e452/chrome/browser/resources/chromeos/chromevox/cvox2/background/log.js [modify] https://crrev.com/946da64c6b326adcfc12fbdb9c357db491d1e452/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store.js |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by yawano@google.com
, Aug 30Components: UI>Accessibility
Labels: -Type-Bug OS-Chrome Type-Feature