New issue
Advanced search Search tips

Issue 879035 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 877895


Sign in to add a comment

Decouple Files app from {Gallery, video_player, etc.}

Project Member Reported by tapted@chromium.org, Aug 30 
Chrome Version       : 70.0.3528.4

Currently Gallery and other ChromeOS apps reach into files app internals in various ways, which is a problem for maintenance and independent feature development.

The should still share parts, but that sharing should be explicit rather than picking out specific .js files deep within the file_manager folder structure.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b7fbef124b89cf819a60be8dded94bec4ddb70e

commit 9b7fbef124b89cf819a60be8dded94bec4ddb70e
Author: Trent Apted <tapted@chromium.org>
Date: Thu Aug 30 10:12:24 2018

Move mouse_inactivity_watcher.js to video_player.

Nothing else uses it (it's only included from video_player_scripts.js).

Bug: 879035
Change-Id: I58e1b939201d466a65027ae48b73b9053afac59d
Reviewed-on: https://chromium-review.googlesource.com/1195179
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587505}
[modify] https://crrev.com/9b7fbef124b89cf819a60be8dded94bec4ddb70e/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/9b7fbef124b89cf819a60be8dded94bec4ddb70e/ui/file_manager/video_player/js/BUILD.gn
[rename] https://crrev.com/9b7fbef124b89cf819a60be8dded94bec4ddb70e/ui/file_manager/video_player/js/mouse_inactivity_watcher.js
[modify] https://crrev.com/9b7fbef124b89cf819a60be8dded94bec4ddb70e/ui/file_manager/video_player/js/video_player_scripts.js
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ea8c42e8c703fcf29852954518513e5dd34abb6

commit 5ea8c42e8c703fcf29852954518513e5dd34abb6
Author: Trent Apted <tapted@chromium.org>
Date: Tue Sep 11 03:31:09 2018

Document interdependencies under ui/file_manager/file_manager.

The ChromeOS Gallery, video_player, and audio_player currently pick out
a collection of .js files from various places inside the folder structure
of the ChromeOS files App.

This CL documents where that occurs, with a view to move these, shared
files out to a shared "toolkit" folder higher up in the folder structure.
There is already a "common" folder, but it is within the Files app
subtree and hard to enforce via layering.

It uses GN's "visibility" on the closure targets to detect whether new
dependencies are added.

Bug: 879035
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6b134ccad20c22ad46372871ab488200d3cbafa1
Reviewed-on: https://chromium-review.googlesource.com/1188735
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590186}
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/third_party/closure_compiler/README.chromium
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/third_party/closure_compiler/compile_js.gni
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/background/js/BUILD.gn
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/common/js/BUILD.gn
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/foreground/elements/BUILD.gn
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/test/BUILD.gn
[modify] https://crrev.com/5ea8c42e8c703fcf29852954518513e5dd34abb6/ui/file_manager/file_manager/test/js/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4

commit e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4
Author: Trent Apted <tapted@chromium.org>
Date: Fri Oct 12 06:29:22 2018

Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js

These functions are currently in file_manager/file_manager/common/js/unittest_util.js
which has a lot of files-app specific stuff that media apps shouldn't
depend on.

 - Move MockAPIEvent to the only unittest (in gallery) that uses it.
 - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js
 - Updates the remaining handcrafted foo_unittest.html files in the files app
   * combination sed-script and manual edit.

Bug: 879035
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1
Reviewed-on: https://chromium-review.googlesource.com/c/1275545
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599115}
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/base/js/BUILD.gn
[add] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/base/js/test_error_reporting.js
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/device_handler_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/file_operation_manager_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/import_history_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/media_scanner_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/task_queue_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/background/js/volume_manager_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/common/js/BUILD.gn
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/common/js/metrics_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/common/js/unittest_util.js
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/spinner_controller_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/gallery/js/BUILD.gn
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/gallery/js/entry_list_watcher_unittest.js
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/gallery/js/image_editor/BUILD.gn
[modify] https://crrev.com/e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4/ui/file_manager/image_loader/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fc0f5ddb59e2445813dec1a8e6887413bfdd508

commit 6fc0f5ddb59e2445813dec1a8e6887413bfdd508
Author: Trent Apted <tapted@chromium.org>
Date: Tue Oct 16 04:15:51 2018

FilesApp: Closure compile background/.../volume_manager_unittest

Related apps under ui/file_manager all use background_base.js, which
instantiates a VolumeManagerFactory. VolumeManagerFactory,
BackgroundBase, their tests, and things they depend on should all move
to //ui/file_manager/base/*.

Capturing deps by Closure-compiling makes things easier to move.
Start with volume_manager_unittest.js. Break its dependency on the
files app `unittest_util.js` (which shouldn't move) by splitting out
some test utility functions to ui/file_manager/base/js/mock_chrome.js.

Bug: 879035,  860355 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ieab83e90607da78cf06352ecce73c0f8d62a2838
Reviewed-on: https://chromium-review.googlesource.com/c/1278622
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599845}
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/BUILD.gn
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/base/js/BUILD.gn
[add] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/base/js/mock_chrome.js
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/BUILD.gn
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/device_handler_unittest.html
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
[delete] https://crrev.com/def776e75cfc3b34930e83402a7bb2c186bc4eb2/ui/file_manager/file_manager/background/js/volume_manager_unittest.html
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/volume_manager_unittest.js
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/common/js/BUILD.gn
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/common/js/unittest_util.js
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
[modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/572ba7554b737b97f9cab72086b83018ae7b5990

commit 572ba7554b737b97f9cab72086b83018ae7b5990
Author: Trent Apted <tapted@chromium.org>
Date: Wed Oct 17 00:03:30 2018

Support `testonly` for closure_compile targets in ui/file_manager.

`testonly` ensures that test-only utility files are not depended on by
release files. It also helps when navigating deps in GN's tools.

To cut down on boilerplate, introduce `js_unittest` that automatically
adds testonly = true to js_library and is a better description of these
targets.

Leave "test_support" libraries using js_library + testonly.

Bug: 879035
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5463718ef3f13ead4fd1efae150ff1f7830e43ad
Reviewed-on: https://chromium-review.googlesource.com/c/1275725
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600200}
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/third_party/closure_compiler/compile_js.gni
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/third_party/closure_compiler/js_unit_tests.gni
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/base/js/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/file_manager/background/js/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/file_manager/common/js/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/gallery/js/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/gallery/js/image_editor/BUILD.gn
[modify] https://crrev.com/572ba7554b737b97f9cab72086b83018ae7b5990/ui/file_manager/image_loader/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3

commit c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3
Author: Trent Apted <tapted@chromium.org>
Date: Mon Nov 05 01:22:09 2018

CrOS Files: Move volume_manager_common to file_manager/base/js/volume_manager_types

Also add a unit test to seed the base folder for testing.

Bug: 879035
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I031545c083f7dab84a1d0605cda16fc02f7367b6
Reviewed-on: https://chromium-review.googlesource.com/c/1306959
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605224}
[add] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/chrome/browser/chromeos/file_manager/file_manager_base_jstest.cc
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/chrome/test/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/audio_player/js/audio_player_scripts.js
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/base/js/BUILD.gn
[rename] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/base/js/volume_manager_types.js
[add] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/base/js/volume_manager_types_unittest.js
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/externs/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/background_common_scripts.js
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/device_handler_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/import_history_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/media_scanner_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/background/js/task_queue_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/common/js/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/file_manager/test/scripts/create_test_main.py
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/gallery/js/BUILD.gn
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/gallery/js/gallery_scripts.js
[modify] https://crrev.com/c1ee9186c2e78ecaede0e452ec3d1a5616d6d1f3/ui/file_manager/video_player/js/video_player_scripts.js
►

Sign in to add a comment