New issue
Advanced search Search tips

Issue 879034 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Compile failure: media_perception_api_delegate_chromeos.cc

Project Member Reported by mgiuca@chromium.org, Aug 30

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7560

[25545/25994] LINK ./chrome
FAILED: chrome 
python "../../build/toolchain/gcc_link_wrapper.py" --output="./chrome" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -pie -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -m64 -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./chrome" -Wl,--start-group @"./chrome.rsp" ./libembedder.so ./libbase.so ./libbindings.so ./libbindings_base.so ./libmojo_public_system_cpp.so ./libmojo_public_system.so ./libmojo_cpp_platform.so ./libmessage_support.so ./libmojo_mojom_bindings.so ./libmojo_mojom_bindings_shared.so ./liburl.so ./libui_base.so ./libui_data_pack.so ./libskia.so ./libgfx.so ./libcolor_space.so ./libgeometry_skia.so ./libgfx_switches.so ./libgeometry.so ./libicui18n.so ./libicuuc.so ./libanimation.so ./libcodec.so ./librange.so ./libcc_paint.so ./libcc_base.so ./libcc_debug.so ./libevents_base.so ./libplatform.so ./libmojo_base_mojom_shared.so ./libmojo_base_mojom.so ./libmojo_base_lib.so ./libmojo_base_shared_typemap_traits.so ./libbase_i18n.so ./libnet.so ./libprotobuf_lite.so ./libcrcrypto.so ./libboringssl.so ./libipc.so ./libipc_mojom.so ./libipc_mojom_shared.so ./libcontent_public_common_mojo_bindings_shared.so ./libblink_mojo_bindings_shared.so ./libblink_android_mojo_bindings_shared.so ./libservice_manager_mojom_shared.so ./libservice_manager_mojom_constants_shared.so ./libmojom_platform_shared.so ./libandroid_mojo_bindings_shared.so ./libusb_shared.so ./libcontent.so ./libcc.so ./libviz_common.so ./libviz_resource_format_utils.so ./libgpu.so ./libcrash_key.so ./libgfx_ipc.so ./libgfx_ipc_geometry.so ./liburl_ipc.so ./libmedia.so ./libshared_memory_support.so ./libleveldatabase.so ./libgfx_ipc_skia.so ./libservice_manager_mojom.so ./libservice_manager_mojom_constants.so ./libservice_manager_cpp_types.so ./libmetrics_cpp.so ./libdisplay.so ./libdisplay_types.so ./libevents.so ./libservice_manager_cpp.so ./libgfx_ipc_color.so ./libui_base_ime.so ./libblink_common.so ./libmojom_core_shared.so ./libnetwork_cpp_base.so ./libnetwork_cpp.so ./libcontent_common_mojo_bindings_shared.so ./libcapture_base.so ./libmedia_gpu.so ./libaccessibility.so ./libaura.so ./libcompositor.so ./libsurface.so ./libnetwork_service.so ./libsandbox.so ./libembedder_switches.so ./libresource_coordinator_cpp.so ./libresource_coordinator_cpp_base.so ./libresource_coordinator_public_mojom.so ./libresource_coordinator_public_mojom_shared.so ./libmojo_core_embedder.so ./libstorage_common.so ./libtracing_cpp.so ./libtracing_mojom.so ./libtracing_mojom_shared.so ./libperfetto.so ./libpublic.so ./libinterfaces_shared.so ./libmedia_session_public_mojom.so ./libmedia_session_public_mojom_shared.so ./libstorage_browser.so ./libchrome_features.so ./libprefs.so ./libkeyed_service_core.so ./libos_crypt.so ./libwebdata_common.so ./libsql.so ./libchromeos.so ./libdbus.so ./libcloud_policy_proto_generated_compile.so ./libpolicy_component.so ./libpolicy_proto.so ./libcommon.so ./libnetwork_session_configurator.so ./libchromium_sqlite3.so ./libnative_theme.so ./libgl_wrapper.so ./libui_message_center_cpp.so ./libppapi_shared.so ./liburl_matcher.so ./libbluetooth.so ./libdevice_event_log.so ./libdevice_base.so ./libkeyboard.so ./libprinting.so ./libsandbox_services.so ./libkeyed_service_content.so ./libsessions.so ./libshell_dialogs.so ./libonc.so ./libuser_manager.so ./libhost.so ./libuser_prefs.so ./libffmpeg.so ./libviews.so ./libgcm.so ./libdomain_reliability.so ./libui_touch_selection.so ./libproxy_config.so ./libmanager.so ./libmessage_center.so ./libash.so ./libash_public_cpp.so ./libash_public_interfaces_internal_shared.so ./libozone.so ./libozone_base.so ./libdisplay_util.so ./libgfx_ipc_buffer_types.so ./libdevices.so ./libui_views_mus_lib.so ./libwm.so ./libwm_public.so ./lib.so ./libservice.so ./libdevice_gamepad.so ./libevents_ozone_evdev.so ./libcore.so ./libchrome_apps.so ./libppapi_host.so ./libui_chromeos.so ./libui_base_x.so ./libkeycodes_x11.so ./libfile_manager.so ./libfontconfig.so ./libwebview.so ./libstartup_tracing.so ./libui_devtools.so ./libgesture_detection.so ./libsnapshot.so ./libweb_dialogs.so ./libsuid_sandbox_client.so ./libseccomp_bpf.so ./libdevice_features.so ./libash_with_content.so ./libevents_ozone_layout.so ./libdrivefs.so ./libdrivefs_mojom.so ./libdrivefs_mojom_shared.so ./libcaptive_portal.so ./liblogin.so ./libownership.so ./libgpu_ipc_service.so ./libgl_init.so ./libppapi_proxy.so ./libgles2.so ./libgles2_implementation.so ./libraster.so ./libwebgpu.so ./libbrowser_ui_views.so ./libapp_list.so ./libapp_list_model.so ./libsearch_model.so ./libzygote.so ./liblive_tab_count_metrics.so ./libcapture_lib.so ./libmirroring_service.so ./libfido.so ./libmidi.so ./libmedia_mojo_services.so ./libsimple_browser.so ./libgin.so ./libv8.so ./libblink_controller.so ./libblink_core.so ./libblink_core_mojo_bindings_shared.so ./libmojo_base_mojom_blink.so ./libwtf.so ./libblink_platform.so ./libcc_animation.so ./libresource_coordinator_public_mojom_blink.so ./libservice_manager_mojom_blink.so ./libservice_manager_mojom_constants_blink.so ./libblink_modules.so ./libnet_with_v8.so ./libcatalog_lib.so ./libdiscardable_memory_client.so ./libfreetype_harfbuzz.so ./libv8_libplatform.so ./libheadless.so ./libc++.so -Wl,--end-group   -ldl -lpthread -lrt -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -ldbus-1 -lexpat -lm -ldrm -lffi 
obj/chrome/browser/extensions/libextensions.a(obj/chrome/browser/extensions/extensions/media_perception_api_delegate_chromeos.o):media_perception_api_delegate_chromeos.cc:function content::DelegateToBrowserGpuServiceAcceleratorFactory::DelegateToBrowserGpuServiceAcceleratorFactory(): error: undefined reference to 'vtable for content::DelegateToBrowserGpuServiceAcceleratorFactory'
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Obvious culprit is a CL that introduced this function:
https://chromium-review.googlesource.com/c/chromium/src/+/1195657
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b2fa061e52c22b7d84be4244b34d90feb905224

commit 8b2fa061e52c22b7d84be4244b34d90feb905224
Author: Matt Giuca <mgiuca@chromium.org>
Date: Thu Aug 30 04:17:00 2018

Revert "[Video Capture Service] Inject GPU dependencies when starting service via extension"

This reverts commit 3304d8fe7851816cabea29cad6af3dde741afc21.

Reason for revert: Compile failure (see  crbug.com/879034 ).

Original change's description:
> [Video Capture Service] Inject GPU dependencies when starting service via extension
> 
> The video capture service requires GPU dependencies to be injected after startup
> in order to enable accelerated MJPEG decoding. This CL adds this injection call
> where the service is started from the media_perception_private extension.
> 
> The injected dependencies use classes that used to live in
> content/browser/renderer_host/media. To be able to reuse them for the
> extension, this CL moves them to a location that is accessible to both
> usage sites, i.e. to content/browser/gpu with a public interface in
> content/public/browser.
> 
> Bug:  877690 
> Change-Id: If43ff7ff3f24a0aa17d441af5f5f605a894f374e
> Reviewed-on: https://chromium-review.googlesource.com/1195657
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587377}

TBR=jam@chromium.org,chfremer@chromium.org,lasoren@chromium.org

Change-Id: If23d44ff678a7b4a1b42ce5aa176f7f314c033e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  877690 ,  879034 
Reviewed-on: https://chromium-review.googlesource.com/1195304
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587437}
[modify] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/chrome/browser/extensions/api/media_perception_private/media_perception_api_delegate_chromeos.cc
[modify] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/browser/BUILD.gn
[delete] https://crrev.com/9d82fb5952beddd0786ea66506ef95cb641fa260/content/browser/gpu/delegate_to_browser_gpu_service_accelerator_factory.cc
[modify] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/browser/renderer_host/media/service_video_capture_provider.cc
[rename] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/browser/renderer_host/media/video_capture_dependencies.cc
[rename] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/browser/renderer_host/media/video_capture_dependencies.h
[modify] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/public/browser/BUILD.gn
[modify] https://crrev.com/8b2fa061e52c22b7d84be4244b34d90feb905224/content/public/browser/DEPS
[delete] https://crrev.com/9d82fb5952beddd0786ea66506ef95cb641fa260/content/public/browser/delegate_to_browser_gpu_service_accelerator_factory.h

Status: Fixed (was: Assigned)
Thanks for the revert.
Reland with fix was successful.

Sign in to add a comment