Issue metadata
Sign in to add a comment
|
ARIA comboboxes with aria-owns sometimes no longer get focus events on menu items |
||||||||||||||||||||||||
Issue descriptionSteps: 1. Load drive.google.com with NVDA 2. Navigate to and activate New button 3. Arrow through menu Menu items are not read, and no focus events are fired. This regressed from https://chromium-review.googlesource.com/c/chromium/src/+/1175491
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a3135cf42d908445fd9f1a291058b8100a020f8 commit 7a3135cf42d908445fd9f1a291058b8100a020f8 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Fri Aug 31 00:16:12 2018 Adding aria-haspopup later must affect CanHaveChildren Invalidate the object when aria-haspopup changes. Explanation: The cached native_role_ value, which is computed from NativeAccessibilityRoleIgnoringAria(), must not return a different result depending on whether aria-haspopup changes before/after the caching. This affects CanHaveChildren() for a button that changes its aria-haspopup value. This in turn affects many other things for the button, such such as aria-activedescendant computation. Bug: 879032 Change-Id: I2b929623f7dfbc0ba926088add4d747af1f77ef7 Reviewed-on: https://chromium-review.googlesource.com/1196864 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#587870} [modify] https://crrev.com/7a3135cf42d908445fd9f1a291058b8100a020f8/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html [modify] https://crrev.com/7a3135cf42d908445fd9f1a291058b8100a020f8/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc [modify] https://crrev.com/7a3135cf42d908445fd9f1a291058b8100a020f8/third_party/blink/renderer/modules/accessibility/ax_node_object.cc [modify] https://crrev.com/7a3135cf42d908445fd9f1a291058b8100a020f8/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
,
Aug 31
Justification for merge: this fixes a regression with a crucial piece of UI in Google Drive, and probably other sites using material design. The regression was from a necessary crash fix for issue 852251 and issue 852735 .
,
Aug 31
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 31
Pls apply appropriate OSs label. Note: For Desktop, we already cut M69 Stable RC.
,
Aug 31
,
Aug 31
,
Sep 1
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4
,
Sep 4
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af19d3f85348344ea6b57b10e9edb8d8e1be8818 commit af19d3f85348344ea6b57b10e9edb8d8e1be8818 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Sep 04 14:00:15 2018 Adding aria-haspopup later must affect CanHaveChildren Invalidate the object when aria-haspopup changes. Explanation: The cached native_role_ value, which is computed from NativeAccessibilityRoleIgnoringAria(), must not return a different result depending on whether aria-haspopup changes before/after the caching. This affects CanHaveChildren() for a button that changes its aria-haspopup value. This in turn affects many other things for the button, such such as aria-activedescendant computation. Bug: 879032 Change-Id: I2b929623f7dfbc0ba926088add4d747af1f77ef7 Reviewed-on: https://chromium-review.googlesource.com/1196864 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587870}(cherry picked from commit 7a3135cf42d908445fd9f1a291058b8100a020f8) Reviewed-on: https://chromium-review.googlesource.com/1203437 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#23} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_node_object.cc [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af19d3f85348344ea6b57b10e9edb8d8e1be8818 commit af19d3f85348344ea6b57b10e9edb8d8e1be8818 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Sep 04 14:00:15 2018 Adding aria-haspopup later must affect CanHaveChildren Invalidate the object when aria-haspopup changes. Explanation: The cached native_role_ value, which is computed from NativeAccessibilityRoleIgnoringAria(), must not return a different result depending on whether aria-haspopup changes before/after the caching. This affects CanHaveChildren() for a button that changes its aria-haspopup value. This in turn affects many other things for the button, such such as aria-activedescendant computation. Bug: 879032 Change-Id: I2b929623f7dfbc0ba926088add4d747af1f77ef7 Reviewed-on: https://chromium-review.googlesource.com/1196864 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587870}(cherry picked from commit 7a3135cf42d908445fd9f1a291058b8100a020f8) Reviewed-on: https://chromium-review.googlesource.com/1203437 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#23} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_node_object.cc [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af19d3f85348344ea6b57b10e9edb8d8e1be8818 commit af19d3f85348344ea6b57b10e9edb8d8e1be8818 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Sep 04 14:00:15 2018 Adding aria-haspopup later must affect CanHaveChildren Invalidate the object when aria-haspopup changes. Explanation: The cached native_role_ value, which is computed from NativeAccessibilityRoleIgnoringAria(), must not return a different result depending on whether aria-haspopup changes before/after the caching. This affects CanHaveChildren() for a button that changes its aria-haspopup value. This in turn affects many other things for the button, such such as aria-activedescendant computation. Bug: 879032 Change-Id: I2b929623f7dfbc0ba926088add4d747af1f77ef7 Reviewed-on: https://chromium-review.googlesource.com/1196864 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587870}(cherry picked from commit 7a3135cf42d908445fd9f1a291058b8100a020f8) Reviewed-on: https://chromium-review.googlesource.com/1203437 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#23} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_node_object.cc [modify] https://crrev.com/af19d3f85348344ea6b57b10e9edb8d8e1be8818/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by aleventhal@chromium.org
, Aug 30