WPT import https://crrev.com/c/1195934 introduced new failures in external/wpt/webrtc: List of new failures: external/wpt/webrtc/no-media-call.html [ Timeout ] virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/no-media-call.html [ Timeout ] This import contains upstream changes from 867c430c710de3832ade393e01d44356d4b10cd8 to a089efa97c10aec26290f7ce7e73deec0d93c42c: Merge pull request #12715 from youennf/wpt-export-for-webkit-189040: https://github.com/web-platform-tests/wpt/commit/a089efa97c10aec26290f7ce7e73deec0d93c42c Merge pull request #12743 from emilio/webkit-bug-189089: https://github.com/web-platform-tests/wpt/commit/107477834f073e5a7c5b9e8483e23b645cd6675c Fix one paint containment wpt (incorrect expectations): https://github.com/web-platform-tests/wpt/commit/99c4f1dd3b4253418e9c108a0b63e824cb00be18 [wdspec] Add test for empty text to send_alert_text/send.py.: https://github.com/web-platform-tests/wpt/commit/17627a7b7723f84448c87c1c19b20d71bccf16fa Enable FP reporting for unsized-media policy violations.: https://github.com/web-platform-tests/wpt/commit/96e846ffd4fdeaab48977003426c50da328119b3 Add pointerrawmove implementation: https://github.com/web-platform-tests/wpt/commit/cf6f1d44c735fedd87e94f1e72fcc747d4d74b9f Enable FP reporting for payment violations.: https://github.com/web-platform-tests/wpt/commit/9bda9c68b6412bfa59862cedecd2280253d9ced1 Add one more WPT test to cavas TextMetrics for advances.: https://github.com/web-platform-tests/wpt/commit/2e742eb0aac9b916de4d4f9872ec04d8917248f1 Add a test for WebKit bug 189089 .: https://github.com/web-platform-tests/wpt/commit/1f403953c4d250bcefefa067d3274696567b760c Fix fullscreen WPT tests assuming fullscreenElement changes each time.: https://github.com/web-platform-tests/wpt/commit/9be7cfef2e90378b3db6d6e75b80ba6f929786c5 [layoutng] Add a flag for content size vs border box size to ComputeMinMaxSize: https://github.com/web-platform-tests/wpt/commit/eca7f8cc2ae10c36eb8c4356eb594b214dcd4ea0 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=189040: https://github.com/web-platform-tests/wpt/commit/99f589185172fb846fc3b240acf23b0226f6c6f4 [affecting this directory] Sync fullscreen Element Ready steps with spec.: https://github.com/web-platform-tests/wpt/commit/f42b3ccaccf257adec3c5ddf5308ff230c68abfa Add intrinsicsize attribute to HTMLImageElement behind a flag: https://github.com/web-platform-tests/wpt/commit/b42438a5382241da291b3284527db833e82590d1 Enable FP reporting for camera and microphone violations.: https://github.com/web-platform-tests/wpt/commit/fb8c0bf1a5d299f48b3dcce52c60ed0cd605fa47 Avoid scrolling when entering fullscreen: https://github.com/web-platform-tests/wpt/commit/d82155b15751d138df88e35b1a40b6317e1b73a4 Enable FP reporting for fullscreen violations.: https://github.com/web-platform-tests/wpt/commit/01d6bfdd049082b2287007107a67f5fd012ac83b [serve] Log state of subprocesses during shutdown: https://github.com/web-platform-tests/wpt/commit/91e3f8d02477314172a3c3f0e681d250900d7a9b [serve] Quit on sub-process failure: https://github.com/web-platform-tests/wpt/commit/1f17212bcf60503f494af8707787a09541750cc9
no-media-call.html looks broken. It does not establish an ice connection since it uses neither media nor data channels. https://github.com/web-platform-tests/wpt/commit/99f589185172fb846fc3b240acf23b0226f6c6f4#diff-fc95e36af7db6b1e2d851d2cd637b3dbR128 shows this passes the legacy constraints (which safari doesn't support) as third argument to the .then
tenative fix in https://github.com/web-platform-tests/wpt/pull/12786
Upstream fix in https://github.com/web-platform-tests/wpt/pull/12786 looks right. Merged. Waiting for next import run.
Then what's left to do here is to re-enable the tests? https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/TestExpectations?type=cs&q=external/wpt/webrtc/no-media-call.html&sq=package:chromium&g=0&l=2725
let me take it, i've cleaned up WPT already
Thanks! :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dc587b11968a453985ba73e969845c40e85bf9a commit 1dc587b11968a453985ba73e969845c40e85bf9a Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Tue Sep 04 05:31:21 2018 webrtc wpt: no-media-call was fixed downstream BUG= 879021 Change-Id: Ie500c1e60fd30f637e28dc1616cca10a1ee93d1f Reviewed-on: https://chromium-review.googlesource.com/1203210 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#588455} [modify] https://crrev.com/1dc587b11968a453985ba73e969845c40e85bf9a/third_party/WebKit/LayoutTests/TestExpectations
Comment 1 by guidou@chromium.org
, Aug 31Labels: Pri-3 Type-Bug
Owner: hbos@chromium.org
Status: Assigned (was: Untriaged)