New issue
Advanced search Search tips

Issue 879019 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Task

Blocked on:
issue 922376

Blocking:
issue 789857


Participants' hotlists:
ServiceWorkerOnionSoup


Sign in to add a comment

Remove WebXXX types in blink/public/platform/modules/service_worker/

Project Member Reported by leon....@intel.com, Aug 30

Issue description

As a goal of Onion Soup, we'll remove all WebXXX types defined in blink/public/platform/modules/service_worker/:

 - For WebXXX struct/enum types, use mojom types defined in blink/public/mojom/ to cross the boundary between Content layer and Blink instead.

 - For WebXXX classes acting as the abstract interface layer between Content and Blink, remove them by moving those Mojo interface endpoints from //content/renderer/ into Blink.

 
Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82ab9ed6f601d1c2e3024c8ab31c7d20aa5df4c5

commit 82ab9ed6f601d1c2e3024c8ab31c7d20aa5df4c5
Author: Han Leon <leon.han@intel.com>
Date: Fri Aug 31 00:55:46 2018

[OnionSoup] Remove an unused function using WebServiceWorkerResponse

Removing an unused function:
Response* Response::Create(
    ScriptState* script_state,
    const WebServiceWorkerResponse& web_response);

BUG=879019

Change-Id: I23878fd116cfee6acf6442f854f75b825d08cba4
Reviewed-on: https://chromium-review.googlesource.com/1195732
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#587881}
[modify] https://crrev.com/82ab9ed6f601d1c2e3024c8ab31c7d20aa5df4c5/third_party/blink/renderer/core/fetch/response.cc
[modify] https://crrev.com/82ab9ed6f601d1c2e3024c8ab31c7d20aa5df4c5/third_party/blink/renderer/core/fetch/response.h
[modify] https://crrev.com/82ab9ed6f601d1c2e3024c8ab31c7d20aa5df4c5/third_party/blink/renderer/core/fetch/response_test.cc
[modify] https://crrev.com/82ab9ed6f601d1c2e3024c8ab31c7d20aa5df4c5/third_party/blink/renderer/modules/cache_storage/cache_test.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a150f13b6358860cdd8b245576363de39413d743

commit a150f13b6358860cdd8b245576363de39413d743
Author: Han Leon <leon.han@intel.com>
Date: Fri Sep 14 07:05:58 2018

[OnionSoup] Remove WebServiceWorkerClientsClaimCallbacks

After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
now we send ClaimClients Mojo message from within Blink, no longer need
this WebServiceWorkerClientsClaimCallbacks to cross boundary of Content
and Blink.

BUG=879019

Change-Id: I755958f10b9cc3d049f89dec59eb2491bef31c1e
Reviewed-on: https://chromium-review.googlesource.com/1220328
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591297}
[modify] https://crrev.com/a150f13b6358860cdd8b245576363de39413d743/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/2108887b5165ebbc75681ed80fa450c9a0e6321a/third_party/blink/public/platform/modules/service_worker/web_service_worker_clients_claim_callbacks.h
[modify] https://crrev.com/a150f13b6358860cdd8b245576363de39413d743/third_party/blink/renderer/modules/service_worker/service_worker_clients.cc
[modify] https://crrev.com/a150f13b6358860cdd8b245576363de39413d743/third_party/blink/renderer/modules/service_worker/service_worker_error.cc
[modify] https://crrev.com/a150f13b6358860cdd8b245576363de39413d743/third_party/blink/renderer/modules/service_worker/service_worker_error.h
[modify] https://crrev.com/a150f13b6358860cdd8b245576363de39413d743/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/a150f13b6358860cdd8b245576363de39413d743/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b28104de047fc4a1b0c258b78d0ddfce90e8c79

commit 5b28104de047fc4a1b0c258b78d0ddfce90e8c79
Author: Han Leon <leon.han@intel.com>
Date: Wed Sep 19 08:30:59 2018

[OnionSoup] Remove WebServiceWorkerSkipWaitingCallbacks

After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
now we send SkipWaiting Mojo message from within Blink, no longer need
this WebServiceWorkerSkipWaitingCallbacks to cross boundary of Content
and Blink.

BUG=879019

Change-Id: I0c945c3f75713163fce65b6ebed67e117e0f1b34
Reviewed-on: https://chromium-review.googlesource.com/1226810
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#592347}
[modify] https://crrev.com/5b28104de047fc4a1b0c258b78d0ddfce90e8c79/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/460a14b66fb6644205e167d5c5f38b7db6aff3bd/third_party/blink/public/platform/modules/service_worker/web_service_worker_skip_waiting_callbacks.h
[modify] https://crrev.com/5b28104de047fc4a1b0c258b78d0ddfce90e8c79/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/5b28104de047fc4a1b0c258b78d0ddfce90e8c79/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/5b28104de047fc4a1b0c258b78d0ddfce90e8c79/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20404d2b8adb930d947192ff6244401a67cf7b5d

commit 20404d2b8adb930d947192ff6244401a67cf7b5d
Author: Han Leon <leon.han@intel.com>
Date: Wed Sep 19 08:41:41 2018

[OnionSoup] Remove WebServiceWorkerClientsCallbacks

After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
now we send GetClients Mojo message from within Blink, no longer need
this WebServiceWorkerClientsCallbacks to cross boundary of Content
and Blink.

BUG=879019

Change-Id: Ib9025f188708d0d2bb8088c4ead21a7aebe3b65c
Reviewed-on: https://chromium-review.googlesource.com/1226813
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592348}
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/public/platform/modules/service_worker/web_service_worker_clients_info.h
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/renderer/modules/service_worker/service_worker_client.cc
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/renderer/modules/service_worker/service_worker_client.h
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/renderer/modules/service_worker/service_worker_clients.cc
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/renderer/modules/service_worker/service_worker_window_client.cc
[modify] https://crrev.com/20404d2b8adb930d947192ff6244401a67cf7b5d/third_party/blink/renderer/modules/service_worker/service_worker_window_client.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb11bdef07a5756f7a3d5fbfc6449d365f31f2d5

commit bb11bdef07a5756f7a3d5fbfc6449d365f31f2d5
Author: Han Leon <leon.han@intel.com>
Date: Wed Sep 19 10:24:08 2018

[OnionSoup] Remove WebServiceWorkerClientCallbacks - part 1

After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
now we send GetClient Mojo message from within Blink, no longer need
the GetCallback (one subclass of WebServiceWorkerClientCallbacks) to
help cross the boundary of Content and Blink.

The follow-up CL (part 2) will remove blink::NavigateClientCallback
(another subclass of WebServiceWorkerClientCallbacks), then remove
WebServiceWorkerClientCallbacks completely.

BUG=879019

Change-Id: Ib2c469fc7f7476bd734e14c42850bb16266e37b6
Reviewed-on: https://chromium-review.googlesource.com/1227618
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592361}
[modify] https://crrev.com/bb11bdef07a5756f7a3d5fbfc6449d365f31f2d5/third_party/blink/renderer/modules/service_worker/service_worker_client.cc
[modify] https://crrev.com/bb11bdef07a5756f7a3d5fbfc6449d365f31f2d5/third_party/blink/renderer/modules/service_worker/service_worker_client.h
[modify] https://crrev.com/bb11bdef07a5756f7a3d5fbfc6449d365f31f2d5/third_party/blink/renderer/modules/service_worker/service_worker_clients.cc
[modify] https://crrev.com/bb11bdef07a5756f7a3d5fbfc6449d365f31f2d5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/bb11bdef07a5756f7a3d5fbfc6449d365f31f2d5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea

commit 43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea
Author: Han Leon <leon.han@intel.com>
Date: Fri Sep 21 02:26:52 2018

[OnionSoup] Remove WebServiceWorkerClientCallbacks - part 2

After https://chromium-review.googlesource.com/c/chromium/src/+/1214709,
now we send {FocusClient, NavigateClient, OpenPaymentHandlerWindow,
OpenWindowForClients} Mojo messages from within Blink, no longer need
blink::NavigateClientCallback (subclass of
WebServiceWorkerClientCallbacks) to help cross the boundary of Content
and Blink.

This CL removes blink::NavigateClientCallback then removes
the parent class WebServiceWorkerClientCallbacks completely.

BUG=879019

Change-Id: I0643b7439d1a07ca2a3296f3327440d306cf0c2f
Reviewed-on: https://chromium-review.googlesource.com/1227619
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#593054}
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/public/platform/modules/service_worker/web_service_worker_clients_info.h
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/payments/can_make_payment_event.cc
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/payments/payment_request_event.cc
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/service_worker/BUILD.gn
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/service_worker/service_worker_clients.cc
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/service_worker/service_worker_window_client.cc
[modify] https://crrev.com/43b9c27d43ba6b3bc994cd7f7f8dad6ac56054ea/third_party/blink/renderer/modules/service_worker/service_worker_window_client.h
[delete] https://crrev.com/d522751137c1e4d5a319d29c00af1e74b1e92afa/third_party/blink/renderer/modules/service_worker/service_worker_window_client_callback.cc
[delete] https://crrev.com/d522751137c1e4d5a319d29c00af1e74b1e92afa/third_party/blink/renderer/modules/service_worker/service_worker_window_client_callback.h

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27ea6d66efa8d360b86092d746f804ee81b7c8f

commit c27ea6d66efa8d360b86092d746f804ee81b7c8f
Author: Leon Han <leon.han@intel.com>
Date: Wed Oct 10 06:23:53 2018

[ServiceWorker] Make blink::ServiceWorker itself hold Mojo connections.

After Mojofication work, blink::ServiceWorker no longer needs to rely on
content::WebServiceWorkerImpl to handle IPCs, now it can hold/access
blink.mojom.ServiceWorkerObject(Host) Mojo connections on its own.

This CL:
  - Removes the public interfaces blink::WebServiceWorker(Proxy),
    instead, creates a new struct blink::WebServiceWorkerObjectInfo to
    help carry blink.mojom.ServiceWorkerObjectInfo from Content into
    Blink, which is then put into blink::ServiceWorker, so that
    blink::ServiceWorker can get the information of
    blink.mojom.ServiceWorkerObject(Host) Mojo connections and use them
    on its own there.
  - Moves the (version_id, ServiceWorker object) mapping from Content
    into Blink:
     - for a Document,
       content::SWProviderContext --> blink::SWContainerClient.
     - for a ServiceWorkerGlobalScope,
       content::SWContextClient --> blink::SWGlobalScope.
  - Removes content::WebServiceWorkerImpl completely as it becomes
    useless now.

Next step we can handle blink::SWRegistration in much the same way.

BUG=789857,879019

Change-Id: I7214e96f913cae36785fc1aac1ad53fd6f1b2a79
Reviewed-on: https://chromium-review.googlesource.com/c/1249307
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598223}
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/BUILD.gn
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_state_for_client.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_type_converters.h
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/content/renderer/service_worker/web_service_worker_impl.cc
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/content/renderer/service_worker/web_service_worker_impl.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/web_service_worker_registration_impl.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/web_service_worker_registration_impl.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/BUILD.gn
[add] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/DEPS
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/third_party/blink/public/platform/modules/service_worker/web_service_worker.h
[add] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/web_service_worker_object_info.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider_client.h
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/third_party/blink/public/platform/modules/service_worker/web_service_worker_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_registration.h

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6856b267639d14077ac2aac923503f586f3c955

commit a6856b267639d14077ac2aac923503f586f3c955
Author: Leon Han <leon.han@intel.com>
Date: Fri Oct 12 04:17:47 2018

[OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration

Currently some modules (push_messaging, background_fetch etc.) are
calling blink::SWRegistration::WebRegistration() to get a pointer to
blink::WebSWRegistration to continue their work there.
However, they use that blink::WebSWRegistration just to retrieve the
service worker registration id, i.e. what they really want is not
blink::WebSWRegistration, but just the registration id.

So, this CL removes blink::SWRegistration::WebRegistration() and
provides a new function blink::SWRegistration::RegistrationId() for
those users instead.

This CL is in preparation for https://crrev.com/c/1275300 which plans to
merge content::WebSWRegistrationImpl into blink::SWRegistration and
remove the public interface blink::WebSWRegistration completely.

BUG=789857,879019

Change-Id: Iafb245ec6f978dfaa294f58ee800d80c5ba60fac
Reviewed-on: https://chromium-review.googlesource.com/c/1275298
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599093}
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_provider.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_provider.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/public/platform/modules/push_messaging/web_push_client.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/public/platform/modules/push_messaging/web_push_provider.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/background_sync/sync_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/notifications/notification_manager.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/push_messaging/push_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/push_messaging/push_subscription.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/service_worker/service_worker_registration.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d2349e924e311f441c8805ff5b32b8d7ea75c6f

commit 3d2349e924e311f441c8805ff5b32b8d7ea75c6f
Author: Leon Han <leon.han@intel.com>
Date: Wed Oct 17 04:37:09 2018

[OnionSoup] Make blink::SWRegistration itself hold Mojo connections.

After Mojofication work, blink::SWRegistration no longer needs to rely
on content::WebSWRegistrationImpl to handle IPCs, now it can hold/access
blink.mojom.SWRegistrationObject(Host) Mojo connections on its own.

This CL:
  - Removes the public interfaces blink::WebSWRegistration(Proxy),
    instead, creates a new struct blink::WebSWRegistrationObjectInfo to
    help carry blink.mojom.SWRegistrationObjectInfo from //content into
    Blink, which is then put into blink::SWRegistration, so that
    blink::SWRegistration can get the information of
    blink.mojom.SWRegistrationObject(Host) Mojo connections and use them
    on its own there.
  - Moves the (registration_id, SWRegistration object) mapping from
    //content into Blink:
    - for a Document,
      content::SWProviderStateForClient --> blink::SWContainerClient.
    - for a SWGlobalScope,
      only one SWRegistration object , still in blink::SWGlobalScope.
  - Removes content::WebSWRegistrationImpl completely as it becomes
    useless now.
  - Removes the intermediate blink::WebNavigationPreloadState struct as
    Blink starts to manipulate the Mojo connection directly and no
    longer needs it to help carry data across the boundary of //content
    and Blink.

BUG=789857,879019

Change-Id: Ie47ac2b4b603a9c8e200676febc92d35826ddba2
Reviewed-on: https://chromium-review.googlesource.com/c/1275300
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600277}
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/BUILD.gn
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_state_for_client.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/web_service_worker_provider_impl.cc
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/content/renderer/service_worker/web_service_worker_registration_impl.cc
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/content/renderer/service_worker/web_service_worker_registration_impl.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/public/platform/modules/service_worker/web_navigation_preload_state.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/platform/modules/service_worker/web_service_worker_object_info.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider.h
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration.h
[add] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration_object_info.h
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration_proxy.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/BUILD.gn
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/renderer/modules/service_worker/navigation_preload_callbacks.cc
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/renderer/modules/service_worker/navigation_preload_callbacks.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_container.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_registration.h

Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
(status update)
I guess removing Web types for service worker context has mostly finished.
WebServiceWorkerRequest, WebServiceWorkerResponse, and WebServiceWorkerStreamHandle can be eliminated after moving ServiceWorkerContextClient.

Leon: is my understanding correct?
Blockedon: 922376
Yes, and WebServiceWorkerClientInfo could also be removed when moving blink.mojom.ServiceWorker impl into Blink.

Sign in to add a comment