New issue
Advanced search Search tips

Issue 879014 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Nov 13
Cc:
corising@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX
Team-Accessibility



Sign in to add a comment

ContentSettingImageView has the wrong accessibility role (AXStaticText, not AXButton)

Project Member Reported by tapted@chromium.org, Aug 30 
Chrome Version       : 70.0.3530.0
OS Version: OS X 10.13.5

Maybe not mac-specific..

What steps will reproduce the problem?
1. https://permission.site/ -> hit 'Microphone'
2. Open an Accessibility Inspector and inspect the camera icon next to the bookmark star

What is the expected result?

It should be similar to the bookmark star (AXButton)


What happens instead of that?

Comes up as AXStaticText, has no "perform" action (i.e. no way to "Click" the button via a11y tools)


Not sure if this is a regression from Cocoa.. I think location bar decorations were difficult to access via a11y already there.


UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3530.0 Safari/537.36
bookmark_expected.png
180 KB View Download
content_setting_actual.png
206 KB View Download

Comment 1 by ellyjo...@chromium.org, Aug 30

Labels: Target-71 M-71
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
That's weird - its accessibility text also doesn't make it sound like a button. I'll have a look for M71.

Comment 2 by ellyjo...@chromium.org, Nov 12 

I repro this locally - the button is just described as "This page is tracking your location.", which is probably wrong.

Comment 3 by ellyjo...@chromium.org, Nov 12

Labels: -M-71 -Target-71 Target-72 M-72
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6

commit c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Nov 13 16:18:10 2018

views: fix IconLabelBubbleView accessibility properties

IconLabelBubbleView is a Button and should use Button::GetAccessibleNodeData,
not Label::GetAccessibleNodeData. Setting its button text causes the right
behavior here.

Before: "This site is using your location."
After: "This site is using your location. Button."

Maybe ideally: "This site is using your location. Manage location access.
               Button."

... but that requires new strings.

Bug:  879014 
Change-Id: I7b4840e17ea70eede41ee0b3095a8a2de288c6ea
Reviewed-on: https://chromium-review.googlesource.com/c/1331668
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607608}
[modify] https://crrev.com/c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/c5c2f0c09a90e0c2b80c7c2863837e9beef8ecb6/chrome/browser/ui/views/location_bar/location_icon_view.h

Comment 5 by ellyjo...@chromium.org, Nov 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment