Disable Assistant in Public Sessions |
|||
Issue descriptionI don't think Assistant works in public sessions. We should explicitly disable it.
,
Sep 6
how to check if it is running in public sessions?
,
Sep 7
chromeos::LoginState::Get()->IsPublicSessionUser()
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1c6ee97d346d56b1af660bd3a4dafe764d9a69b commit c1c6ee97d346d56b1af660bd3a4dafe764d9a69b Author: Xiaohui Chen <xiaohuic@google.com> Date: Thu Sep 13 21:44:16 2018 assistant: disable for public session Bug: 878996 Test: locally compile Change-Id: I5c8a35244777d14d3e1dbe36a9925f4d1424f696 Reviewed-on: https://chromium-review.googlesource.com/1220170 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#591171} [modify] https://crrev.com/c1c6ee97d346d56b1af660bd3a4dafe764d9a69b/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/c1c6ee97d346d56b1af660bd3a4dafe764d9a69b/ash/ash_strings.grd [modify] https://crrev.com/c1c6ee97d346d56b1af660bd3a4dafe764d9a69b/ash/public/interfaces/voice_interaction_controller.mojom [modify] https://crrev.com/c1c6ee97d346d56b1af660bd3a4dafe764d9a69b/chrome/browser/chromeos/arc/arc_util.cc [modify] https://crrev.com/c1c6ee97d346d56b1af660bd3a4dafe764d9a69b/chrome/browser/chromeos/arc/arc_util_unittest.cc
,
Sep 13
,
Sep 19
Verified using M71 build on Nocturne |
|||
►
Sign in to add a comment |
|||
Comment 1 by michae...@chromium.org
, Aug 30