New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878993 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

VariationsService: FATAL:thread_restrictions.cc(29)] Check failed: !g_blocking_disallowed.Get().Get().

Project Member Reported by alemate@chromium.org, Aug 30

Issue description

Chrome OS, Eve device, latest ToT (ebf6eeb9da9addf47e6ca899bf9a2a0f7e8a85cb). Crash on system start in Debug build:

[31553:31553:0829/170604.778835:FATAL:thread_restrictions.cc(29)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the TaskScheduler, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices).
#0 0x567d1538bdf8 base::debug::StackTrace::StackTrace()
#1 0x567d1512e75c base::debug::StackTrace::StackTrace()
#2 0x567d1517712a logging::LogMessage::~LogMessage()
#3 0x567d152e310b base::AssertBlockingAllowed()
#4 0x567d1539a034 base::PathExists()
#5 0x567d16f4c626 ui::ResourceBundle::GetLocaleFilePath()
#6 0x567d16f4c33a ui::ResourceBundle::LocaleDataPakExists()
#7 0x567d16f22488 (anonymous namespace)::IsLocaleAvailable()
#8 0x567d16f212a2 l10n_util::CheckAndResolveLocale()
#9 0x567d16f22adb l10n_util::GetApplicationLocaleInternal()
#10 0x567d16f22e3e l10n_util::GetApplicationLocale()
#11 0x567d16f22f51 l10n_util::GetApplicationLocale()
#12 0x567d1a17a80b variations::(anonymous namespace)::GetApplicationLocale()
#13 0x567d1a178761 variations::VariationsFieldTrialCreator::GetClientFilterableStateForVersion()
#14 0x567d1a18330b variations::VariationsService::PerformSimulationWithVersion()
#15 0x567d10e44628 _ZN4base8internal13FunctorTraitsIMN3exo6BufferEFvNSt3__110unique_ptrINS3_7TextureENS4_14default_deleteIS6_EEEERKNS_17RepeatingCallbackIFvvEEEEvE6InvokeISG_RKNS_7WeakPtrIS3_EEJS9_SE_EEEvT_OT0_DpOT1_
#16 0x567d1a188235 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN10variations17VariationsServiceEFvNSt3__110unique_ptrINS4_14VariationsSeedENS6_14default_deleteIS8_EEEERKNS_7VersionEERKNS_7WeakPtrIS5_EEJSB_SE_EEEvOT_OT0_DpOT1_
#17 0x567d1a1880b9 _ZN4base8internal7InvokerINS0_9BindStateIMN10variations17VariationsServiceEFvNSt3__110unique_ptrINS3_14VariationsSeedENS5_14default_deleteIS7_EEEERKNS_7VersionEEJNS_7WeakPtrIS4_EENS0_13PassedWrapperISA_EEEEEFvSD_EE7RunImplIRKSF_RKNS5_5tupleIJSH_SJ_EEEJLm0ELm1EEEEvOT_OT0_NS5_16integer_sequenceImJXspT1_EEEESD_
#18 0x567d1a187f74 _ZN4base8internal7InvokerINS0_9BindStateIMN10variations17VariationsServiceEFvNSt3__110unique_ptrINS3_14VariationsSeedENS5_14default_deleteIS7_EEEERKNS_7VersionEEJNS_7WeakPtrIS4_EENS0_13PassedWrapperISA_EEEEEFvSD_EE3RunEPNS0_13BindStateBaseESD_
#19 0x567d0b5ba95c _ZNO4base12OnceCallbackIFvRK18WebApplicationInfoEE3RunES3_
#20 0x567d0e4761f8 base::internal::ReplyAdapter<>()
#21 0x567d0b5582b9 _ZN4base8internal13FunctorTraitsIPFvNS_12OnceCallbackIFbvEEEPNSt3__110unique_ptrIbNS5_14default_deleteIbEEEEEvE6InvokeISC_JS4_SA_EEEvOT_DpOT0_
#22 0x567d1a18927d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvNS_12OnceCallbackIFvRKNS_7VersionEEEEPNSt3__110unique_ptrIS5_NSA_14default_deleteIS5_EEEEEJS9_SF_EEEvOT_DpOT0_
#23 0x567d1a18921f _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12OnceCallbackIFvRKNS_7VersionEEEEPNSt3__110unique_ptrIS4_NS9_14default_deleteIS4_EEEEEJS8_NS0_12OwnedWrapperISD_EEEEEFvvEE7RunImplISG_NS9_5tupleIJS8_SI_EEEJLm0ELm1EEEEvOT_OT0_NS9_16integer_sequenceImJXspT1_EEEE
#24 0x567d1a189119 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12OnceCallbackIFvRKNS_7VersionEEEEPNSt3__110unique_ptrIS4_NS9_14default_deleteIS4_EEEEEJS8_NS0_12OwnedWrapperISD_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#25 0x567d0b5cc58c _ZNO4base12OnceCallbackIFvvEE3RunEv
#26 0x567d152d3bd4 base::(anonymous namespace)::PostTaskAndReplyRelay::RunReply()
#27 0x567d152d3f43 _ZN4base8internal13FunctorTraitsIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEvE6InvokeIS5_JS3_EEEvOT_DpOT0_
#28 0x567d152d3ead _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS5_EEEvOT_DpOT0_
#29 0x567d152d3e70 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunImplIS6_NSt3__15tupleIJS4_EEEJLm0EEEEvOT_OT0_NSB_16integer_sequenceImJXspT1_EEEE
#30 0x567d152d3db9 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#31 0x567d0b5cc58c _ZNO4base12OnceCallbackIFvvEE3RunEv
#32 0x567d153d6408 base::debug::TaskAnnotator::RunTask()
#33 0x567d15190c66 base::MessageLoop::RunTask()
#34 0x567d1519100e base::MessageLoop::DeferOrRunPendingTask()
#35 0x567d15191509 base::MessageLoop::DoWork()
#36 0x567d153cbc95 base::MessagePumpLibevent::Run()
#37 0x567d1519035b base::MessageLoop::Run()
#38 0x567d1521261d base::RunLoop::Run()
#39 0x567d143c96b3 ChromeBrowserMainParts::MainMessageLoopRun()
#40 0x567d0e9f9bd1 content::BrowserMainLoop::RunMainMessageLoopParts()
#41 0x567d0ea02270 content::BrowserMainRunnerImpl::Run()
#42 0x567d0e9ec91b content::BrowserMain()
#43 0x567d143915f7 content::RunBrowserProcessMain()
#44 0x567d14393f7b content::ContentMainRunnerImpl::Run()
#45 0x567d14388a9c content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
#46 0x567d143abf5a service_manager::Main()
#47 0x567d1438ef93 content::ContentMain()
#48 0x567d0b43c3d8 ChromeMain
#49 0x567d0b43c2c2 main
#50 0x7b751a6c7736 __libc_start_main
#51 0x567d0b43c169 _start

 
Cc: -mpear...@chromium.org
Owner: hanxi@chromium.org
I believe this is caused by https://chromium-review.googlesource.com/c/chromium/src/+/1147481

Since locale can't change at runtime, we should probably cache the first value we get (when IO is allowed) and re-use it later (when IO is no longer allowed).
Is this bug still valid?
Status: Fixed (was: Untriaged)
It has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1213308. Marked as fixed.

Sign in to add a comment