Issue 878984 link

Starred by 1 user

Issue metadata

Status:	WontFix
Owner:	----
Closed:	Dec 12
Cc:	newcomer@chromium.org
Components:	UI>Shell>Launcher
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
intern-bug

Participants' hotlists:
Launcher-Tech-Debt

Update SearchBoxViewTest implementation

Project Member Reported by oxyflush@chromium.org, Aug 29

Issue description

In SearchBoxViewTest.

Change KeyPress() to use EventGenerator::PressKey in SearchBoxViewTest. Also change derive SearchBoxViewAutocompleteTest from AshTestBase in order to test events properly using EventGenerator instead of explicitly calling event handlers.

Change KeyPress() to use EventGenerator::PressKey in SearchBoxViewTest. Also derive SearchBoxViewAutocompleteTest from AshTestBase in order to test events properly using EventGenerator instead of explicitly calling event handlers.

Change KeyPress() to use EventGenerator::PressKey in SearchBoxViewTest. Also derive SearchBoxViewTest from AshTestBase in order to test other events properly using EventGenerator instead of explicitly calling event handlers.

Comment 1 by oxyflush@chromium.org, Aug 30

Components: UI>Shell>Launcher

Comment 2 by newcomer@chromium.org, Sep 4

Why?

Comment 3 by oxyflush@chromium.org, Sep 4

Current KeyPress is a pared down version of actually pressing a key. Because of this, when testing features that require the insertion of a character vs. the handling of an event, we have to use KeyPress and HandleKeyEvent respectively. Using PressKey will allow us to do both in one method.