Convert isolate upload to use sawrming task service account (for LUCI) |
||
Issue descriptionWe shouldn't rely on IP whitelisting which is very fragile. (context in issue 878775 ) We should consider this blocking migrating perf to LUCI since it's a huge pain trying to whitelist IP of all the LUCI compile perf builder
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ac14b9f58d8908924f021303cda8a3e8e9209a34 commit ac14b9f58d8908924f021303cda8a3e8e9209a34 Author: nednguyen <nednguyen@google.com> Date: Thu Sep 06 18:37:11 2018 Use LUCI service account for perf dashboard when running bot is LUCI Bug:878976 Change-Id: I36b31b9dcfb450396a33fb520b58317bb2a651d8 Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/1210583 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Simon Hatch <simonhatch@chromium.org> [modify] https://crrev.com/ac14b9f58d8908924f021303cda8a3e8e9209a34/scripts/slave/recipe_modules/perf_dashboard/resources/post_json.py [modify] https://crrev.com/ac14b9f58d8908924f021303cda8a3e8e9209a34/scripts/slave/recipe_modules/perf_dashboard/api.py [modify] https://crrev.com/ac14b9f58d8908924f021303cda8a3e8e9209a34/scripts/slave/recipe_modules/perf_dashboard/__init__.py
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/b9b825ec0c3057be321e6256499f6c798bfcea4f commit b9b825ec0c3057be321e6256499f6c798bfcea4f Author: Simon <simonhatch@chromium.org> Date: Mon Sep 10 23:05:49 2018 Pinpoint - Let isolate handler use oauth or ip whitelist. Ned's doing the waterfall luci conversion, easier to just switch this to allow service accounts to upload than update the ip whitelist over and over. Bug: chromium:878976 Change-Id: I437e44168c52960098c7576b9f8abd3ee0f1fb96 Reviewed-on: https://chromium-review.googlesource.com/1217265 Reviewed-by: Dave Tu <dtu@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> [modify] https://crrev.com/b9b825ec0c3057be321e6256499f6c798bfcea4f/dashboard/dashboard/pinpoint/handlers/isolate_test.py [modify] https://crrev.com/b9b825ec0c3057be321e6256499f6c798bfcea4f/dashboard/dashboard/pinpoint/handlers/isolate.py
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/926ac01aeb63d7d27b876585c8b87659c5cd77d4 commit 926ac01aeb63d7d27b876585c8b87659c5cd77d4 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Sep 11 00:26:23 2018 Roll src/third_party/catapult b3b8b5883ce2..b9b825ec0c30 (2 commits) https://chromium.googlesource.com/catapult.git/+log/b3b8b5883ce2..b9b825ec0c30 git log b3b8b5883ce2..b9b825ec0c30 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 simonhatch@chromium.org Pinpoint - Let isolate handler use oauth or ip whitelist. 2018-09-10 brucedawson@chromium.org Display cswitch header version on errors Created with: gclient setdep -r src/third_party/catapult@b9b825ec0c30 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:878976 TBR=sullivan@chromium.org Change-Id: I03d031e0322217a27db3909dc5105430b1c289a5 Reviewed-on: https://chromium-review.googlesource.com/1217807 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590127} [modify] https://crrev.com/926ac01aeb63d7d27b876585c8b87659c5cd77d4/DEPS
,
Oct 8
|
||
►
Sign in to add a comment |
||
Comment 1 by nednguyen@chromium.org
, Sep 6Labels: LUCI-Blocker-Chromium
Owner: nednguyen@chromium.org
Status: Started (was: Untriaged)