Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@chromium.org ...... too many results, data snipped.... and 40 other(s) in performance_webview_test_suite failing on chromium.perf/Android Nexus6 WebView Perf Builders failed on: - Android Nexus6 WebView Perf: https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus6%20WebView%20Perf Root cause seems to be that the http replay isn't working anymore:. It fails trying to navigate to the URL. (error) https://consent.cmp.oath.com/cmp.js:3: CMP Error: Error retrieving GDPR consent from GUCE (error) https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:1: Ad errored out (error) https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:26: [HlsPlayer][getSegInfo] Exception = Cannot read property 'getMetrics' of null stack = TypeError: Cannot read property 'getMetrics' of null at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:24:5282) at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:23:20753) at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:26:9887) at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:26:11640) at n.rn (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:11:19117) at n.publish (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:1:4113) at n.kk (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:8:3718) at n.qk (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:8:5941) at n.tb (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:8:7831) at n.publish (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:1:4113) (error) https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:26: [HlsPlayer][getSegInfo] Exception = Cannot read property 'getMetrics' of null stack = TypeError: Cannot read property 'getMetrics' of null at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:24:5282) at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:23:20753) at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:26:9887) at n.getSegInfo (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:26:11640) at n.rn (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:11:19117) at n.publish (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:1:4113) at n.kk (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:8:3718) at n.ik (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:8:5101) at n.ee (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:8:6480) at n.publish (https://yep.video.yahoo.com/js/3/videoplayer-min.js?r=nextgen-desktop&lang=en-US&ypv=prod:1:4113) (log) https://s.yimg.com/rq/darla/3-4-3/js/g-r-min.js:3: DARLA notice: 510 (log) https://s.yimg.com/rq/darla/3-4-3/js/g-r-min.js:3: DARLA notice: 525 (log) https://s.yimg.com/rq/darla/3-4-3/js/g-r-min.js:3: DARLA notice: 510 (log) https://s.yimg.com/rq/darla/3-4-3/js/g-r-min.js:3: DARLA notice: 525 (log) https://s.yimg.com/rq/darla/3-4-3/js/g-r-min.js:3: DARLA notice: 510 (log) https://s.yimg.com/rq/darla/3-4-3/js/g-r-min.js:3: DARLA notice: 525
Or maybe root cause is just that navigation isn't working on webview anymore? https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=08acd9f0b018d1168bfddb059c0601d0db27f5d3&as=benchmark_log.txt
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1137402e640000
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1137402e640000 Remove unneeded list from event_stream_logger.js by elkurin@google.com https://chromium.googlesource.com/chromium/src/+/d63515c275e89472e3e6cd4e9248c9c761640a0a 0 → 1 (+1) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
I'm going to re-run the job in comment 5, there was a problem with the Pinpoint builder. https://chromium-review.googlesource.com/c/chromium/tools/build/+/1196697
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/13f074b3640000
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/695d7853260ec253204dab30e9e92b89b0cfaf24 commit 695d7853260ec253204dab30e9e92b89b0cfaf24 Author: Ned Nguyen <nednguyen@google.com> Date: Thu Aug 30 22:13:46 2018 Revert "Remove unneeded list from event_stream_logger.js" This reverts commit d63515c275e89472e3e6cd4e9248c9c761640a0a. Reason for revert: breaking all webview benchmark BUG:878965 Original change's description: > Remove unneeded list from event_stream_logger.js > > Change-Id: I8494b52cd7a38d2b52184f4fb02030d3a05da776 > Reviewed-on: https://chromium-review.googlesource.com/1187861 > Reviewed-by: Yuki Awano <yawano@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Eriko Kurimoto <elkurin@google.com> > Cr-Commit-Position: refs/heads/master@{#585742} TBR=dtseng@chromium.org,yawano@chromium.org,elkurin@google.com,sarakato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I65b1079c6496f83cbe2a332d8e7570eb3a92d244 Reviewed-on: https://chromium-review.googlesource.com/1196840 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#587806} [modify] https://crrev.com/695d7853260ec253204dab30e9e92b89b0cfaf24/chrome/browser/resources/chromeos/chromevox/cvox2/background/event_stream_logger.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeafd48ed69c11f1903e132ffca0f37f87f14258 commit aeafd48ed69c11f1903e132ffca0f37f87f14258 Author: Eriko Kurimoto <elkurin@google.com> Date: Fri Aug 31 08:03:19 2018 Revert "Revert "Remove unneeded list from event_stream_logger.js"" This reverts commit 695d7853260ec253204dab30e9e92b89b0cfaf24. This commit is just removing arrays already stored in EventType. Also, it is called only when chromevox developer option flag is enabled. This option is WIP and the flag is disabled in default. This is irrelevant to webview benchmark. TBR=dtseng@chromium.org,nednguyen@google.com,yawano@chromium.org,sarakato@chromium.org Bug: 878965 Change-Id: Id2ab67061bd39597a2ebac0fedb2d7f00e6494ee Reviewed-on: https://chromium-review.googlesource.com/1198649 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#587962} [modify] https://crrev.com/aeafd48ed69c11f1903e132ffca0f37f87f14258/chrome/browser/resources/chromeos/chromevox/cvox2/background/event_stream_logger.js
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/13f074b3640000 🤝 Move Trusted Web Activity metrics over to CustomTabActivity. by peconn@chromium.org https://chromium.googlesource.com/chromium/src/+/452b3c09d6c03e0ae1cd7fcc8017de4242e7b062 0 → 1 (+1) [VK] Use non-accessibility keyboard when opening keyboard from tray. by shend@chromium.org https://chromium.googlesource.com/chromium/src/+/2d6e66dc4dc9a7416c67a346b0d0e0057e751276 1 → 1 (+0) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1139b6a9640000
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1139b6a9640000 Surface Synchronization: Enable by default on Android by ericrk@chromium.org https://chromium.googlesource.com/chromium/src/+/5479bee2ba20c0527e19137d8056b539d30125d1 0 → 1 (+1) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
Comment 1 by crouleau@chromium.org
, Aug 29