Skylab: Add LogDog support
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/afb718fd381706d39211ed47b235f65b6dd2c48a commit afb718fd381706d39211ed47b235f65b6dd2c48a Author: Allen Li <ayatane@google.com> Date: Thu Aug 30 01:25:55 2018 Pass a file for logdog output This is intended to be a FIFO with the reader processing annotations and sending to LogDog, but it is indistinguishable from any writable file from the Lucifer end. BUG=chromium:877544 BUG= chromium:878956 TEST=None Change-Id: Ic40c72b1a08174c03bd13f737a05475d89fdde28 Reviewed-on: https://chromium-review.googlesource.com/1194311 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/afb718fd381706d39211ed47b235f65b6dd2c48a/src/lucifer/cmd/lucifer/common.go [modify] https://crrev.com/afb718fd381706d39211ed47b235f65b6dd2c48a/src/lucifer/cmd/lucifer/main.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ca0fbd1550588bd7af35c0066cfcd06357f0f876 commit ca0fbd1550588bd7af35c0066cfcd06357f0f876 Author: Allen Li <ayatane@chromium.org> Date: Fri Aug 31 22:23:37 2018 skylab: Pass a FIFO instead of a pipe to Lucifer R=pprabhu@chromium.org Bug: 878956 Change-Id: I7738e7efbb405e2357cc5b84ad22418b753f7eaa Reviewed-on: https://chromium-review.googlesource.com/1198542 Commit-Queue: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#17361} [add] https://crrev.com/ca0fbd1550588bd7af35c0066cfcd06357f0f876/go/src/infra/cmd/skylab_swarming_worker/fifo_posix.go [add] https://crrev.com/ca0fbd1550588bd7af35c0066cfcd06357f0f876/go/src/infra/cmd/skylab_swarming_worker/fifo.go [modify] https://crrev.com/ca0fbd1550588bd7af35c0066cfcd06357f0f876/go/src/infra/cmd/skylab_swarming_worker/main.go [add] https://crrev.com/ca0fbd1550588bd7af35c0066cfcd06357f0f876/go/src/infra/cmd/skylab_swarming_worker/fifo_windows.go [modify] https://crrev.com/ca0fbd1550588bd7af35c0066cfcd06357f0f876/go/src/infra/cmd/skylab_swarming_worker/logdog.go [modify] https://crrev.com/ca0fbd1550588bd7af35c0066cfcd06357f0f876/go/src/infra/cmd/skylab_swarming_worker/internal/lucifer/lucifer.go
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/5862135f16eb7dc5113cef8a163757ceeabc7ebe commit 5862135f16eb7dc5113cef8a163757ceeabc7ebe Author: Allen Li <ayatane@google.com> Date: Thu Sep 06 21:48:08 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/486d33573dc5807a8ca514218a256ed3fe40b262 commit 486d33573dc5807a8ca514218a256ed3fe40b262 Author: Allen Li <ayatane@google.com> Date: Fri Sep 07 18:35:43 2018 Remove log package This package was intended to be a hook point for outputting to LogDog. It turns out that that isn't a very good approach, so removing. BUG= chromium:878956 TEST=None Change-Id: I23e439ee8a915cfb43dd486dcbfa45866598abf2 Reviewed-on: https://chromium-review.googlesource.com/1205893 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Jacob Kopczynski <jkop@chromium.org> [modify] https://crrev.com/486d33573dc5807a8ca514218a256ed3fe40b262/src/lucifer/cmd/lucifer/testcmd.go [modify] https://crrev.com/486d33573dc5807a8ca514218a256ed3fe40b262/src/lucifer/cmd/lucifer/common.go [modify] https://crrev.com/486d33573dc5807a8ca514218a256ed3fe40b262/src/lucifer/cmd/lucifer/admintaskcmd.go [modify] https://crrev.com/486d33573dc5807a8ca514218a256ed3fe40b262/src/lucifer/cmd/lucifer/main.go [delete] https://crrev.com/95d1b8d72ec8cbcea52c45b155e7f9f615b45eed/src/lucifer/log/log.go [modify] https://crrev.com/486d33573dc5807a8ca514218a256ed3fe40b262/src/lucifer/cmd/lucifer/metrics.go [modify] https://crrev.com/486d33573dc5807a8ca514218a256ed3fe40b262/src/lucifer/monitoring/monitoring.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/716d4df9dd1946e8c97540328ce2b91736d1ae3f commit 716d4df9dd1946e8c97540328ce2b91736d1ae3f Author: Allen Li <ayatane@google.com> Date: Fri Sep 07 18:35:43 2018 Add annotations package BUG= chromium:878956 TEST=None Change-Id: I1b7c8c58531370deea64977837f6d4a53ae13a79 Reviewed-on: https://chromium-review.googlesource.com/1205894 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Jacob Kopczynski <jkop@chromium.org> [add] https://crrev.com/716d4df9dd1946e8c97540328ce2b91736d1ae3f/src/lucifer/annotations/annotations.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/85b229330cbdd4e6b100d45c00e5440e4425b5c3 commit 85b229330cbdd4e6b100d45c00e5440e4425b5c3 Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 18:35:39 2018 autotest: Push temp_json_path argument down call chain BUG= chromium:878956 TEST=None Change-Id: Ic434af5287e1734d7e38daed16c1e38686b9e1c6 Reviewed-on: https://chromium-review.googlesource.com/1205693 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/85b229330cbdd4e6b100d45c00e5440e4425b5c3/venv/skylab_suite/suite_runner.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ef146b50837088af4a21b4d6c614e6d0bc2ca228 commit ef146b50837088af4a21b4d6c614e6d0bc2ca228 Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 18:35:40 2018 autotest: Remove duplicate swarming flag BUG= chromium:878956 TEST=None Change-Id: Iff5e3a9c544b5970d56ba38b8ce012a474b0fc02 Reviewed-on: https://chromium-review.googlesource.com/1205694 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/ef146b50837088af4a21b4d6c614e6d0bc2ca228/venv/skylab_suite/suite_runner.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cd8e45a1a8f4b13979a9b2abd86fdeeda6a5c620 commit cd8e45a1a8f4b13979a9b2abd86fdeeda6a5c620 Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 18:35:40 2018 autotest: Always use fallback We have decided to use fallback everywhere. The reason for removing this now is that we are passing around a ton of state everywhere, so I'm hacking out unnecessary stuff so I can read more clearly and figure out the best way to pass around a LogDog URL. BUG= chromium:878956 TEST=None Change-Id: I9ec268574c335787ee814d73e39b24a44d743986 Reviewed-on: https://chromium-review.googlesource.com/1205695 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/cd8e45a1a8f4b13979a9b2abd86fdeeda6a5c620/venv/skylab_suite/cros_suite.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b5888f046d53726e08d1c377fdf61fca72036c1f commit b5888f046d53726e08d1c377fdf61fca72036c1f Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 18:35:41 2018 autotest: Remove use_fallback fields from classes We have decided to use fallback everywhere. The reason for removing this now is that we are passing around a ton of state everywhere, so I'm hacking out unnecessary stuff so I can read more clearly and figure out the best way to pass around a LogDog URL. BUG= chromium:878956 TEST=None Change-Id: I42ca13682cb3300f2ffb34bd34910879719f3309 Reviewed-on: https://chromium-review.googlesource.com/1205831 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/b5888f046d53726e08d1c377fdf61fca72036c1f/venv/skylab_suite/suite_tracking.py [modify] https://crrev.com/b5888f046d53726e08d1c377fdf61fca72036c1f/venv/skylab_suite/suite_parser.py [modify] https://crrev.com/b5888f046d53726e08d1c377fdf61fca72036c1f/venv/skylab_suite/cros_suite.py [modify] https://crrev.com/b5888f046d53726e08d1c377fdf61fca72036c1f/venv/skylab_suite/cmd/run_suite_skylab.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9e11951ddfe761756eed166fd8c1c69806ac1bc0 commit 9e11951ddfe761756eed166fd8c1c69806ac1bc0 Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 18:35:41 2018 autotest: Remove use_fallback params from functions Also remove a duplicate code path for creating Swarming tasks. We have decided to use fallback everywhere. The reason for removing this now is that we are passing around a ton of state everywhere, so I'm hacking out unnecessary stuff so I can read more clearly and figure out the best way to pass around a LogDog URL. BUG= chromium:878956 TEST=None Change-Id: Id3969e6e29f693a3fffdee4d5d36781797dfcf6e Reviewed-on: https://chromium-review.googlesource.com/1205832 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/9e11951ddfe761756eed166fd8c1c69806ac1bc0/venv/skylab_suite/suite_runner.py [modify] https://crrev.com/9e11951ddfe761756eed166fd8c1c69806ac1bc0/venv/skylab_suite/suite_tracking.py [modify] https://crrev.com/9e11951ddfe761756eed166fd8c1c69806ac1bc0/venv/skylab_suite/cros_suite.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eef43240de36fc18d108d28bca2d95e9cd041c90 commit eef43240de36fc18d108d28bca2d95e9cd041c90 Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 18:35:42 2018 autotest: Remove extra space BUG= chromium:878956 TEST=None Change-Id: I4746e59558b6ef6e73e186ed827459f3e3d376b0 Reviewed-on: https://chromium-review.googlesource.com/1208852 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/eef43240de36fc18d108d28bca2d95e9cd041c90/venv/skylab_suite/suite_runner.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/71e42c27091619f418fb30fd483f77f7152d7cf9 commit 71e42c27091619f418fb30fd483f77f7152d7cf9 Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 18:35:43 2018 autotest: Remove unused _make_trigger_swarming_cmd BUG= chromium:878956 TEST=None Change-Id: I11d817e098b343de05eef4debf0fa42ce3e33875 Reviewed-on: https://chromium-review.googlesource.com/1208853 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/71e42c27091619f418fb30fd483f77f7152d7cf9/venv/skylab_suite/suite_runner.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/10047b722acf70172b561cd13abe9ad74c5efbfe commit 10047b722acf70172b561cd13abe9ad74c5efbfe Author: Allen Li <ayatane@chromium.org> Date: Fri Sep 07 20:27:08 2018 autotest: Move _make_new_swarming_cmd to swarming_lib This is where this function should go, next to the similar get_basic_swarming_cmd() BUG= chromium:878956 TEST=None Change-Id: Ifabbdd3226b8fe216cdfec9b1f5f423f22342ab1 Reviewed-on: https://chromium-review.googlesource.com/1208854 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/10047b722acf70172b561cd13abe9ad74c5efbfe/venv/skylab_suite/suite_runner.py [modify] https://crrev.com/10047b722acf70172b561cd13abe9ad74c5efbfe/venv/skylab_suite/swarming_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9d7d52432c7ce4373162b75eb1c84f7b1c3f8e13 commit 9d7d52432c7ce4373162b75eb1c84f7b1c3f8e13 Author: Allen Li <ayatane@chromium.org> Date: Mon Sep 17 18:17:18 2018 crosskylabadmin: Add LogDog support when creating tasks R=pprabhu@chromium.org, tandrii@chromium.org Bug: 878956 Change-Id: Iddb26d076635bb615026a043d0ba2ba2edefc39c Reviewed-on: https://chromium-review.googlesource.com/1211691 Commit-Queue: Allen Li <ayatane@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#17639} [modify] https://crrev.com/9d7d52432c7ce4373162b75eb1c84f7b1c3f8e13/go/src/infra/appengine/crosskylabadmin/app/frontend/tasker.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8b2bedaebfa63c5c9b458beedae6c248b4ffa4ed commit 8b2bedaebfa63c5c9b458beedae6c248b4ffa4ed Author: Allen Li <ayatane@chromium.org> Date: Mon Sep 17 19:40:22 2018 autotest: Enable LogDog for skylab suite tests BUG= chromium:878956 TEST=Manual, trigger test with equivalent tags Change-Id: I661708af269146ef4889cb4ec4356278b104a99f Reviewed-on: https://chromium-review.googlesource.com/1205692 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/8b2bedaebfa63c5c9b458beedae6c248b4ffa4ed/venv/skylab_suite/suite_runner.py [modify] https://crrev.com/8b2bedaebfa63c5c9b458beedae6c248b4ffa4ed/venv/skylab_suite/swarming_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/d3f17afa290f7b2d2840aa3c5c3b9a360f3880d9 commit d3f17afa290f7b2d2840aa3c5c3b9a360f3880d9 Author: Allen Li <ayatane@google.com> Date: Tue Sep 18 20:17:04 2018 Add logdog package BUG= chromium:878956 TEST=None Change-Id: I774529f0ae58e6143680ad68af2d8ba2e75a5f4b Reviewed-on: https://chromium-review.googlesource.com/1205895 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [add] https://crrev.com/d3f17afa290f7b2d2840aa3c5c3b9a360f3880d9/src/lucifer/logdog/textlogger.go [add] https://crrev.com/d3f17afa290f7b2d2840aa3c5c3b9a360f3880d9/src/lucifer/logdog/logdog_test.go [add] https://crrev.com/d3f17afa290f7b2d2840aa3c5c3b9a360f3880d9/src/lucifer/logdog/logdog.go [add] https://crrev.com/d3f17afa290f7b2d2840aa3c5c3b9a360f3880d9/src/lucifer/logdog/basic.go [add] https://crrev.com/d3f17afa290f7b2d2840aa3c5c3b9a360f3880d9/src/lucifer/logdog/textlogger_test.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/977de03e74a457396bf58d6dcc2a740958274028 commit 977de03e74a457396bf58d6dcc2a740958274028 Author: Allen Li <ayatane@google.com> Date: Tue Sep 18 22:20:51 2018 Change LogDog plain text format This output will potentially be mixed with output from other processes, so don't try to do anything fancy and prefix every output line so it can be identified as coming from lucifer. BUG= chromium:878956 TEST=None Change-Id: I8e57dac51b04447d30927aa2b6687f1738ff332c Reviewed-on: https://chromium-review.googlesource.com/1211651 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/977de03e74a457396bf58d6dcc2a740958274028/src/lucifer/logdog/textlogger.go [modify] https://crrev.com/977de03e74a457396bf58d6dcc2a740958274028/src/lucifer/logdog/textlogger_test.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/f8acfef34f451bf0f60ae54b15329975db5c6c8d commit f8acfef34f451bf0f60ae54b15329975db5c6c8d Author: Allen Li <ayatane@google.com> Date: Tue Sep 18 22:20:53 2018 Move global log setup to commonSetup This enables LogDog support for admin tasks too. BUG= chromium:878956 TEST=None Change-Id: I48aac147f86b6a24336a86bfaff33da8f2e63d72 Reviewed-on: https://chromium-review.googlesource.com/1212307 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/f8acfef34f451bf0f60ae54b15329975db5c6c8d/src/lucifer/cmd/lucifer/testcmd.go [modify] https://crrev.com/f8acfef34f451bf0f60ae54b15329975db5c6c8d/src/lucifer/cmd/lucifer/common.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/fd9024640d0045dad5801a12bcffa99a4e29bb0c commit fd9024640d0045dad5801a12bcffa99a4e29bb0c Author: Allen Li <ayatane@google.com> Date: Tue Sep 18 22:20:54 2018 Add logger getter method to common resources BUG= chromium:878956 TEST=None Change-Id: I486fe4c0b971913f61b61235e345d3a2bd141c36 Reviewed-on: https://chromium-review.googlesource.com/1213590 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/fd9024640d0045dad5801a12bcffa99a4e29bb0c/src/lucifer/cmd/lucifer/common.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/bb16052c1ea359a7def4e0f481e05fc1f5983965 commit bb16052c1ea359a7def4e0f481e05fc1f5983965 Author: Allen Li <ayatane@google.com> Date: Wed Sep 19 21:50:51 2018 Add RawWriter to logdog.Logger This is mainly for passing to subprocesses, instead of trying to proxy subprocess output through Logger.Println, which may have performance repercussions. BUG= chromium:878956 TEST=None Change-Id: Icd25d388f2c49e46a730003bc2755d32c7388168 Reviewed-on: https://chromium-review.googlesource.com/1229379 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/bb16052c1ea359a7def4e0f481e05fc1f5983965/src/lucifer/logdog/textlogger.go [modify] https://crrev.com/bb16052c1ea359a7def4e0f481e05fc1f5983965/src/lucifer/logdog/logdog.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/876287f4af4083f3ddfeb0d93a1286c4541bbc6d commit 876287f4af4083f3ddfeb0d93a1286c4541bbc6d Author: Allen Li <ayatane@google.com> Date: Wed Sep 19 21:50:51 2018 Log when switching back from LogDog BUG= chromium:878956 TEST=None Change-Id: Ie9ec6e732266526932fb2f34257db7184284b5e0 Reviewed-on: https://chromium-review.googlesource.com/1229380 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/876287f4af4083f3ddfeb0d93a1286c4541bbc6d/src/lucifer/cmd/lucifer/common.go
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/1662e81ea660ffe7cafccea962bad462966a1516 commit 1662e81ea660ffe7cafccea962bad462966a1516 Author: Allen Li <ayatane@chromium.org> Date: Wed Sep 19 23:05:42 2018 crosskylabadmin: Add behavior for nil ClientFactory R=pprabhu@chromium.org Bug: 878956 Change-Id: I95d4b53882d7ae6de27f16dee531a57c57bea4d9 Reviewed-on: https://chromium-review.googlesource.com/1231614 Commit-Queue: Allen Li <ayatane@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#17741} [modify] https://crrev.com/1662e81ea660ffe7cafccea962bad462966a1516/go/src/infra/appengine/crosskylabadmin/app/frontend/tasker.go [modify] https://crrev.com/1662e81ea660ffe7cafccea962bad462966a1516/go/src/infra/appengine/crosskylabadmin/app/frontend/tracker.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/2acc418e29fd37c496a27fb76a1cc21155be07c9 commit 2acc418e29fd37c496a27fb76a1cc21155be07c9 Author: Allen Li <ayatane@google.com> Date: Fri Sep 28 00:08:54 2018 Thread LogDog through Lucifer Make Lucifer pass around a LogDog logger, emitting steps and forwarding subprocess output. BUG= chromium:878956 TEST=None Change-Id: I8b4e216d62cec0b24637e3aa12b9a2db16d487d5 Reviewed-on: https://chromium-review.googlesource.com/1229381 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/2acc418e29fd37c496a27fb76a1cc21155be07c9/src/lucifer/autotest/atutil/atutil.go [modify] https://crrev.com/2acc418e29fd37c496a27fb76a1cc21155be07c9/src/lucifer/cmd/lucifer/testcmd.go [modify] https://crrev.com/2acc418e29fd37c496a27fb76a1cc21155be07c9/src/lucifer/cmd/lucifer/admintaskcmd.go
Comment 1 by ayatane@chromium.org
, Aug 29