New issue
Advanced search Search tips

Issue 878951 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 879662



Sign in to add a comment

Land 'Life of a Pixel' performance tests

Project Member Reported by vmi...@chromium.org, Aug 29

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d99176feb1593378a83ac0f70c8a792edf9797d2

commit d99176feb1593378a83ac0f70c8a792edf9797d2
Author: Victor Miura <vmiura@chromium.org>
Date: Thu Aug 30 01:27:47 2018

Add useful high-level CC traces to the 'benchmark' tracing category.

Also moves some verbose CC traces to the 'cc.debug' category.

BUG= 878951 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3bcd20057489d27c934986cf2cbfe9d4679ff12e
Reviewed-on: https://chromium-review.googlesource.com/1192689
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587372}
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/layers/layer.cc
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/layers/picture_layer.cc
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/tiles/tile_manager.cc
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/d99176feb1593378a83ac0f70c8a792edf9797d2/cc/trees/layer_tree_impl.cc

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16372f19640000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: '/b/s/w/itUOWtiX/tmpDB89eatelemetry/histograms.json'
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/16ed52c9640000
TODO: Remove cc_scroll_200_layer_grid & js_scroll_200_layer_grid after new tests land, and we have sufficient overlapping data.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5397fe05b09cd14be4e193cacf92fc68a17868c8

commit 5397fe05b09cd14be4e193cacf92fc68a17868c8
Author: Victor Miura <vmiura@chromium.org>
Date: Thu Aug 30 20:07:33 2018

Add layer count based tests to tough_compositor_cases.

Tests enabled on Mobile:
  - css_opacity_plus_n_layers_0
  - css_opacity_plus_n_layers_75
  - css_opacity_plus_n_layers_99
  - js_opacity_plus_n_layers_0
  - js_opacity_plus_n_layers_75
  - js_opacity_plus_n_layers_99
  - js_paint_plus_n_layers_0
  - js_paint_plus_n_layers_75
  - js_paint_plus_n_layers_99
  - infinite_scroll_element_n_layers_0
  - infinite_scroll_element_n_layers_75
  - infinite_scroll_element_n_layers_99
  - infinite_scroll_root_n_layers_0
  - infinite_scroll_root_n_layers_75
  - infinite_scroll_root_n_layers_99

Tests enabled on Desktop:
  - css_opacity_plus_n_layers_99
  - js_opacity_plus_n_layers_99
  - js_paint_plus_n_layers_99
  - infinite_scroll_element_n_layers_99
  - infinite_scroll_root_n_layers_99

BUG= 878951 

Change-Id: Iac2cb8d55424ef47e7f33de375540dee7cbc43c3
Reviewed-on: https://chromium-review.googlesource.com/1192690
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587719}
[add] https://crrev.com/5397fe05b09cd14be4e193cacf92fc68a17868c8/chrome/test/data/perf/tough_compositor_cases/bench.js
[add] https://crrev.com/5397fe05b09cd14be4e193cacf92fc68a17868c8/chrome/test/data/perf/tough_compositor_cases/css_opacity_plus_n_layers.html
[add] https://crrev.com/5397fe05b09cd14be4e193cacf92fc68a17868c8/chrome/test/data/perf/tough_compositor_cases/infinite_scroll_element_n_layers.html
[add] https://crrev.com/5397fe05b09cd14be4e193cacf92fc68a17868c8/chrome/test/data/perf/tough_compositor_cases/infinite_scroll_root_n_layers.html
[add] https://crrev.com/5397fe05b09cd14be4e193cacf92fc68a17868c8/chrome/test/data/perf/tough_compositor_cases/js_opacity_plus_n_layers.html
[add] https://crrev.com/5397fe05b09cd14be4e193cacf92fc68a17868c8/chrome/test/data/perf/tough_compositor_cases/js_paint_plus_n_layers.html
[modify] https://crrev.com/5397fe05b09cd14be4e193cacf92fc68a17868c8/tools/perf/page_sets/rendering/tough_compositor_cases.py

Blocking: 879662
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85f78938e304061d5dea7a5455ffaab5d7881adb

commit 85f78938e304061d5dea7a5455ffaab5d7881adb
Author: Victor Miura <vmiura@chromium.org>
Date: Thu Nov 08 22:22:58 2018

Increase padding in layer count based benchmark pages.

In Telemetry on Desktop, various toast messages can change the window
height dynamically and make layers in the test that should be out of
viewport be visible.

Double the padding height to ensure they're not visible in these cases.

BUG= 878951 

Change-Id: I19a3990ebd3b577fc19ac73cf72db4e6ecfae3db
Reviewed-on: https://chromium-review.googlesource.com/c/1292812
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606621}
[modify] https://crrev.com/85f78938e304061d5dea7a5455ffaab5d7881adb/chrome/test/data/perf/tough_compositor_cases/css_opacity_plus_n_layers.html
[modify] https://crrev.com/85f78938e304061d5dea7a5455ffaab5d7881adb/chrome/test/data/perf/tough_compositor_cases/js_opacity_plus_n_layers.html
[modify] https://crrev.com/85f78938e304061d5dea7a5455ffaab5d7881adb/chrome/test/data/perf/tough_compositor_cases/js_paint_plus_n_layers.html

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d5ca99f28add2c0b844511a2416d1f555726c9b

commit 9d5ca99f28add2c0b844511a2416d1f555726c9b
Author: Victor Miura <vmiura@chromium.org>
Date: Wed Nov 14 02:23:22 2018

Remove old *_scroll_200_layer_grid rendering stories.

These stories are superceded by newer stories such as
infinite_scroll_root_n_layers_99 and css_opacity_plus_n_layers_99.

Now that we have had overlapping data from the new stories for some
time, the old stories can be removed.

BUG= 878951 

Change-Id: Idb146ed7d9f5420bac1d5217e86c6547a772efe5
Reviewed-on: https://chromium-review.googlesource.com/c/1334929
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607874}
[modify] https://crrev.com/9d5ca99f28add2c0b844511a2416d1f555726c9b/tools/perf/page_sets/rendering/tough_compositor_cases.py

Status: Fixed (was: Assigned)

Sign in to add a comment