New issue
Advanced search Search tips

Issue 878947 link

Starred by 1 user
Status: Fixed
Owner:
lanwei@chromium.org
Closed: Sep 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Set WebMouseEvent correctly in SyntheticMouseDriver

Project Member Reported by lanwei@chromium.org, Aug 29 
In SyntheticMouseDriver, we set the click_count and button wrong for
WebMouseEvent when the type is mousemove. The click_count should be 0 and
button is set as one of button when multiple buttons are pressed for type
of mousemove.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89dde43c814f54c352a1d338bacfd6641a4b6ff0

commit 89dde43c814f54c352a1d338bacfd6641a4b6ff0
Author: Lan Wei <lanwei@chromium.org>
Date: Mon Sep 17 21:32:53 2018

Set WebMouseEvent correctly in SyntheticMouseDriver

In SyntheticMouseDriver, the click_count should be 0 and button is set
as one of button when multiple buttons are pressed for type of
mousemove.

Bug:  878947 
Change-Id: Ifb750e5a4c4af78ecb200cddb4a70cdfb6a61c18
Reviewed-on: https://chromium-review.googlesource.com/1195901
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591827}
[modify] https://crrev.com/89dde43c814f54c352a1d338bacfd6641a4b6ff0/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
[modify] https://crrev.com/89dde43c814f54c352a1d338bacfd6641a4b6ff0/content/browser/renderer_host/input/synthetic_mouse_driver.cc
[modify] https://crrev.com/89dde43c814f54c352a1d338bacfd6641a4b6ff0/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/89dde43c814f54c352a1d338bacfd6641a4b6ff0/content/common/input/synthetic_pointer_action_params.cc
[modify] https://crrev.com/89dde43c814f54c352a1d338bacfd6641a4b6ff0/content/common/input/synthetic_pointer_action_params.h

Comment 2 by lanwei@chromium.org, Sep 17

Status: Fixed (was: Started)
►

Sign in to add a comment