New issue
Advanced search Search tips

Issue 878945 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

presubmit check phase "check_control_files" seems to take too long

Project Member Reported by semenzato@chromium.org, Aug 29

Issue description

It runs twice for my CL (which includes a change to an autotest control file, and adds a new one), and takes about 20 seconds each time (I am assuming that's the culprit because it's the last line that gets printed before the long pauses).  All other phases take a small fraction of a second.
 
Status: WontFix (was: Untriaged)
The check_control_files makes multiple invocations of `cros_sdk`.
That's a slow command even in good circumstances:
      $ time cros_sdk echo ok
       * C.UTF-8: cannot open locale definition file `C': No such file or directory
      ok

      real      0m9.869s
      user      0m1.723s
      sys       0m0.639s

It does that in order to run various forms of `equery`, so there's no
non-trivial out-of-chroot alternative.  As such, I don't anticipate that
anybody's going to do anything to fix this.

Status: (was: WontFix)
Just to be clear, I am running this inside cros_sdk.
This bug had an unsupported status. Updating to Untriaged so someone will reevaluate.
Status: Untriaged

Sign in to add a comment