ShelfBackgroundAnimatorTest.FullscreenAppListBackground failing on multiple builders |
|||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@chromium.org ash_unittests failing on multiple builders Builders failed on: - linux-chromeos-dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg - linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel - Linux ChromiumOS MSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests
,
Aug 29
,
Aug 29
Hi nednguyen@, how can I help on this bug?
,
Aug 29
Since you wrote that test (based on blame), can you fix it?
,
Aug 29
Could you please send me the blame?
,
Aug 29
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91ee15e9ef28b7354b6389e6b399d8fe651d39ec commit 91ee15e9ef28b7354b6389e6b399d8fe651d39ec Author: Ned Nguyen <nednguyen@google.com> Date: Wed Aug 29 22:51:01 2018 Disable ShelfBackgroundAnimatorTest.FullscreenAppListBackground on CrOS Bug:878944 Change-Id: I5a802921bc4de918811d011a246b1daa56c9cbfb TBR=wutao@chromium.org Change-Id: I5a802921bc4de918811d011a246b1daa56c9cbfb Reviewed-on: https://chromium-review.googlesource.com/1195933 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#587347} [modify] https://crrev.com/91ee15e9ef28b7354b6389e6b399d8fe651d39ec/ash/shelf/shelf_background_animator_unittest.cc
,
Aug 29
Hi Manu, Do you know we are changing the behaviors of shelf background color? The test was written one year ago, and now is not working. Thanks.
,
Aug 30
Yeah this should get fixed momentarily.
,
Aug 30
,
Aug 30
Weird sequence of events. Basically: 1) Original change gets submitted. Breaks a test but CA didn't catch it. 2) Fix for the broken test is submitted. 3) Original change gets auto-reverted.
,
Aug 30
,
Aug 30
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/772d29aecf63a18f8f64b95a79bdafe46e8f6584 commit 772d29aecf63a18f8f64b95a79bdafe46e8f6584 Author: James Cook <jamescook@chromium.org> Date: Thu Jan 10 16:45:35 2019 Don't use OS_CHROMEOS macro in //ash All the code in //ash is chromeos-only. Also, re-enable ShelfBackgroundAnimatorTest.FullscreenAppListBackground because it seems to pass now. Bug: 878944 Change-Id: Ib982f3109f52533bca1ab1086878ba066727b7ec Reviewed-on: https://chromium-review.googlesource.com/c/1404422 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#621606} [modify] https://crrev.com/772d29aecf63a18f8f64b95a79bdafe46e8f6584/ash/display/mouse_cursor_event_filter_unittest.cc [modify] https://crrev.com/772d29aecf63a18f8f64b95a79bdafe46e8f6584/ash/shelf/shelf_background_animator_unittest.cc [modify] https://crrev.com/772d29aecf63a18f8f64b95a79bdafe46e8f6584/ash/system/message_center/arc/arc_notification_view_unittest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nednguyen@chromium.org
, Aug 29