New issue
Advanced search Search tips

Issue 878943 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Video Capture] Distinguish logged reasons for why reserving buffer from pool failed

Project Member Reported by chfremer@chromium.org, Aug 29

Issue description

Instead of logging just VideoFrameDropReason::kDeviceClientFailedToReserveBufferFromBufferPool, we should distinguish failures caused by max number of pool buffers being reached vs. allocation of new buffer failed (typically because out of memory).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba

commit 5061e5d681c6befa9efd8ee8a24e94ef2814f8ba
Author: Christian Fremerey <chfremer@chromium.org>
Date: Fri Sep 21 00:42:21 2018

[Video Capture, UMA] Distinguish out of memory from buffer pool max count exceeded

Currently, failures to obtain a video capture buffer from the buffer pool are
logged all in one bucket. This CL splits the failures into out of memory vs.
buffer pool max count exceeded.

To enable this, the CL changes the interface of media::VideoCaptureBufferPool to
return a result code that breaks out failure cases instead of having a single
failure path.

Bug: 878943
Change-Id: I0a74a8034e936ea02a1ead26a6cb5d916e05e288
Reviewed-on: https://chromium-review.googlesource.com/1220192
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593025}
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/content/browser/media/capture/desktop_capture_device_unittest.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/content/browser/media/capture/screen_capture_device_android_unittest.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/content/android/thread_safe_capture_oracle.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/mojom/video_capture_types.mojom
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/mojom/video_capture_types_mojom_traits.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/chromeos/mock_video_capture_client.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/chromeos/mock_video_capture_client.h
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/fake_video_capture_device.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/fake_video_capture_device_unittest.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/mock_video_capture_device_client.h
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_buffer_pool.h
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_buffer_pool_impl.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_buffer_pool_impl.h
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_device.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_device.h
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_device_client.h
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/video_capture_device_unittest.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video/win/video_capture_device_mf_win_unittest.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/media/capture/video_capture_types.h
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/services/video_capture/shared_memory_virtual_device_mojo_adapter.cc
[modify] https://crrev.com/5061e5d681c6befa9efd8ee8a24e94ef2814f8ba/tools/metrics/histograms/enums.xml

Sign in to add a comment