New issue
Advanced search Search tips

Issue 878941 link

Starred by 1 user
Status: Fixed
Owner:
qin...@chromium.org
Closed: Nov 13
Cc:
qin...@chromium.org
cthomp@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

UKM for download started is not recorded

Project Member Reported by xingliu@chromium.org, Aug 29 
Chrome Version: 70.0.3536.0


DownloadUkmHelper::RecordDownloadStarted currently is not invoked on new downloads in https://chromium.googlesource.com/chromium/src/+/70.0.3536.0/components/download/internal/common/download_item_impl.cc#1472

The if check for |in_progress_entry| is always null, thus this UKM is not recorded correctly.

Comment 1 by xingliu@chromium.org, Aug 29

Owner: qin...@chromium.org

Comment 2 by qin...@chromium.org, Aug 29

Labels: M-69

Comment 3 by qin...@chromium.org, Aug 29 

the issue should present in M69

Comment 4 by qin...@chromium.org, Aug 29

Labels: -Pri-2 Pri-1
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58bde6bc94bf6cb066200c13ed03cf0b1b0d0b05

commit 58bde6bc94bf6cb066200c13ed03cf0b1b0d0b05
Author: Min Qin <qinmin@chromium.org>
Date: Thu Aug 30 01:39:01 2018

Fix an issue that download started UKM is not recorded

BUG= 878941 

Change-Id: Id4dcd3ed90ada0b0dfce643addf4751d9eb23424
Reviewed-on: https://chromium-review.googlesource.com/1195937
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587391}
[modify] https://crrev.com/58bde6bc94bf6cb066200c13ed03cf0b1b0d0b05/components/download/internal/common/in_progress_download_manager.cc

Comment 6 by cthomp@chromium.org, Aug 30 

Thanks for the quick fix! Manually testing this shows that Download.Started events are getting tracked as expected now.

Comment 7 by qin...@chromium.org, Aug 30

Labels: Merge-Request-69
Status: started (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 30

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by benmason@chromium.org, Aug 30

Labels: -Hotlist-Merge-Review -Merge-Review-69 Merge-Approved-69
Approved for merge into 69, branch 3497.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7342b4f1d459217bec3eef3f588832e36f9fddcb

commit 7342b4f1d459217bec3eef3f588832e36f9fddcb
Author: Min Qin <qinmin@chromium.org>
Date: Thu Aug 30 16:47:32 2018

Fix an issue that download started UKM is not recorded

BUG= 878941 

Change-Id: Id4dcd3ed90ada0b0dfce643addf4751d9eb23424
Reviewed-on: https://chromium-review.googlesource.com/1195937
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587391}(cherry picked from commit 58bde6bc94bf6cb066200c13ed03cf0b1b0d0b05)
Reviewed-on: https://chromium-review.googlesource.com/1197103
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#848}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/7342b4f1d459217bec3eef3f588832e36f9fddcb/components/download/internal/common/in_progress_download_manager.cc

Comment 11 by qin...@chromium.org, Nov 13

Status: Fixed (was: Started)
►

Sign in to add a comment