New issue
Advanced search Search tips

Issue 878937 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Remove the homecher notch if the gesture swiping to dismiss homecher is disabled.

Project Member Reported by newcomer@chromium.org, Aug 29

Issue description

Don't show the notch unless gesture swiping the homecher is enabled.
 
Description: Show this description
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d1b3cc29338ddba1e02834e879900d7cda562a8

commit 0d1b3cc29338ddba1e02834e879900d7cda562a8
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 30 17:40:53 2018

cros: Remove launcher notch in tablet mode if gestures are disabled

The home launcher notch is shown normally to indicate that the launcher
can be dragged. This draggability is behind the HomeLauncherGestures
flag.

If this flag is disabled and the device is in tablet mode, do not draw
the notch.

Bug:  878937 
Change-Id: I17b60cc689f39658edcb22bfb55be7ad53b26e34
Reviewed-on: https://chromium-review.googlesource.com/1195935
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587649}
[modify] https://crrev.com/0d1b3cc29338ddba1e02834e879900d7cda562a8/ash/app_list/views/contents_view.cc

Status: Fixed (was: Started)
Labels: Merge-Request-70
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 12

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 17

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70

Sign in to add a comment