New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878920 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Sign in to add a comment

Video to LUMINANCE, ALPHA and LUMINANCE_ALPHA texture tests failing on Android

Project Member Reported by kbr@chromium.org, Aug 29

Issue description

In  Issue 733599  some new tests were added which exercise uploads to LUMINANCE, ALPHA and LUMINANCE_ALPHA type textures. These tests are failing on Android right now:

conformance/textures/video/tex-2d-alpha-alpha-unsigned_byte.html
conformance/textures/video/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html
conformance/textures/video/tex-2d-luminance-luminance-unsigned_byte.html

They're suppressed in this file (unfortunately under  Issue 733599  and not this bug):

https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/webgl_conformance_expectations.py?type=cs&q=webgl_conformance_expectations.py+tex-2d-alpha-alpha-unsigned_byte.html&sq=package:chromium&g=0&l=542

(The WebGL 2.0 tests aren't running on the waterfall yet.)

We should fix these issues to be able to enable these tests and keep them running.

 
Owner: jdarpinian@chromium.org
Status: Assigned (was: Available)
James said he'd look into this.

thanks for that.
These tests are actually passing. They are getting blamed for a GPU process crash caused by a different test because the test harness doesn't detect crashes ( bug 863221 ).
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f

commit d4ed2040e25c6a4bb9b8c239eabc268ede992a3f
Author: James Darpinian <jdarpinian@chromium.org>
Date: Mon Nov 05 21:56:34 2018

GPU command buffer: Support copying ALPHA/LUMINANCE on ES3

http://crrev.com/c/567306 added support for LUMINANCE, ALPHA, and
LUMINANCE_ALPHA formats to the CopyTextureCHROMIUM implementation. This
also enables that support on OpenGL ES 3 contexts for Android. Fixes
WebGL conformance tests:

conformance/textures/video/tex-2d-alpha-alpha-unsigned_byte.html
conformance/textures/video/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html
conformance/textures/video/tex-2d-luminance-luminance-unsigned_byte.html

Bug:  878920 
Change-Id: Iee4a5189662c1c820ec2fc99b676a1b4e1beb1a0
Reviewed-on: https://chromium-review.googlesource.com/c/1302825
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605483}
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/copy_texture_chromium_mock.cc
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/copy_texture_chromium_mock.h
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_copy_tex_image.cc
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_copy_tex_image.h
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_decoder.h
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/d4ed2040e25c6a4bb9b8c239eabc268ede992a3f/ui/gl/gl_version_info.h

Blockedon: angleproject:2774
Status: Fixed (was: Assigned)
I was wrong about the tests passing. They were legitimately failing. In fixing this I ran into an ANGLE bug where swizzling cubemaps doesn't work on DX11, angleproject:2774. Luckily we don't need to emulate ALPHA/LUMINANCE on ANGLE so it's not a problem.
Blockedon: -angleproject:2774
Blocking: angleproject:2774
Great work James fixing this! Turning around the blocked on / blocking relationship to the ANGLE bug.

Blocking: angleproject:2952
Blocking: 850257

Sign in to add a comment