New issue
Advanced search Search tips

Issue 878919 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Bug



Sign in to add a comment

[Remoting Mobile] App crashes because of mojo not being initialized

Project Member Reported by yuweih@chromium.org, Aug 29

Issue description

App crashes at launch:

[0829/142058.801366:ERROR:thunks.cc(39)] Function 'MojoCreateMessagePipe()' not supported in this version of Mojo Core.
[0829/142058.802891:FATAL:message_pipe.h(140)] Check failed: MOJO_RESULT_OK == result (0 vs. 12)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4debbed750aca54fe46c20a8c286c4b04fe483c3

commit 4debbed750aca54fe46c20a8c286c4b04fe483c3
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Aug 30 20:51:25 2018

[Remoting Mobile] Fix crashes related to mojo URL loader refactoring

We have found a few crashes on Chromoting mobile clients that are
related to a refactoring to replace URLFetcher with ChromiumUrlRequest:

* Apps crash at launch because mojo core is not initialized.
* TransitionalURLLoaderFactoryOwner and the SharedURLLoaderFactory it
  creates seem to be thread unsafe, so the app crashes because of some
  thread checker failures.

These issues are fixed by:

* Calling mojo::core::Init() in the client runtime.
* Make url_loader_factory() only being called on the network thread and
  guard it with DCHECK.

Bug:  878919 
Change-Id: I3827b5175546aa9845b53e95cbd913043028b59e
Reviewed-on: https://chromium-review.googlesource.com/1196026
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587754}
[modify] https://crrev.com/4debbed750aca54fe46c20a8c286c4b04fe483c3/remoting/base/telemetry_log_writer.cc
[modify] https://crrev.com/4debbed750aca54fe46c20a8c286c4b04fe483c3/remoting/base/telemetry_log_writer.h
[modify] https://crrev.com/4debbed750aca54fe46c20a8c286c4b04fe483c3/remoting/base/telemetry_log_writer_unittest.cc
[modify] https://crrev.com/4debbed750aca54fe46c20a8c286c4b04fe483c3/remoting/client/BUILD.gn
[modify] https://crrev.com/4debbed750aca54fe46c20a8c286c4b04fe483c3/remoting/client/DEPS
[modify] https://crrev.com/4debbed750aca54fe46c20a8c286c4b04fe483c3/remoting/client/chromoting_client_runtime.cc
[modify] https://crrev.com/4debbed750aca54fe46c20a8c286c4b04fe483c3/remoting/client/chromoting_client_runtime.h

Status: Fixed (was: Assigned)

Sign in to add a comment