New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878916 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 790075
issue 874449



Sign in to add a comment

luci auth failing flakily on perf builder

Project Member Reported by nednguyen@chromium.org, Aug 29

Issue description

Cc: dtu@chromium.org simonhatch@chromium.org
Blocking: 874449 790075
Cc: iannucci@chromium.org no...@chromium.org
Nodir, Robbie: any thoughts about why luci-auth fails with "failed to refresh the token" flakily?
You are using too large timeout:
https://cs.chromium.org/chromium/src/tools/perf/core/results_dashboard.py?q=LuciAuthTokenGeneratorCallback&sq=package:chromium&g=0&l=37

see comment in https://cs.chromium.org/chromium/infra/recipes-py/recipe_modules/service_account/api.py?l=37

rational: our goal is to have tokens short lived, so that after task completes, bad task after that doesn't have lots of time to abuse the system.
Owner: nednguyen@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73e83f95cd896a7e4f75b4eb4b76802a69349131

commit 73e83f95cd896a7e4f75b4eb4b76802a69349131
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed Aug 29 23:02:13 2018

[perf] Do not specify timeout limit for luci-auth's token generation

We misunderstood how authentication token works in the past. For one time request,
the token expiration time don't matter much.

Setting a high timeout expiration is making luci-auth fail flakily. Since we
generate a new token for every perf dashboard upload attempt, using the default
value of luci-auth should be fine

Bug:878916
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ie9025fb0fc2467dda02cd8aa0aa3e2136ca190a8

NOTRY=true # all tests passed, speed up landing to green up perf waterfall uploading

Change-Id: Ie9025fb0fc2467dda02cd8aa0aa3e2136ca190a8
Reviewed-on: https://chromium-review.googlesource.com/1195930
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587352}
[modify] https://crrev.com/73e83f95cd896a7e4f75b4eb4b76802a69349131/tools/perf/core/results_dashboard.py

Sign in to add a comment