New issue
Advanced search Search tips

Issue 878914 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 887051

Blocking:
issue 847992
issue 613210



Sign in to add a comment

mash: browser window context menus

Project Member Reported by est...@chromium.org, Aug 29

Issue description

Browser windows (and app windows in the multi-profile case) have context menus that are shown when the user right clicks on the header/frame area. Currently this is unimplemented w/Mash, so there are no context menus for the header.

Some options that come to mind:

1. make the client responsible for the header, as previously discussed, but then window dragging would probably break and have to be dealt with somehow. Same for window resizing, perhaps.
2. have Ash tell the client to run a context menu. This might not work well given that context menus need to handle various sequences of mouse press, release, drag, etc.
3. create an interface where the client sets a list of context menu items, Ash runs the context menu and when an item is selected, informs the client
4. Let clients have first crack at events in non-client area, and then send them to ash when they're not handled by the client
 
Cc: sky@chromium.org
Labels: Proj-Mash-SingleProcess
Scott, wdyt of the above options?
I like 1 as I believe it'll mean only one place (browser side) needs to draw to windows, which is likely to give us better performance than what we have right now. If we go with (1), it means we need to add mojo apis for all functionality offered by the frame decorations. How big is that api?

I believe (3) is what we do for the shelf, so that is likely the simplest route to go now. I wouldn't be surprised if performance issues force us to 1, but I don't have any data at this point, so I can't definitively say.
613210 would no longer be an issue if we go with (1) as well.
Blocking: 613210
Blockedon: 887051
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)
No need to address this any more since the browser frame was moved to client side rendering.

App window context menus were added in a4102566063c7fc9b3e7ca7ce

Sign in to add a comment