New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878910 link

Starred by 1 user
Status: Fixed
Owner:
█ jonmann@chromium.org
Last visit 20 days ago
Closed: Sep 1
Cc:
azeemarshad@chromium.org
█ jlklein@chromium.org
█ jhawkins@chromium.org
█ shihuis@chromium.org
█ jonmann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Messages Web PWA is not getting properly installed

Project Member Reported by jonm...@google.com, Aug 29 
Chrome Version: (copy from chrome://version): 70.0.3532.0 11015.0.0

it seems that there is a trailing slash on the base URL and a leading slash on the URL params[1], which leads to attempting to install the PWA from https://android-messages.sandbox.google.com//?e=DittoServiceWorker,DittoPwa,DittoIndexedDb

The server doesn't like the double slash and returns a 404 :(


[1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/android_sms/android_sms_urls.cc?sq=package:chromium&g=0&l=20-26

Comment 1 by jonm...@google.com, Aug 29

Owner: jonmann@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ff3ed2d3a95ac21a3eee7a5094f63a833ebe03

commit a4ff3ed2d3a95ac21a3eee7a5094f63a833ebe03
Author: Jon Mann <jonmann@chromium.org>
Date: Thu Aug 30 01:34:17 2018

Fix the Android Messages URL to avoid having a two consecutive slashes.

Bug:  878910 
Change-Id: Ia6da0bd878c4c69996ff856583cc21840926510d
Reviewed-on: https://chromium-review.googlesource.com/1196024
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587383}
[modify] https://crrev.com/a4ff3ed2d3a95ac21a3eee7a5094f63a833ebe03/chrome/browser/chromeos/android_sms/android_sms_urls.cc

Comment 3 by jonmann@chromium.org, Aug 30

Status: Fixed (was: Started)

Comment 4 by khorimoto@chromium.org, Aug 31

Labels: Merge-Request-70
Status: Started (was: Fixed)

Comment 5 by khorimoto@chromium.org, Aug 31

Labels: M-70

Comment 6 by khorimoto@chromium.org, Sep 1

Labels: -Merge-Request-70
Status: Fixed (was: Started)
My mistake - this did actually make the branch cut.
►

Sign in to add a comment