DCHECK in client_hints.cc: Check failed: 0 <= rtt_msec (0 vs. -0.92) |
||||||
Issue descriptionBuilding Chromium locally (src @ a2effa5b0149) and running it on an Android emulator I am consistently hitting this DCHECK when I tap on the Yahoo link from the new tab page: Searching for native crashes in: /usr/local/google/clankium2/src/stack.raw Unknown Android release, consider passing --packed-lib. Reading Android symbols from: /usr/local/google/clankium2/src Searching for Chrome symbols from within: /usr/local/google/clankium2/src/out_android_emu/Debug/lib.unstripped:/usr/local/google/clankium2/src/out_android_emu/Debug [FATAL:client_hints.cc(153)] Check failed: 0 <= rtt_msec (0 vs. -0.92) Stack Trace: RELADDR FUNCTION FILE:LINE 001229df base::debug::StackTrace::StackTrace() /usr/local/google/clankium2/src/base/debug/stack_trace.cc:199:28 0013781a logging::LogMessage::~LogMessage() /usr/local/google/clankium2/src/base/logging.cc:599:29 0128c11d client_hints::internal::RoundRtt(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, base::Optional<base::TimeDelta> const&) /usr/local/google/clankium2/src/chrome/browser/client_hints/client_hints.cc:153:3 0128cb32 client_hints::GetAdditionalNavigationRequestClientHintsHeaders(content::BrowserContext*, GURL const&) /usr/local/google/clankium2/src/chrome/browser/client_hints/client_hints.cc:288:30 01281508 ChromeContentBrowserClient::NavigationRequestStarted(int, GURL const&, std::__ndk1::unique_ptr<net::HttpRequestHeaders, std::__ndk1::default_delete<net::HttpRequestHeaders> >*, int*) /usr/local/google/clankium2/src/chrome/browser/chrome_content_browser_client.cc:2228:7 013d26f5 content::NavigationRequest::NavigationRequest(content::FrameTreeNode*, content::CommonNavigationParams const&, mojo::StructPtr<content::mojom::BeginNavigationParams>, content::RequestNavigationParams const&, bool, bool, content::FrameNavigationEntry const*, content::NavigationEntryImpl const*, std::__ndk1::unique_ptr<content::NavigationUIData, std::__ndk1::default_delete<content::NavigationUIData> >, mojo::AssociatedInterfacePtrInfo<content::mojom::NavigationClient>) /usr/local/google/clankium2/src/content/browser/frame_host/navigation_request.cc:495:34 013d1e31 content::NavigationRequest::CreateBrowserInitiated(content::FrameTreeNode*, GURL const&, content::Referrer const&, content::FrameNavigationEntry const&, content::NavigationEntryImpl const&, FrameMsg_Navigate_Type::Value, int, bool, bool, scoped_refptr<network::ResourceRequestBody> const&, base::TimeTicks const&, content::NavigationControllerImpl*, std::__ndk1::unique_ptr<content::NavigationUIData, std::__ndk1::default_delete<content::NavigationUIData> >) /usr/local/google/clankium2/src/content/browser/frame_host/navigation_request.cc:338:61 013c444f content::NavigationControllerImpl::CreateNavigationRequest(content::FrameTreeNode*, content::NavigationEntryImpl const&, content::FrameNavigationEntry*, content::ReloadType, bool, bool, scoped_refptr<network::ResourceRequestBody> const&, std::__ndk1::unique_ptr<content::NavigationUIData, std::__ndk1::default_delete<content::NavigationUIData> >) /usr/local/google/clankium2/src/content/browser/frame_host/navigation_controller_impl.cc:2615:10 013c05a7 content::NavigationControllerImpl::NavigateWithoutEntry(content::NavigationController::LoadURLParams const&) /usr/local/google/clankium2/src/content/browser/frame_host/navigation_controller_impl.cc:2380:48 013c00f6 content::NavigationControllerImpl::LoadURLWithParams(content::NavigationController::LoadURLParams const&) /usr/local/google/clankium2/src/content/browser/frame_host/navigation_controller_impl.cc:771:3 014ce060 TabAndroid::LoadUrl(_JNIEnv*, base::android::JavaParamRef<_jobject*> const&, base::android::JavaParamRef<_jstring*> const&, base::android::JavaParamRef<_jstring*> const&, base::android::JavaParamRef<_jobject*> const&, int, base::android::JavaParamRef<_jstring*> const&, int, unsigned char, unsigned char, unsigned char, unsigned char) /usr/local/google/clankium2/src/chrome/browser/android/tab_android.cc:632:37 014cdcc0 Java_org_chromium_chrome_browser_tab_Tab_nativeLoadUrl /usr/local/google/clankium2/src/out_android_emu/Debug/gen/chrome/browser/jni_headers/chrome/jni/Tab_jni.h:137:18 00a0257c <UNKNOWN> /data/data/org.chromium.chrome/incremental-install-files/optimized-dexes/chrome.android.chrome_java.dex.dex
,
Aug 30
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b79159619c25649807573480eb9fa127514da15 commit 6b79159619c25649807573480eb9fa127514da15 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Aug 31 19:10:51 2018 Handle negative network quality values In certain cases (e.g., when the device is offline), network quality estimator (NQE) may emit negative network quality values. This CL adds logic to handle those values: In the manager class, if the estimate changes from an unknown value to a know value, then the client is always notified. In the tracker class, handle notifications that indicate that a metric is unavailable. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2c82914e51c649a6b1b2e9b21682ebd4a193b138 Bug: 878893 Reviewed-on: https://chromium-review.googlesource.com/1196105 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#588109} [modify] https://crrev.com/6b79159619c25649807573480eb9fa127514da15/services/network/network_quality_estimator_manager.cc [modify] https://crrev.com/6b79159619c25649807573480eb9fa127514da15/services/network/network_quality_estimator_manager_unittest.cc [modify] https://crrev.com/6b79159619c25649807573480eb9fa127514da15/services/network/public/cpp/network_quality_tracker.cc [modify] https://crrev.com/6b79159619c25649807573480eb9fa127514da15/services/network/public/cpp/network_quality_tracker_unittest.cc
,
Aug 31
,
Sep 1
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4
Carlos: Thanks for reporting this bug. It should be fixed now. Please let me know if you still see it.
,
Sep 5
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f3466a1f831d1f9f602a27ff9b201622dc55770 commit 9f3466a1f831d1f9f602a27ff9b201622dc55770 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Sep 04 16:57:05 2018 Handle negative network quality values In certain cases (e.g., when the device is offline), network quality estimator (NQE) may emit negative network quality values. This CL adds logic to handle those values: In the manager class, if the estimate changes from an unknown value to a know value, then the client is always notified. In the tracker class, handle notifications that indicate that a metric is unavailable. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2c82914e51c649a6b1b2e9b21682ebd4a193b138 Bug: 878893 Reviewed-on: https://chromium-review.googlesource.com/1196105 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588109}(cherry picked from commit 6b79159619c25649807573480eb9fa127514da15) Reviewed-on: https://chromium-review.googlesource.com/1203452 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#27} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/9f3466a1f831d1f9f602a27ff9b201622dc55770/services/network/network_quality_estimator_manager.cc [modify] https://crrev.com/9f3466a1f831d1f9f602a27ff9b201622dc55770/services/network/network_quality_estimator_manager_unittest.cc [modify] https://crrev.com/9f3466a1f831d1f9f602a27ff9b201622dc55770/services/network/public/cpp/network_quality_tracker.cc [modify] https://crrev.com/9f3466a1f831d1f9f602a27ff9b201622dc55770/services/network/public/cpp/network_quality_tracker_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Aug 29Labels: -Pri-3 Pri-2
Owner: tbansal@chromium.org
Status: Assigned (was: Untriaged)