New issue
Advanced search Search tips

Issue 878873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move skylab worker to infra.git

Project Member Reported by ayatane@chromium.org, Aug 29

Issue description

Move skylab worker to infra.git
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1ccca8fea331a54bda8f2001657ad3700bdee962

commit 1ccca8fea331a54bda8f2001657ad3700bdee962
Author: Allen Li <ayatane@chromium.org>
Date: Wed Aug 29 21:39:45 2018

skylab: Use path to new worker from infra.git

The new worker CIPD package built from the Chrome Infra build process
goes here.  (The /usr/bin was primarily intended for Moblab, which
needs lucifer but not the skylab worker.)

BUG= chromium:878873 
TEST=None

Change-Id: Id02b3e161777ad2c76065e8d4ae31c79886421fb
Reviewed-on: https://chromium-review.googlesource.com/1195537
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/1ccca8fea331a54bda8f2001657ad3700bdee962/venv/skylab_suite/suite_runner.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4d46bd12b6b1e88aec5dde2304d7b1de51733334

commit 4d46bd12b6b1e88aec5dde2304d7b1de51733334
Author: Allen Li <ayatane@chromium.org>
Date: Thu Aug 30 19:21:36 2018

skylab: Remove abortsock package

This package contains code originally shared with Lucifer in a
different repo.  Almost all of this code is not needed by Skylab,
except one Abort function which can be moved elsewhere.

Bug:  878873 
Change-Id: I6930d3904c89aec5285c1b3e13eecff0bc81f00d
Reviewed-on: https://chromium-review.googlesource.com/1195950
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17321}
[delete] https://crrev.com/77e52793da31acbfe594b3129ff403734c96ee90/go/src/infra/cmd/skylab_swarming_worker/internal/abortsock/abortsock.infra_testing
[modify] https://crrev.com/4d46bd12b6b1e88aec5dde2304d7b1de51733334/go/src/infra/cmd/skylab_swarming_worker/lucifer_posix.go
[delete] https://crrev.com/77e52793da31acbfe594b3129ff403734c96ee90/go/src/infra/cmd/skylab_swarming_worker/internal/abortsock/abortsock.go
[delete] https://crrev.com/77e52793da31acbfe594b3129ff403734c96ee90/go/src/infra/cmd/skylab_swarming_worker/internal/abortsock/abortsock_test.go

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fb0e2aeb8a6b8893e34498df440fa4400c2de200

commit fb0e2aeb8a6b8893e34498df440fa4400c2de200
Author: Allen Li <ayatane@chromium.org>
Date: Thu Aug 30 20:10:38 2018

skylab: Remove unused flagx package members

This package contains code originally shared with Lucifer in a
different repo.  This code is not needed by Skylab.

Bug:  878873 
Change-Id: Ife8be2857b757c4107076aa30ed62b6ceb640c80
Reviewed-on: https://chromium-review.googlesource.com/1195951
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17323}
[modify] https://crrev.com/fb0e2aeb8a6b8893e34498df440fa4400c2de200/go/src/infra/cmd/skylab_swarming_worker/internal/flagx/flagx.go
[modify] https://crrev.com/fb0e2aeb8a6b8893e34498df440fa4400c2de200/go/src/infra/cmd/skylab_swarming_worker/internal/flagx/flagx_test.go

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/923218733ade3a6e63f26f3fd3a1079b52600829

commit 923218733ade3a6e63f26f3fd3a1079b52600829
Author: Allen Li <ayatane@chromium.org>
Date: Thu Aug 30 21:00:16 2018

skylab: Remove unused autotest package members

This package contains code originally shared with Lucifer in a
different repo.  This code is not needed by Skylab.

Bug:  878873 
Change-Id: I17cf406230d9c19b9c6a29518ec903a35aee01c9
Reviewed-on: https://chromium-review.googlesource.com/1195952
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17327}
[delete] https://crrev.com/768442175a7fc6c11666a65e35700dd1322a7c9d/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/autotest_test.go
[modify] https://crrev.com/923218733ade3a6e63f26f3fd3a1079b52600829/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/atutil/types.go
[modify] https://crrev.com/923218733ade3a6e63f26f3fd3a1079b52600829/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/autotest.go

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/40fa38b450944e3e7a1a60ae08cd1bedf5de835b

commit 40fa38b450944e3e7a1a60ae08cd1bedf5de835b
Author: Allen Li <ayatane@chromium.org>
Date: Thu Aug 30 22:27:55 2018

skylab: Use new worker path

This path is for the worker built from the infra.git repo.

Bug:  878873 
Change-Id: I04b523314e96226d4ea1df3727e82174c9524e71
Reviewed-on: https://chromium-review.googlesource.com/1197218
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17332}
[modify] https://crrev.com/40fa38b450944e3e7a1a60ae08cd1bedf5de835b/go/src/infra/appengine/crosskylabadmin/app/frontend/tasker.go

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/493243429a2116a05d877105c7e27bd33ac50d4b

commit 493243429a2116a05d877105c7e27bd33ac50d4b
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 31 01:16:25 2018

Add OWNERS for skylab_swarming_worker

Bug:  878873 
Change-Id: Id8a856a05259d46db3e08befec9d48c052f84469
Reviewed-on: https://chromium-review.googlesource.com/1198384
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17341}
[add] https://crrev.com/493243429a2116a05d877105c7e27bd33ac50d4b/go/src/infra/cmd/skylab_swarming_worker/OWNERS

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/146a361d07d5f9ee0277797a9a7edf8dd3f45bff

commit 146a361d07d5f9ee0277797a9a7edf8dd3f45bff
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 31 02:33:59 2018

autotest: Uprev skylab_swarming_worker during push

This is the new CIPD package built from infra.git, not bundled with lucifer.

BUG= chromium:878873 
TEST=None

Change-Id: I99b71deaacfa8819b91d09a79d94a7f1f3094edc
Reviewed-on: https://chromium-review.googlesource.com/1195062
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/146a361d07d5f9ee0277797a9a7edf8dd3f45bff/site_utils/automated_deploy.py

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/27198b493a0dfdad388e56aaad7a61b6d986e086

commit 27198b493a0dfdad388e56aaad7a61b6d986e086
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 31 21:42:16 2018

skylab: Clean up annotations package

1. Raise test coverage to 100%.
2. Merge unnecessarily split packages.
3. Rename package since annotee is confusing in this repo.

Bug:  878873 
Change-Id: I662d4d16798225f1395b2b308954389e9f8bf862
Reviewed-on: https://chromium-review.googlesource.com/1195953
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17356}
[add] https://crrev.com/27198b493a0dfdad388e56aaad7a61b6d986e086/go/src/infra/cmd/skylab_swarming_worker/internal/annotations/state.go
[rename] https://crrev.com/27198b493a0dfdad388e56aaad7a61b6d986e086/go/src/infra/cmd/skylab_swarming_worker/internal/annotations/annotations.go
[delete] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/go/src/infra/cmd/skylab_swarming_worker/internal/annotee/basic/basic.infra_testing
[delete] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/go/src/infra/cmd/skylab_swarming_worker/internal/annotee/client.go
[delete] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/go/src/infra/cmd/skylab_swarming_worker/internal/annotee/annotee.infra_testing
[add] https://crrev.com/27198b493a0dfdad388e56aaad7a61b6d986e086/go/src/infra/cmd/skylab_swarming_worker/internal/annotations/state_test.go
[add] https://crrev.com/27198b493a0dfdad388e56aaad7a61b6d986e086/go/src/infra/cmd/skylab_swarming_worker/internal/annotations/annotations.infra_testing
[modify] https://crrev.com/27198b493a0dfdad388e56aaad7a61b6d986e086/go/src/infra/cmd/skylab_swarming_worker/lucifer_posix.go

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d0ddf5c05aac057b30ad1e4c355de8bba3d45783

commit d0ddf5c05aac057b30ad1e4c355de8bba3d45783
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 31 21:59:38 2018

skylab: Clean up autotest package

1. Raise test coverage to 100%.
2. Merge unnecessarily split packages.

Bug:  878873 
Change-Id: If014f2f3cb4ff5d20312ba4352f158988514f1a9
Reviewed-on: https://chromium-review.googlesource.com/1195954
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17358}
[add] https://crrev.com/d0ddf5c05aac057b30ad1e4c355de8bba3d45783/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/doc.go
[modify] https://crrev.com/d0ddf5c05aac057b30ad1e4c355de8bba3d45783/go/src/infra/cmd/skylab_swarming_worker/internal/swarming/harness/hostinfo.go
[delete] https://crrev.com/f3f4a231ed1ebe509d3ce05a235b8fb32f50aead/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/autotest.go
[modify] https://crrev.com/d0ddf5c05aac057b30ad1e4c355de8bba3d45783/go/src/infra/cmd/skylab_swarming_worker/main.go
[rename] https://crrev.com/d0ddf5c05aac057b30ad1e4c355de8bba3d45783/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/admintasktype_string.go
[delete] https://crrev.com/f3f4a231ed1ebe509d3ce05a235b8fb32f50aead/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/autotest.infra_testing
[modify] https://crrev.com/d0ddf5c05aac057b30ad1e4c355de8bba3d45783/go/src/infra/cmd/skylab_swarming_worker/internal/lucifer/lucifer.go
[delete] https://crrev.com/f3f4a231ed1ebe509d3ce05a235b8fb32f50aead/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/atutil/atutil.infra_testing
[add] https://crrev.com/d0ddf5c05aac057b30ad1e4c355de8bba3d45783/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/admintask_test.go
[rename] https://crrev.com/d0ddf5c05aac057b30ad1e4c355de8bba3d45783/go/src/infra/cmd/skylab_swarming_worker/internal/autotest/admintask.go

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/72c8da67fb27d080f2fc6c7a216addfdf949df4c

commit 72c8da67fb27d080f2fc6c7a216addfdf949df4c
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 31 22:23:17 2018

skylab: Remove unused event package members

This package contains code originally shared with Lucifer in a
different repo.  This code is not needed by Skylab.

Bug:  878873 
Change-Id: I5712e3188edaedc029bf467e12ba40054b970195
Reviewed-on: https://chromium-review.googlesource.com/1195955
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17360}
[modify] https://crrev.com/72c8da67fb27d080f2fc6c7a216addfdf949df4c/go/src/infra/cmd/skylab_swarming_worker/internal/event/event.go
[modify] https://crrev.com/72c8da67fb27d080f2fc6c7a216addfdf949df4c/go/src/infra/cmd/skylab_swarming_worker/internal/event/event_test.go

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2f96a7208cf00ff83f55983c420a608f96f17b74

commit 2f96a7208cf00ff83f55983c420a608f96f17b74
Author: Allen Li <ayatane@chromium.org>
Date: Fri Aug 31 23:30:30 2018

skylab: Move functions closer to use site

R=tandrii@chromium.org

Bug:  878873 
Change-Id: I3863821b7347b2ec1c496d40b18d4240ba363e9d
Reviewed-on: https://chromium-review.googlesource.com/1195959
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17363}
[modify] https://crrev.com/2f96a7208cf00ff83f55983c420a608f96f17b74/go/src/infra/cmd/skylab_swarming_worker/internal/logdog/logdog.go
[modify] https://crrev.com/2f96a7208cf00ff83f55983c420a608f96f17b74/go/src/infra/cmd/skylab_swarming_worker/internal/logdog/logdog_posix.go

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e4e6abc3ec83701018f7eb89dd99198916f07894

commit e4e6abc3ec83701018f7eb89dd99198916f07894
Author: Allen Li <ayatane@chromium.org>
Date: Sat Sep 01 00:00:39 2018

skylab: Raise expected botcache test coverage

R=tandrii@chromium.org

Bug:  878873 
Change-Id: I70fd919ac80e6376d4f5139d46746780baa76b74
Reviewed-on: https://chromium-review.googlesource.com/1195960
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17366}
[modify] https://crrev.com/e4e6abc3ec83701018f7eb89dd99198916f07894/go/src/infra/cmd/skylab_swarming_worker/internal/swarming/botcache/botcache.infra_testing

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/92ab209043ead64ed5a9bb7cf26d8d4eef65b2a1

commit 92ab209043ead64ed5a9bb7cf26d8d4eef65b2a1
Author: Allen Li <ayatane@chromium.org>
Date: Sat Sep 01 10:26:37 2018

lucifer: Stop building skylab binary

BUG= chromium:878873 
TEST=None

Change-Id: I0cdcd4ba663b4ad1a632d07484b8f05c3f70f9d1
Reviewed-on: https://chromium-review.googlesource.com/1200447
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/92ab209043ead64ed5a9bb7cf26d8d4eef65b2a1/chromeos-base/lucifer/lucifer-9999.ebuild

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/0f271d9877f01785c8c95bab73d49e5831d1187e

commit 0f271d9877f01785c8c95bab73d49e5831d1187e
Author: Allen Li <ayatane@google.com>
Date: Tue Sep 04 20:39:46 2018

Remove skylab_swarming_worker code

BUG= chromium:878873 
TEST=None
CQ-DEPEND=CL:1200447

Change-Id: I80c5b3b045e12573fdd91495c5c61cf4024babec
Reviewed-on: https://chromium-review.googlesource.com/1199972
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/internal/swarming/harness/hostinfo.go
[modify] https://crrev.com/0f271d9877f01785c8c95bab73d49e5831d1187e/src/lucifer/autotest/atutil/types.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/annotee/basic/basic.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/internal/swarming/swarming.go
[modify] https://crrev.com/0f271d9877f01785c8c95bab73d49e5831d1187e/src/lucifer/autotest/atutil/hostinfo.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/internal/swarming/botcache/botcache.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/internal/swarming/botcache/botcache_test.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/annotee/client.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/logdog/logdog.go
[modify] https://crrev.com/0f271d9877f01785c8c95bab73d49e5831d1187e/src/lucifer/event/event_test.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/autotest/hostinfo_test.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/lucifer.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/internal/lucifer/lucifer.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/internal/swarming/harness/harness.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/internal/swarming/swarming_test.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/autotest/hostinfo.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/logdog.go
[modify] https://crrev.com/0f271d9877f01785c8c95bab73d49e5831d1187e/src/lucifer/event/event.go
[delete] https://crrev.com/49819d86ae1097b504c06c7683e79918609d041b/src/lucifer/cmd/skylab_swarming_worker/main.go

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/22fb33938611be3507ddc8dd6a16ad1fe4fe8111

commit 22fb33938611be3507ddc8dd6a16ad1fe4fe8111
Author: Allen Li <ayatane@chromium.org>
Date: Wed Sep 05 04:04:05 2018

lucifer: Remove unused dependencies

BUG= chromium:878873 
TEST=None
CQ-DEPEND=CL:1199972

Change-Id: Ie2dfc27e77631152e60a9894c243a68a483ad7ae
Reviewed-on: https://chromium-review.googlesource.com/1200326
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/22fb33938611be3507ddc8dd6a16ad1fe4fe8111/chromeos-base/lucifer/lucifer-9999.ebuild

Status: Fixed (was: Started)

Sign in to add a comment