New issue
Advanced search Search tips

Issue 878866 link

Starred by 1 user

Issue metadata

Status: Closed
Owner: ----
Closed: Jan 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 786559



Sign in to add a comment

Cronet native API CreateWith() could use OnDestroy()

Project Member Reported by pauljensen@chromium.org, Aug 29

Issue description

It might be nice to have some Cronet native API CreateWith() functions take OnDestroy() function pointers, even when the impl being created doesn't explicitly have an OnDestory() API.

This might be useful when creating fakes for testing.  For example to free resources associated with a fake Cronet_Engine.

This might also be useful if you try to use Cronet_Buffer_CreateWith() to make your own buffer impl...you [probably unexpectedly] won't receive Cronet_BufferCallbback_OnDestroy() call.  See https://chromium-review.googlesource.com/c/chromium/src/+/1007582
 
Blocking: 786559
Status: Closed (was: Untriaged)
It seems like we can live without it.

Sign in to add a comment