New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878853 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix Redundant Field Initializations and Create Errorprone Check Preventing New Ones

Project Member Reported by agrieve@chromium.org, Aug 29

Issue description

Android Studio has a clean-up for this, which we ran in 2016 in  bug 670001 .

Looks like a lot of crept back into the codebase, so we should run the inspection again, as well as write an ErrorProne check to stop them from happening.
 
A local run of the clean-up inspection shows:

Specifics:
        -4,767 bytes normalized apk size
        -1,020 bytes secondary dex size
          +348 bytes main dex size
InstallSize:
        -4,095 bytes APK size
     -6,809.88 bytes Estimated installed size
InstallBreakdown (-3,508.88 bytes):
            +1 bytes Package metadata size
     -3,509.88 bytes Java code size
Dex:
            +1 entries fields
            -6 entries methods
            +2 entries types
            +3 entries strings
Cc: estevenson@chromium.org wnwen@google.com smaier@chromium.org
Summary: Fix Redundant Field Initializations and Create Errorprone Check Preventing New Ones (was: Remove and Create Errorprone Check for Redundant Field Initialization)
Cc: -wnwen@google.com wnwen@chromium.org
Cc: abenner@google.com
Owner: abenner@google.com
Horray, thanks for taking this task Aiden!
Feel free to send code reviews to myself or smaier@
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/7f20d9bb3fca44c170f17fda2c4c80f52136278c

commit 7f20d9bb3fca44c170f17fda2c4c80f52136278c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 04 20:09:29 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55ef50b112478acfcb703d1c578023d0c1106dc4

commit 55ef50b112478acfcb703d1c578023d0c1106dc4
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 04 19:52:29 2018

Android: Remove explicit initialization of default values in //chrome

Bug:  878853 
Change-Id: I0cd991415bc388f846a49d62e916f19d2287fb50
Reviewed-on: https://chromium-review.googlesource.com/1195546
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588624}
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarBannerControl.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPreferenceHelper.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/crash/PureJavaExceptionReporter.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundServiceManager.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/media/MediaViewerUtils.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/ChromeCastSessionManager.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/remoting/RemotingCastSession.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/modelutil/SimpleList.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/DeviceConditions.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTask.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceHost.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthenticationFragment.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/ReauthenticationManager.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/subresource_filter/TestSubresourceFilterPublisher.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/vr/NoopCanvas.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/GvrKeyboardLoaderClient.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateTask.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/webauth/AuthenticatorImpl.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorFieldModel.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/ShareIntentTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelEventFilterTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTestRule.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService2.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/DelayedInvalidationsControllerTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MockMediaRouteProvider.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandlerTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/provider/ProviderBookmarkNodeUnitTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsSheetVisibilityChangeObserverTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrCoreVersionChecker.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorSurfaceManagerImplTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMessageHandlerTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsUnitTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderUnitTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkServiceConnectionManagerTest.java
[modify] https://crrev.com/55ef50b112478acfcb703d1c578023d0c1106dc4/chrome/android/webapk/shell_apk/javatests/dex_optimizer/src/org/chromium/webapk/shell_apk/test/dex_optimizer/DexOptimizerServiceImpl.java

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4562b2a1d9b00655c6d405ec9f54066e63e2a24c

commit 4562b2a1d9b00655c6d405ec9f54066e63e2a24c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 04 21:43:32 2018

Android: Remove redundant field initialization for non-//chrome java

TBR=agrieve  # Mechanical refactor

Bug:  878853 
Change-Id: I8d8f80cc3f7ea2b3d245ac5c9bf7c8be6e1511ee
Reviewed-on: https://chromium-review.googlesource.com/1194961
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588651}
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/android_webview/java/src/org/chromium/android_webview/AwSettings.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/android_webview/java/src/org/chromium/android_webview/services/AwMinidumpUploaderDelegate.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/android_webview/java/src/org/chromium/android_webview/services/CrashReceiverService.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewLayoutTestActivity.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/android_webview/unittestjava/src/org/chromium/android_webview/unittest/InputStreamUnittest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/base/android/java/src/org/chromium/base/EarlyTraceEvent.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/base/android/javatests/src/org/chromium/base/ObserverListTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/components/background_task_scheduler/android/junit/src/org/chromium/components/background_task_scheduler/TestBackgroundTask.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploaderImplTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerFacade.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/java/src/org/chromium/content/browser/remoteobjects/RemoteObjectRegistry.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/java/src/org/chromium/content/browser/selection/SelectionEventProxyImpl.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeActivityTestRule.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/javatests/src/org/chromium/content/browser/androidoverlay/DialogOverlayImplTestRule.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/content/public/android/javatests/src/org/chromium/content/browser/remoteobjects/RemoteObjectHostImplTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/device/gamepad/android/java/src/org/chromium/device/gamepad/GamepadMappings.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/media/base/android/java/src/org/chromium/media/AudioTrackOutputStream.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/media/base/android/java/src/org/chromium/media/MediaCodecEncoder.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/media/base/android/java/src/test/org/chromium/media/MediaFormatBuilderTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/mojo/public/java/system/javatests/src/org/chromium/mojo/MojoTestRule.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/mojo/public/java/system/javatests/src/org/chromium/mojo/bindings/BindingsTestUtils.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/mojo/public/java/system/javatests/src/org/chromium/mojo/bindings/InterfaceControlMessageTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/mojo/public/java/system/javatests/src/org/chromium/mojo/bindings/InterfacesTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/net/test/android/javatests/src/org/chromium/net/test/util/WebServer.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/Desktop.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/RenderData.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/SwipePinchDetector.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/services/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java
[modify] https://crrev.com/4562b2a1d9b00655c6d405ec9f54066e63e2a24c/testing/android/native_test/java/src/org/chromium/native_test/NativeTest.java

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813b3ff55cf061b3379e9259de12e8227d745b49

commit 813b3ff55cf061b3379e9259de12e8227d745b49
Author: Aiden Benner <abenner@google.com>
Date: Fri Sep 07 21:12:41 2018

Cronet: Fix redundant field initializations

In preparation for enabling an ErrorProne check to ban them

Bug:  878853 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I9cf9b07303fb3b00ce4d904f8fe56f47bb0b6268
Reviewed-on: https://chromium-review.googlesource.com/1213880
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#589649}
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/impl/LoadState.template
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetChunkedOutputStream.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/java/src/org/chromium/net/urlconnection/MessageLoop.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/CronetTestRule.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/TestBidirectionalStreamCallback.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/TestUploadDataProvider.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/MessageLoopTest.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/src/org/chromium/net/QuicTestServer.java
[modify] https://crrev.com/813b3ff55cf061b3379e9259de12e8227d745b49/components/cronet/android/test/src/org/chromium/net/TestUploadDataStreamHandler.java

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4

commit 6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4
Author: Aiden Benner <abenner@google.com>
Date: Mon Sep 10 14:10:53 2018

Chromecast: Fix redundant field initializations

In preparation for enabling an ErrorProne check to ban them

Bug:  878853 
Change-Id: I267c5260c03e768ebcb732fed1a8966c4f598857
Reviewed-on: https://chromium-review.googlesource.com/1214086
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#589900}
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/base/java/src/org/chromium/chromecast/base/Controller.java
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/base/java/src/org/chromium/chromecast/base/Unit.java
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastAudioManager.java
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashUploaderFactory.java
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsComponent.java
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsSurfaceHelper.java
[modify] https://crrev.com/6d35c8db2994de3c8ee72fc5a9da9abfb188e5e4/chromecast/browser/android/junit/src/org/chromium/chromecast/shell/CastWebContentsSurfaceHelperTest.java

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87

commit fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87
Author: Aiden Benner <abenner@google.com>
Date: Mon Sep 10 21:23:46 2018

Add ErrorProne check for redundant initialization of non-final fields

e.g. public int x = 0;
     public boolean x = false;

- Adds errorprone rule that will detect when fields are initialized to default values
  (results in larger class sizes and can't be optimized away
  see https://issuetracker.google.com/issues/37124982)
- Refactor current redundant initializations
- Fix cases where classes were being generated with redundant initializations

TBR=agrieve
Bug:  878853 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ia76a02ea73a55f2fa66b4ef6461ac985eba574bb
Reviewed-on: https://chromium-review.googlesource.com/1209547
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590067}
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/base/android/java/templates/BuildConfig.template
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/base/android/java/templates/NativeLibraries.template
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/build/android/gyp/util/resource_utils.py
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/chrome/android/java/src/org/chromium/chrome/browser/feature_engagement/ScreenshotMonitor.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartNetworkSeriesView.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartView.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/tools/android/audio_focus_grabber/java/src/org/chromium/tools/audio_focus_grabber/AudioFocusGrabberListenerService.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/tools/android/errorprone_plugin/BUILD.gn
[add] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoRedundantFieldInitCheck.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/tools/android/memconsumer/java/src/org/chromium/memconsumer/MemConsumer.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/tools/android/memconsumer/java/src/org/chromium/memconsumer/ResidentService.java
[modify] https://crrev.com/fa02ec1eb9b0e5ddc89466fd3ca1ace8489d5c87/ui/platform_window/android/java/src/org/chromium/ui/PlatformImeControllerAndroid.java

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/b69ea548d2b8949896502b052f24c2bca380c560

commit b69ea548d2b8949896502b052f24c2bca380c560
Author: Andrew Grieve <agrieve@chromium.org>
Date: Tue Sep 11 00:47:26 2018

Status: Fixed (was: Assigned)

Sign in to add a comment