This includes Image storage - stub Image data storage - interface, disk stub Image metadata storage - interface, leveldb stub
The NextAction date has arrived: 2018-09-11
Cached image fetcher is considered nice to have for pre-stable experimenting (M71). We mark everything as P3 (not needed by the branch point). We'll re-prioritize after.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb718158f3a840a43a6eaf7487216dd881fd688b commit cb718158f3a840a43a6eaf7487216dd881fd688b Author: Brandon Wylie <wylieb@chromium.org> Date: Wed Sep 12 19:26:08 2018 [IC] Stub out storage interfaces and classes Storage for the Cached Image Fetcher handled by image_storage. image_storage delegates the storage of meta/data to image_metadata_storage and image_data_storage respectively. There are two stubs of concrete classes included here: metadata -> leveldb and data -> disk. In the near future, I will want to supplement meta/data storage for a separate format (such as ephemeral), which is why I hid them behind an interface even through there's only one implementer per interface. Bug: 878848 Change-Id: Ibd7052935f8a7f10d98d94122ee0b7f86489ca2a Reviewed-on: https://chromium-review.googlesource.com/1189051 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590783} [modify] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/BUILD.gn [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/BUILD.gn [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/DEPS [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_cache.cc [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_cache.h [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_data_store.h [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_data_store_disk.cc [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_data_store_disk.h [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_metadata_store.h [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_metadata_store_leveldb.cc [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_metadata_store_leveldb.h [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/image_store_types.h [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/proto/BUILD.gn [add] https://crrev.com/cb718158f3a840a43a6eaf7487216dd881fd688b/components/image_fetcher/core/storage/proto/cached_image_metadata.proto
Comment 1 by wylieb@chromium.org
, Sep 5