Now that we have network quality tracker (which can be accessed on UI thread), there is not much need of UI network quality estimator service. We should get rid of it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c4824e8a6f52caec80f7a9b57c22ee708114ef7 commit 7c4824e8a6f52caec80f7a9b57c22ee708114ef7 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Aug 29 17:34:27 2018 Servicification of NQE in Android PLM observer In Android Page Load Metrics (PLM) observer, use network quality tracker (NQT) instead of Network Quality Estimator (NQE). Change-Id: I63931acb6842b01ae135a0f96de64c52d7e146d7 Bug: 878844 Reviewed-on: https://chromium-review.googlesource.com/1189707 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#587179} [modify] https://crrev.com/7c4824e8a6f52caec80f7a9b57c22ee708114ef7/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc [modify] https://crrev.com/7c4824e8a6f52caec80f7a9b57c22ee708114ef7/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h [modify] https://crrev.com/7c4824e8a6f52caec80f7a9b57c22ee708114ef7/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd2ac01ea887fdb8bf15920030be087769bfda55 commit bd2ac01ea887fdb8bf15920030be087769bfda55 Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Aug 30 21:53:13 2018 Simplify UI network quality estimator service UI network quality estimator service no longer needs to implement network quality provider since we now have network quality tracker. This CL simplifies the logic in UI network quality estimator service by removing the unnecessary code. Bug: 878844 Change-Id: I7d97bc29452a73d5a6f522b58cca3c67e5368e77 Reviewed-on: https://chromium-review.googlesource.com/1196005 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#587798} [modify] https://crrev.com/bd2ac01ea887fdb8bf15920030be087769bfda55/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc [modify] https://crrev.com/bd2ac01ea887fdb8bf15920030be087769bfda55/chrome/browser/net/nqe/ui_network_quality_estimator_service.h [modify] https://crrev.com/bd2ac01ea887fdb8bf15920030be087769bfda55/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb8fcc33970e4ac2905c95d1e5e60c8bdac93e08 commit fb8fcc33970e4ac2905c95d1e5e60c8bdac93e08 Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Oct 29 23:16:08 2018 Make NQE classes private to //net Classes outside of //net should use Network Quality Tracker instead of Network Quality Estimator (NQE). Change-Id: Iaf9d940c862f322f14eacb20391354e5cc7cb9cd Bug: 878844 Reviewed-on: https://chromium-review.googlesource.com/c/1305203 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603680} [modify] https://crrev.com/fb8fcc33970e4ac2905c95d1e5e60c8bdac93e08/net/nqe/effective_connection_type_observer.h [modify] https://crrev.com/fb8fcc33970e4ac2905c95d1e5e60c8bdac93e08/net/nqe/network_quality_estimator.h [modify] https://crrev.com/fb8fcc33970e4ac2905c95d1e5e60c8bdac93e08/net/nqe/network_quality_store.h [modify] https://crrev.com/fb8fcc33970e4ac2905c95d1e5e60c8bdac93e08/net/nqe/rtt_throughput_estimates_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f27ab97392174654d751c8acd5943dc4dad60f4 commit 5f27ab97392174654d751c8acd5943dc4dad60f4 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Nov 07 01:11:30 2018 Move NQE prefs from browser process to network Currently, Network Quality Estimator (NQE) stores prefs on the disk. These prefs are managed (written t0 and read by) in the browser process, and then notified to the network quality estimator object. With network servicification, NQE object would live in the network process, and would no longer be accessible in the browser process. This CL moves the management of prefs from the browser process to the network process. Bug: 878844 Change-Id: Id533c2260201c0c665ae3bde1a0fe955a140a70e Reviewed-on: https://chromium-review.googlesource.com/c/1312977 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#605910} [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/chrome/browser/BUILD.gn [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/OWNERS [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/ui_network_quality_estimator_service.h [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.cc [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.h [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.cc [delete] https://crrev.com/021d9e70103633e54c8304e1091721929c3b3e1d/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/chrome/test/BUILD.gn [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/net/nqe/network_qualities_prefs_manager.cc [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/net/nqe/network_qualities_prefs_manager.h [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/services/network/BUILD.gn [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/services/network/network_context.cc [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/services/network/network_context.h [modify] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/services/network/network_context_unittest.cc [add] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/services/network/network_qualities_pref_delegate.cc [add] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/services/network/network_qualities_pref_delegate.h [add] https://crrev.com/5f27ab97392174654d751c8acd5943dc4dad60f4/services/network/network_qualities_pref_delegate_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77cc59851a3547cd1bfca2d108f3e8a27dbde10c commit 77cc59851a3547cd1bfca2d108f3e8a27dbde10c Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Nov 12 22:00:39 2018 Make NQE prefs manager a single threaded class With servicification, NQE (Network Quality Estimator) prefs manager can be used on a single thread. This CL makes NQE prefs manager a single threaded class by combining methods that were previously executed over separate threads. Change-Id: Ic332bfeecc77f7d3401cd63ce1126f954fbbefc8 Bug: 878844 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1331178 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#607344} [modify] https://crrev.com/77cc59851a3547cd1bfca2d108f3e8a27dbde10c/net/nqe/network_qualities_prefs_manager.cc [modify] https://crrev.com/77cc59851a3547cd1bfca2d108f3e8a27dbde10c/net/nqe/network_qualities_prefs_manager.h [modify] https://crrev.com/77cc59851a3547cd1bfca2d108f3e8a27dbde10c/net/nqe/network_qualities_prefs_manager_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Aug 29