New issue
Advanced search Search tips

Issue 878833 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-5


Sign in to add a comment

Recently Closed items are truncated when closing about:blank page

Project Member Reported by shbarezer@chromium.org, Aug 29

Issue description

App Version: 70.0.3536.0 canary
iOS Version: 11.4., 12.0 beta 10
Devices:  iPhone X , iPhone7

Steps to reproduce:
1. Launch Google Chrome
2. Enter about:blank 
3. Enter about:blank
4. Tap on Tab switcher
5. Close the about:blank tab
5. Tap on Other Devices

Observed results: Recently Closed items are truncated when closing about:blank page

Expected results: Recently Closed items should not be truncated when closing about:blank page

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on the current stable build :M68, No
Bug reproducible on the current beta channel build :M69, Yes

Link to Image:
https://drive.google.com/file/d/1vQ8wTDJ8no07ko_qZtq4apniHJW4RyNS/view
Video:
https://drive.google.com/file/d/1tQltZquLmtb3-QQaCkUcOzngH9o0f3n0/view


 
Labels: -Pri-2 ReleaseBlock-Stable M-70 Pri-1
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)
Cc: sczs@chromium.org
Owner: thegreenfrog@chromium.org
+thegreenfrog, PTAL. Not sure how common is to get an about:blank page other than typing it, not sure if this should stay an RBS, we can decide to CP or not depending on the Fix
Status: Started (was: Assigned)
I personally don't think this should be RBS. This only hits when both the title and description are absent, which is extremely rare.
We should keep this as RBS for now, work on a fix, and then decide whether it should make M70 based on the fix.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fa2688ab8d8e8dca70a6417dfc2eaa84be9efd1

commit 1fa2688ab8d8e8dca70a6417dfc2eaa84be9efd1
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Fri Sep 21 19:38:07 2018

[ios] Fix height issue when TableViewUrlCell doesn't have title or host.

- Require minimum height equal the height of the favicon for the vertical stackview in TableViewUrlCell
- If title and host aren't available, use full url spec.

Screenshot: https://drive.google.com/file/d/1C19zooJG80phfS6gDiCnMZQa2NZJd9zA/view?usp=sharing

Bug:  878833 
Change-Id: I11e91f583f014f88a208478bef767cb70972ce7b
Reviewed-on: https://chromium-review.googlesource.com/1235319
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593303}
[modify] https://crrev.com/1fa2688ab8d8e8dca70a6417dfc2eaa84be9efd1/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm

Cc: kariahda@chromium.org
Status: Fixed (was: Started)
kariahda@ I don't this realistically hits many cases aside from about:blank, so do you think we should still cherry-pick?
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-70
verified on canary on 9/27
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 28

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: Less than 14 days to go before AppStore submit on M70
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Verified (was: Fixed)
Verified on 71.0.3567.0 Canary, iPhone X  iOS 11.4.1
Looks good.

https://drive.google.com/file/d/1gYZLZTLd0_4vB8SVnnKVBPgD3EWAn6sZ/view
1. Per comment 6, what are the other cases besides about:blank?
2. How confident are you in this fix?
3. Can the fix possibly break something else?
1. I couldn't find another case where there is no actual hostname in the url request.

2/3. I am pretty confident this will fix the issue. Pre-Bijou, we used the whole url instead of just the hostname. The fix just has one final fallback to the whole url. This shouldn't break something else since it is just adding another case to what the subtitle can show.
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved. Please merge asap so this can make beta tomorrow.
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 3

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/764c1291e5b904276d981dab5c80fbc60b96857b

commit 764c1291e5b904276d981dab5c80fbc60b96857b
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Wed Oct 03 14:01:42 2018

[ios] Fix height issue when TableViewUrlCell doesn't have title or host.

- Require minimum height equal the height of the favicon for the vertical stackview in TableViewUrlCell
- If title and host aren't available, use full url spec.

Screenshot: https://drive.google.com/file/d/1C19zooJG80phfS6gDiCnMZQa2NZJd9zA/view?usp=sharing

Bug:  878833 
Change-Id: I11e91f583f014f88a208478bef767cb70972ce7b
Reviewed-on: https://chromium-review.googlesource.com/1235319
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593303}(cherry picked from commit 1fa2688ab8d8e8dca70a6417dfc2eaa84be9efd1)
Reviewed-on: https://chromium-review.googlesource.com/c/1258621
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#835}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/764c1291e5b904276d981dab5c80fbc60b96857b/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/764c1291e5b904276d981dab5c80fbc60b96857b

Commit: 764c1291e5b904276d981dab5c80fbc60b96857b
Author: thegreenfrog@chromium.org
Commiter: thegreenfrog@chromium.org
Date: 2018-10-03 14:01:42 +0000 UTC

[ios] Fix height issue when TableViewUrlCell doesn't have title or host.

- Require minimum height equal the height of the favicon for the vertical stackview in TableViewUrlCell
- If title and host aren't available, use full url spec.

Screenshot: https://drive.google.com/file/d/1C19zooJG80phfS6gDiCnMZQa2NZJd9zA/view?usp=sharing

Bug:  878833 
Change-Id: I11e91f583f014f88a208478bef767cb70972ce7b
Reviewed-on: https://chromium-review.googlesource.com/1235319
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593303}(cherry picked from commit 1fa2688ab8d8e8dca70a6417dfc2eaa84be9efd1)
Reviewed-on: https://chromium-review.googlesource.com/c/1258621
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#835}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Verified in 70.0.3538.48 Beta in iPhone 8plus(iOS 11.4.1), iPhone 6s plus(iOS 12.1 beta2)

Looks good.

Sign in to add a comment